Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-27 01:28:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow value repeat operator on references

Browse Source 
Currently it's not possible to use the value repeat operator on references:
```
print ((int &) v_int_array_init[0])@2
Only values in memory can be extended with '@'.
```

This seems like an unnecessary restriction, since it also prevents
its use on iterators (which was the original reported problem):
```
(gdb) p *it@2
Only values in memory can be extended with '@'.
```

So this converts any references to the referenced value in value_repeat,
making this possible:
```
print ((int &) v_int_array_init[0])@2
$1 = {10, 20}
(gdb) p *it@2
$2 = {1, 2}
```

Approved-by: Kevin Buettner <kevinb@redhat.com>
This commit is contained in:
Hannes Domani
2024-02-09 20:25:29 +01:00
parent 4199cf1e15
commit 6b991efe7b
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gdb/testsuite/gdb.base/exprs.exp
View File

@@ -259,6 +259,7 @@ gdb_test {print *v_int_array_init@2} { = \{10, 20\}}
gdb_test {print v_int_array_init[0]@1} { = \{10\}}
gdb_test {print v_int_array_init[0]@2} { = \{10, 20\}}
gdb_test {print v_int_array_init[1]@1} { = \{20\}}
gdb_test {print ((int &) v_int_array_init[0])@2} { = \{10, 20\}}
# gdb's {} extension
gdb_test_no_output "set variable v_short_array\[0\] = 42"

2
gdb/valops.c
View File

@@ -1349,6 +1349,8 @@ value_repeat (struct value *arg1, int count)
{
struct value *val;
arg1 = coerce_ref (arg1);
if (arg1->lval () != lval_memory)
error (_("Only values in memory can be extended with '@'."));
if (count < 1)