Clean up "return -1" in gdb.rust

This changes gdb.rust tests to use plain "return" rather than
"return -1".  In these spots, the "-1" has no meaning.

Approved-by: Kevin Buettner <kevinb@redhat.com>

gdb/testsuite/gdb.rust/completion.exp

@@ -22,13 +22,13 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 with_timeout_factor 2 {

gdb/testsuite/gdb.rust/dwindex.exp

@@ -22,12 +22,12 @@ require {can_compile rust}
 standard_testfile .rs
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 if {[ensure_gdb_index $binfile -dwarf-5] == -1} {
     untested "error adding gdb index"
-    return -1
+    return
 }
 
 gdb_exit

gdb/testsuite/gdb.rust/finish.exp

@@ -21,13 +21,13 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "BREAK"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 # This 'finish' used to crash.  See PR rust/30090.  Also, this does

gdb/testsuite/gdb.rust/fnfield.exp

@@ -21,13 +21,13 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "print foo.f()" " = 6" "call impl function"

gdb/testsuite/gdb.rust/generics.exp

@@ -21,13 +21,13 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "print identity::<u32>(23u32)" " = 23"

gdb/testsuite/gdb.rust/main-crash.exp

@@ -22,14 +22,14 @@ require {can_compile rust}
 standard_testfile main.rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile \
 	 {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "BREAK"]
 # The bug was that this would crash.
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 # Test that gdb is alive.

gdb/testsuite/gdb.rust/methods.exp

@@ -21,13 +21,13 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint 1 here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "print x" " = methods::HasMethods \\{value: 0\\}"

gdb/testsuite/gdb.rust/modules.exp

@@ -21,13 +21,13 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 # Currently a closure type is not described by rustc.

gdb/testsuite/gdb.rust/onetwoeight.exp

@@ -22,18 +22,18 @@ require {can_compile rust}
 set v [split [rust_compiler_version] .]
 if {[lindex $v 0] == 1 && [lindex $v 1] < 43} {
     untested "128-bit ints require rust 1.43 or greater"
-    return -1
+    return
 }
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "BREAK"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "print x" " = 340282366920938463463374607431768211455"

gdb/testsuite/gdb.rust/pp.exp

@@ -22,7 +22,7 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set remote_python_file [gdb_remote_download host \
@@ -32,7 +32,7 @@ gdb_test_no_output "source ${remote_python_file}" "load python file"
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "print outer" " = pp::Outer \\(x\\(5\\)\\)"

gdb/testsuite/gdb.rust/rawids.exp

@@ -22,13 +22,13 @@ require {rust_at_least 1.30}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "print r#if" " = 23"

gdb/testsuite/gdb.rust/rust-start.exp

@@ -25,13 +25,13 @@ require !use_gdb_stub
 
 standard_testfile simple.rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 # Verify that "start" lands inside the right procedure.
 if {[gdb_start_cmd] < 0} {
     unsupported "start failed"
-    return -1
+    return
 }
 
 gdb_test "" \

gdb/testsuite/gdb.rust/rust-style.exp

@@ -23,13 +23,13 @@ with_ansi_styling_terminal {
     standard_testfile .rs
     if {[prepare_for_testing "failed to prepare" $testfile $srcfile \
 	     {debug rust}]} {
-	return -1
+	return
     }
 
     set line [gdb_get_line_number "breakpoint"]
     if {![runto ${srcfile}:$line]} {
 	untested "could not run to breakpoint"
-	return -1
+	return
     }
 
     set vfield [style value variable]

gdb/testsuite/gdb.rust/simple.exp

@@ -21,13 +21,13 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "print a" " = \\(\\)"

gdb/testsuite/gdb.rust/traits.exp

@@ -21,7 +21,7 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set readelf_program [gdb_find_readelf]
@@ -39,7 +39,7 @@ if {![regexp DW_AT_containing_type $output]} {
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "print *td" " = 23.5"

gdb/testsuite/gdb.rust/unicode.exp

@@ -28,13 +28,13 @@ setenv LC_ALL C.UTF-8
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "print 𝕯" " = 98" "print D"

gdb/testsuite/gdb.rust/union.exp

@@ -21,13 +21,13 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "print u" " = union::Union {f1: -1, f2: 255}"

gdb/testsuite/gdb.rust/unsized.exp

@@ -21,13 +21,13 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 gdb_test "ptype us" " = .*V<\\\[u8\\\]>.*"

gdb/testsuite/gdb.rust/unsized2.exp

@@ -22,13 +22,13 @@ require {rust_at_least 1.61}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 set base_value \

gdb/testsuite/gdb.rust/watch.exp

@@ -21,13 +21,13 @@ require {can_compile rust}
 
 standard_testfile .rs
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug rust}]} {
-    return -1
+    return
 }
 
 set line [gdb_get_line_number "set breakpoint here"]
 if {![runto ${srcfile}:$line]} {
     untested "could not run to breakpoint"
-    return -1
+    return
 }
 
 # Just setting a watchpoint was enough to trigger the bug.