Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 09:08:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use std::string in print_one_catch_syscall

Browse Source 
This changes print_one_catch_syscall to use std::string, removing a
bit of manual memory management.
This commit is contained in:
Tom Tromey
2021-10-03 08:16:50 -06:00
parent 6f781ee300
commit 570bc7936f
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
gdb/break-catch-syscall.c
View File

@@ -250,28 +250,24 @@ print_one_catch_syscall (struct breakpoint *b,
if (!c->syscalls_to_be_caught.empty ())
{
char *text = xstrprintf ("%s", "");
std::string text;
bool first = true;
for (int iter : c->syscalls_to_be_caught)
{
char *previous_text = text;
struct syscall s;
get_syscall_by_number (gdbarch, iter, &s);
if (s.name != NULL)
text = xstrprintf ("%s%s, ", text, s.name);
else
text = xstrprintf ("%s%d, ", text, iter);
if (!first)
text += ", ";
first = false;
/* We have to xfree previous_text because xstrprintf dynamically
allocates new space for text on every call. */
xfree (previous_text);
if (s.name != NULL)
text += s.name;
else
text += std::to_string (iter);
}
/* Remove the last comma. */
text[strlen (text) - 2] = '\0';
uiout->field_string ("what", text);
/* xfree last text. */
xfree (text);
uiout->field_string ("what", text.c_str ());
}
else
uiout->field_string ("what", "<any syscall>", metadata_style.style ());