forked from Imagelibrary/binutils-gdb
f9e59d060f
While reviewing a patch sent to the mailing list, I noticed there are few places where python code checks if a variable is 'None' or not by using the comparison operators '==' and '!='. PEP8[1], which is used as coding standard in GDB coding standards, recommends using 'is' / 'is not' when comparing to a singleton such as 'None'. This patch proposes to change the instances of '== None' by 'is None' and '!= None' by 'is not None'. [1] https://www.python.org/dev/peps/pep-0008/ gdb/doc/ChangeLog: * python.texi (Writing a Pretty-Printer): Use 'is None' instead of '== None'. gdb/ChangeLog: * python/lib/gdb/FrameDecorator.py (FrameDecorator): Use 'is None' instead of '== None'. (FrameVars): Use 'is not None' instead of '!= None'. * python/lib/gdb/command/frame_filters.py (SetFrameFilterPriority): Use 'is None' instead of '== None' and 'is not None' instead of '!= None'. gdb/testsuite/ChangeLog: * gdb.base/premature-dummy-frame-removal.py (TestUnwinder): Use 'is None' instead of '== None' and 'is not None' instead of '!= None'. * gdb.python/py-frame-args.py (lookup_function): Same. * gdb.python/py-framefilter-invalidarg.py (Reverse_Function): Same. * gdb.python/py-framefilter.py (Reverse_Function): Same. * gdb.python/py-nested-maps.py (lookup_function): Same. * gdb.python/py-objfile-script-gdb.py (lookup_function): Same. * gdb.python/py-prettyprint.py (lookup_function): Same. * gdb.python/py-section-script.py (lookup_function): Same. * gdb.python/py-unwind-inline.py (dummy_unwinder): Same. * gdb.python/python.exp: Same. * gdb.rust/pp.py (lookup_function): Same.
61 lines
1.8 KiB
Python
61 lines
1.8 KiB
Python
# Copyright (C) 2021 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This dummy unwinder will break GDB's backtrce at the function called
|
|
# 'break_bt_here'.
|
|
|
|
import gdb
|
|
from gdb.unwinder import Unwinder
|
|
|
|
|
|
class FrameId(object):
|
|
def __init__(self, sp, pc):
|
|
self._sp = sp
|
|
self._pc = pc
|
|
|
|
@property
|
|
def sp(self):
|
|
return self._sp
|
|
|
|
@property
|
|
def pc(self):
|
|
return self._pc
|
|
|
|
|
|
class TestUnwinder(Unwinder):
|
|
def __init__(self):
|
|
Unwinder.__init__(self, "break unwinding")
|
|
|
|
def __call__(self, pending_frame):
|
|
pc_desc = pending_frame.architecture().registers().find("pc")
|
|
pc = pending_frame.read_register(pc_desc)
|
|
|
|
sp_desc = pending_frame.architecture().registers().find("sp")
|
|
sp = pending_frame.read_register(sp_desc)
|
|
|
|
block = gdb.block_for_pc(int(pc))
|
|
if block is None:
|
|
return None
|
|
func = block.function
|
|
if func is None:
|
|
return None
|
|
if str(func) != "break_bt_here":
|
|
return None
|
|
fid = FrameId(pc, sp)
|
|
return pending_frame.create_unwind_info(fid)
|
|
|
|
|
|
gdb.unwinder.register_unwinder(None, TestUnwinder(), True)
|