forked from Imagelibrary/binutils-gdb
e15c3eb45b
The following patch fixes several outstanding overload resolution problems
with rvalue references and cv qualifiers in the test suite. The tests for
these problems typically passed with one compiler version and failed with
another. This behavior occurs because of the ordering of the overloaded
functions in the debug info. So the first best match "won out" over the
a subsequent better match.
One of the bugs addressed by this patch is the failure of rank_one_type to
account for type equality of two overloads based on CV qualifiers. This was
leading directly to problems evaluating rvalue reference overload quality,
but it is also highlighted in gdb.cp/oranking.exp, where two test KFAIL as
a result of this shortcoming.
I found the overload resolution code committed with the rvalue reference
patch (f9aeb8d49) needlessly over-complicated, and I have greatly simplified
it. This fixes some KFAILing tests in gdb.exp/rvalue-ref-overload.exp.
gdb/ChangeLog
* gdbtypes.c (LVALUE_REFERENCE_TO_RVALUE_BINDING_BADNESS)
DIFFERENT_REFERENCE_TYPE_BADNESS): Remove.
(CV_CONVERSION_BADNESS): Define.
(rank_one_type): Remove overly restrictive rvalue reference
rank checks.
Add cv-qualifier checks and subranks for type equality.
* gdbtypes.h (REFERENCE_CONVERSION_RVALUE,
REFERENCE_CONVERSION_CONST_LVALUE, CV_CONVERSION_BADNESS,
CV_CONVERSION_CONST, CV_CONVERSION_VOLATILE): Declare.
gdb/testsuite/ChangeLog
* gdb.cp/oranking.cc (test15): New function.
(main): Call test15 and declare additional variables for testing.
* gdb.cp/oranking.exp: Remove kfail status for "p foo4(&a)" and
"p foo101('abc')" tests.
* gdb.cp/rvalue-ref-overloads.exp: Remove kfail status for
"lvalue reference overload" test.
* gdb.cp/rvalue-ref-params.exp: Remove kfail status for
"print value of f1 on Child&& in f2" test.
69 lines
2.1 KiB
Plaintext
69 lines
2.1 KiB
Plaintext
# Copyright 2006-2017 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Tests for rvalue reference parameters of types and their subtypes in GDB,
|
|
# based on gdb.cp/ref-params.exp.
|
|
|
|
if {[skip_cplus_tests]} { continue }
|
|
|
|
standard_testfile .cc
|
|
|
|
if {[prepare_for_testing $testfile.exp $testfile $srcfile \
|
|
{debug c++ additional_flags="-std=gnu++11"}] == 1} {
|
|
return -1
|
|
}
|
|
|
|
proc gdb_start_again {text prefix} {
|
|
global binfile
|
|
global srcfile
|
|
|
|
with_test_prefix $prefix {
|
|
clean_restart $binfile
|
|
|
|
runto ${srcfile}:[gdb_get_line_number $text]
|
|
}
|
|
}
|
|
|
|
set t "print value of f1 on (Child&&) in main"
|
|
gdb_start_again "marker1 here" $t
|
|
gdb_test "print f1(static_cast<Child&&>(Q))" ".* = 40.*" $t
|
|
|
|
set t "print value of f2 on (Child&&) in main"
|
|
gdb_start_again "marker1 here" $t
|
|
gdb_test "print f2(static_cast<Child&&>(Q))" ".* = 40.*" $t
|
|
|
|
set t "print value of Child&& in f2"
|
|
gdb_start_again "marker2 here" $t
|
|
gdb_test "print C" ".*id = 42.*" $t
|
|
|
|
gdb_test "print f1 (static_cast<Child&&> (C))" ".* = 42.*" \
|
|
"print value of f1 on Child&& in f2"
|
|
|
|
set t "print value of Parent&& in f1"
|
|
gdb_start_again "marker3 here" $t
|
|
gdb_test "print R" ".*id = 41.*" $t
|
|
|
|
set t "print f1(static_cast<MultiChild&&>(MQ))"
|
|
gdb_start_again "breakpoint MQ here" $t
|
|
gdb_test $t ".* = 53"
|
|
|
|
set t "print mf1(static_cast<MultiChild&&>(MQ))"
|
|
gdb_start_again "breakpoint MQ here" $t
|
|
gdb_test $t ".* = 106"
|
|
|
|
set t "print mf2(static_cast<MultiChild&&>(MQ))"
|
|
gdb_start_again "breakpoint MQ here" $t
|
|
gdb_test $t ".* = 106"
|