forked from Imagelibrary/binutils-gdb
e5713223cb
Revert parts of commit fee24f1c5b ("objdump improvements for mips
elf64"), <https://sourceware.org/ml/binutils/2003-03/msg00108.html>, and
make the `->reloc_count' member of `struct bfd_section' hold the actual
number of internal relocations stored in its `->relocation' vector. To
do so adjust `mips_elf64_slurp_one_reloc_table' to set `->reloc_count'
to the actual number of internal relocations retrieved and discard
`mips_elf64_canonicalize_reloc', `mips_elf64_canonicalize_dynamic_reloc'
and their corresponding target macros. Contrary to the description of
`mips_elf64_slurp_one_reloc_table', adjusted appropriately, this makes
generic relocation processing code happy and satisfies the "merge notes
section" binutils test case.
Add extra binutils test cases to expand the coverage of the generic
"merge notes section" test case, now passing with the n64 ABI, across
the MIPS o32, n32 and n64 ABIs regardless of the default ABI selected in
target configuration, and also to verify correctness of the relocations
produced. Conversely, do not provide any additional test cases for the
original issue addressed with the commit referred:
- objdump would display only 1/3 of the total number of relocations,
because it used the external relocation count, but each external
relocation is brought in as 3 internal relocations.
as n64 ABI relocation processing with `objdump -r' and `objdump -R' is
already widely covered across the GAS and LD test suites.
bfd/
* elf64-mips.c (mips_elf64_canonicalize_reloc): Remove prototype
and function.
(mips_elf64_canonicalize_dynamic_reloc): Likewise.
(mips_elf64_slurp_one_reloc_table): Set `reloc_count' to the
actual number of internal relocations retrieved. Adjust
function description.
(bfd_elf64_canonicalize_reloc): Remove macro.
(bfd_elf64_canonicalize_dynamic_reloc): Likewise.
binutils/
* testsuite/binutils-all/mips/mips-note-2.d: New test.
* testsuite/binutils-all/mips/mips-note-2r.d: New test.
* testsuite/binutils-all/mips/mips-note-2-n32.d: New test.
* testsuite/binutils-all/mips/mips-note-2-n64.d: New test.
* testsuite/binutils-all/mips/mips-note-2r-n32.d: New test.
* testsuite/binutils-all/mips/mips-note-2r-n64.d: New test.
* testsuite/binutils-all/mips/mips.exp: Define `has_newabi'.
Run the new tests.
59 lines
1.8 KiB
Plaintext
59 lines
1.8 KiB
Plaintext
# Copyright (C) 2013-2017 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
# MA 02110-1301, USA.
|
|
|
|
if {![istarget mips*-*-*] || ![is_elf_format]} {
|
|
return
|
|
}
|
|
|
|
if [is_remote host] {
|
|
set tempfile [remote_download host tmpdir/bintest.o]
|
|
set copyfile copy
|
|
} else {
|
|
set tempfile tmpdir/bintest.o
|
|
set copyfile tmpdir/copy
|
|
}
|
|
|
|
set has_newabi [expr [istarget *-*-irix6*] \
|
|
|| [istarget mips*-*-linux*] \
|
|
|| [istarget mips*-sde-elf*] \
|
|
|| [istarget mips*-mti-elf*] \
|
|
|| [istarget mips*-img-elf*]]
|
|
|
|
run_dump_test "mips-ase-1"
|
|
run_dump_test "mips-ase-2"
|
|
run_dump_test "mips-ase-3"
|
|
run_dump_test "mixed-mips16"
|
|
run_dump_test "mixed-micromips"
|
|
run_dump_test "mixed-mips16-micromips"
|
|
run_dump_test "mips16-undecoded"
|
|
run_dump_test "mips16e2-undecoded"
|
|
run_dump_test "mips16-pcrel"
|
|
run_dump_test "mips16-extend-noinsn"
|
|
run_dump_test "mips16-extend-insn"
|
|
run_dump_test "mips16e2-extend-insn"
|
|
run_dump_test "mips16-alias"
|
|
run_dump_test "mips16-noalias"
|
|
|
|
run_dump_test "mips-note-2"
|
|
run_dump_test "mips-note-2r"
|
|
if $has_newabi {
|
|
run_dump_test "mips-note-2-n32"
|
|
run_dump_test "mips-note-2-n64"
|
|
run_dump_test "mips-note-2r-n32"
|
|
run_dump_test "mips-note-2r-n64"
|
|
}
|