forked from Imagelibrary/binutils-gdb
e7d77ce0c4
PR gdb/27743 points out a gdb crash when expanding partial symtabs, where one of the compilation units uses DW_TAG_imported_unit. The bug is that partial_map_expand_apply expects only to be called for the outermost psymtab. However, filename searching doesn't (and probably shouldn't) guarantee this. The fix is to walk upward to find the outermost CU. A new test case is included. It is mostly copied from other test cases, which really sped up the effort. This bug does not occur on trunk. There, psym_map_symtabs_matching_filename is gone, replaced by psymbol_functions::expand_symtabs_matching. When this find a match, it calls psymtab_to_symtab, which does this same upward walk. Tested on x86-64 Fedora 32. I propose checking in this patch on the gdb-10 branch, and just the new test case on trunk. gdb/ChangeLog 2021-04-23 Tom Tromey <tromey@adacore.com> PR gdb/27743: * psymtab.c (partial_map_expand_apply): Expand outermost psymtab. gdb/testsuite/ChangeLog 2021-04-23 Tom Tromey <tromey@adacore.com> PR gdb/27743: * gdb.dwarf2/imported-unit-bp.exp: New file. * gdb.dwarf2/imported-unit-bp-main.c: New file. * gdb.dwarf2/imported-unit-bp-alt.c: New file.
51 lines
1.3 KiB
C
51 lines
1.3 KiB
C
/* Copyright 2020-2021 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
/* Used to insert labels with which we can build a fake line table. */
|
|
#define LL(N) asm ("line_label_" #N ": .globl line_label_" #N)
|
|
|
|
volatile int var;
|
|
volatile int bar;
|
|
|
|
/* Generate some code to take up some space. */
|
|
#define FILLER do { \
|
|
var = 99; \
|
|
} while (0)
|
|
|
|
int
|
|
func (void)
|
|
{ /* func prologue */
|
|
asm ("func_label: .globl func_label");
|
|
LL (1); // F1, Ln 16
|
|
FILLER;
|
|
LL (2); // F1, Ln 17
|
|
FILLER;
|
|
LL (3); // F2, Ln 21
|
|
FILLER;
|
|
LL (4); // F2, Ln 22 // F1, Ln 18, !S
|
|
FILLER;
|
|
LL (5); // F1, Ln 19 !S
|
|
FILLER;
|
|
LL (6); // F1, Ln 20
|
|
FILLER;
|
|
LL (7);
|
|
FILLER;
|
|
return 0; /* func end */
|
|
}
|
|
|
|
#ifdef WITHMAIN
|
|
int main () { return 0; }
|
|
#endif
|