forked from Imagelibrary/binutils-gdb
readline turns out to be a bit of a stumbling block for the project to
move gdbsupport (and then gdbserver) to the top-level.
The issue is that readline headers are intended to be included with
names like "readline/readline.h". To support this, gdb effectively
adds a -I option pointing to the top-level source directory -- but,
importantly, this option is not used when the system readline is used.
For gdbsupport, a -I option like this would always be needed, but that
in turn would break the system readline case. This was PR build/17077,
fixed in commit a8a5dbcab8.
Previously, we had discussed this on the gdb-patches list in terms of
removing readline from the tree
https://sourceware.org/ml/gdb-patches/2019-09/msg00317.html
However, Eli expressed some concerns, and Joel did as well (off-list).
Given those concerns, and the fact that a patch-free local readline is
relatively new in gdb (it was locally patched for years), I changed my
mind and decided to handle this situation by moving the readline
sources down a level.
That is, upstream readline is now in readline/readline, and the
top-level readline directory just contains the minimal configury
needed to build that.
This fixes the problem because, when gdb unconditionally adds a
-I$(top_srcdir), this will not find readline headers. A separate -I
will be needed instead, which is exactly what's needed for
--with-system-readline.
gdb/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
* Makefile.in (READLINE_DIR): Update.
gdb/doc/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
* Makefile.in (READLINE_DIR): Update.
readline/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
Move old contents to readline/ subdirectory.
* aclocal.m4, configure, configure.ac, .gitignore, Makefile.am,
Makefile.in, README: New files.
Change-Id: Ice156a2ee09ea68722b48f64d97146d7428ea9e4
181 lines
4.7 KiB
C
181 lines
4.7 KiB
C
/* parens.c -- implementation of matching parentheses feature. */
|
|
|
|
/* Copyright (C) 1987, 1989, 1992-2015, 2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of the GNU Readline Library (Readline), a library
|
|
for reading lines of text with interactive input and history editing.
|
|
|
|
Readline is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
Readline is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with Readline. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#define READLINE_LIBRARY
|
|
|
|
#if defined (__TANDEM)
|
|
# include <floss.h>
|
|
#endif
|
|
|
|
#include "rlconf.h"
|
|
|
|
#if defined (HAVE_CONFIG_H)
|
|
# include <config.h>
|
|
#endif
|
|
|
|
#include <stdio.h>
|
|
#include <sys/types.h>
|
|
|
|
#if defined (HAVE_UNISTD_H)
|
|
# include <unistd.h>
|
|
#endif
|
|
|
|
#include "posixselect.h"
|
|
|
|
#if defined (HAVE_STRING_H)
|
|
# include <string.h>
|
|
#else /* !HAVE_STRING_H */
|
|
# include <strings.h>
|
|
#endif /* !HAVE_STRING_H */
|
|
|
|
#if !defined (strchr) && !defined (__STDC__)
|
|
extern char *strchr (), *strrchr ();
|
|
#endif /* !strchr && !__STDC__ */
|
|
|
|
#include "readline.h"
|
|
#include "rlprivate.h"
|
|
|
|
static int find_matching_open PARAMS((char *, int, int));
|
|
|
|
/* Non-zero means try to blink the matching open parenthesis when the
|
|
close parenthesis is inserted. */
|
|
int rl_blink_matching_paren = 0;
|
|
|
|
static int _paren_blink_usec = 500000;
|
|
|
|
/* Change emacs_standard_keymap to have bindings for paren matching when
|
|
ON_OR_OFF is 1, change them back to self_insert when ON_OR_OFF == 0. */
|
|
void
|
|
_rl_enable_paren_matching (int on_or_off)
|
|
{
|
|
if (on_or_off)
|
|
{
|
|
/* ([{ */
|
|
rl_bind_key_in_map (')', rl_insert_close, emacs_standard_keymap);
|
|
rl_bind_key_in_map (']', rl_insert_close, emacs_standard_keymap);
|
|
rl_bind_key_in_map ('}', rl_insert_close, emacs_standard_keymap);
|
|
|
|
#if defined (VI_MODE)
|
|
/* ([{ */
|
|
rl_bind_key_in_map (')', rl_insert_close, vi_insertion_keymap);
|
|
rl_bind_key_in_map (']', rl_insert_close, vi_insertion_keymap);
|
|
rl_bind_key_in_map ('}', rl_insert_close, vi_insertion_keymap);
|
|
#endif
|
|
}
|
|
else
|
|
{
|
|
/* ([{ */
|
|
rl_bind_key_in_map (')', rl_insert, emacs_standard_keymap);
|
|
rl_bind_key_in_map (']', rl_insert, emacs_standard_keymap);
|
|
rl_bind_key_in_map ('}', rl_insert, emacs_standard_keymap);
|
|
|
|
#if defined (VI_MODE)
|
|
/* ([{ */
|
|
rl_bind_key_in_map (')', rl_insert, vi_insertion_keymap);
|
|
rl_bind_key_in_map (']', rl_insert, vi_insertion_keymap);
|
|
rl_bind_key_in_map ('}', rl_insert, vi_insertion_keymap);
|
|
#endif
|
|
}
|
|
}
|
|
|
|
int
|
|
rl_set_paren_blink_timeout (int u)
|
|
{
|
|
int o;
|
|
|
|
o = _paren_blink_usec;
|
|
if (u > 0)
|
|
_paren_blink_usec = u;
|
|
return (o);
|
|
}
|
|
|
|
int
|
|
rl_insert_close (int count, int invoking_key)
|
|
{
|
|
if (rl_explicit_arg || !rl_blink_matching_paren)
|
|
_rl_insert_char (count, invoking_key);
|
|
else
|
|
{
|
|
#if defined (HAVE_SELECT)
|
|
int orig_point, match_point, ready;
|
|
struct timeval timer;
|
|
fd_set readfds;
|
|
|
|
_rl_insert_char (1, invoking_key);
|
|
(*rl_redisplay_function) ();
|
|
match_point =
|
|
find_matching_open (rl_line_buffer, rl_point - 2, invoking_key);
|
|
|
|
/* Emacs might message or ring the bell here, but I don't. */
|
|
if (match_point < 0)
|
|
return 1;
|
|
|
|
FD_ZERO (&readfds);
|
|
FD_SET (fileno (rl_instream), &readfds);
|
|
USEC_TO_TIMEVAL (_paren_blink_usec, timer);
|
|
|
|
orig_point = rl_point;
|
|
rl_point = match_point;
|
|
(*rl_redisplay_function) ();
|
|
ready = select (1, &readfds, (fd_set *)NULL, (fd_set *)NULL, &timer);
|
|
rl_point = orig_point;
|
|
#else /* !HAVE_SELECT */
|
|
_rl_insert_char (count, invoking_key);
|
|
#endif /* !HAVE_SELECT */
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
find_matching_open (char *string, int from, int closer)
|
|
{
|
|
register int i;
|
|
int opener, level, delimiter;
|
|
|
|
switch (closer)
|
|
{
|
|
case ']': opener = '['; break;
|
|
case '}': opener = '{'; break;
|
|
case ')': opener = '('; break;
|
|
default:
|
|
return (-1);
|
|
}
|
|
|
|
level = 1; /* The closer passed in counts as 1. */
|
|
delimiter = 0; /* Delimited state unknown. */
|
|
|
|
for (i = from; i > -1; i--)
|
|
{
|
|
if (delimiter && (string[i] == delimiter))
|
|
delimiter = 0;
|
|
else if (rl_basic_quote_characters && strchr (rl_basic_quote_characters, string[i]))
|
|
delimiter = string[i];
|
|
else if (!delimiter && (string[i] == closer))
|
|
level++;
|
|
else if (!delimiter && (string[i] == opener))
|
|
level--;
|
|
|
|
if (!level)
|
|
break;
|
|
}
|
|
return (i);
|
|
}
|