forked from Imagelibrary/binutils-gdb
ea186080fe
Bug 29965 shows on a Linux kernel >= 6.1, that test fails consistently
with:
FAIL: gdb.threads/process-exit-status-is-leader-exit-status.exp: iteration=0: continue (the program exited)
...
FAIL: gdb.threads/process-exit-status-is-leader-exit-status.exp: iteration=9: continue (the program exited)
This is due to a change in Linux kernel behavior [1] that affects
exactly what this test tests. That is, if multiple threads (including
the leader) call SYS_exit, the exit status of the process should be the
exit status of the leader. After that change in the kernel, it is no
longer the case.
Add an xfail in the test, based on the Linux kernel version. The goal
is that if a regression is introduced in GDB regarding this feature, it
should be caught if running on an older kernel where the behavior was
consistent.
[1] https://bugzilla.suse.com/show_bug.cgi?id=1206926
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29965
Change-Id: If6ab7171c92bfc1a3b961c7179e26611773969eb
Approved-By: Tom de Vries <tdevries@suse.de>
64 lines
2.0 KiB
Plaintext
64 lines
2.0 KiB
Plaintext
# Copyright (C) 2022-2023 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# GDB must always report the process's exit status based on the exit
|
|
# status of the thread group leader thread. Test that when multiple
|
|
# threads exit simultaneously, GDB doesn't confuse the non-leader
|
|
# threads' exit status for the process's exit status. GDB used to
|
|
# have a race condition that led to randomly handling this
|
|
# incorrectly.
|
|
#
|
|
# Since the improper behavior is racy in nature, this test is not
|
|
# expected to be able to reproduce the error reliably. Multiple
|
|
# executions (or increasing the number of iterations) might be
|
|
# required to reproduce the error with a misbehaving GDB.
|
|
|
|
if { ![istarget "*-*-linux*"] } {
|
|
return 0
|
|
}
|
|
|
|
standard_testfile
|
|
|
|
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}] == -1} {
|
|
return -1
|
|
}
|
|
|
|
for {set iteration 0} {$iteration < 10} {incr iteration} {
|
|
with_test_prefix "iteration=$iteration" {
|
|
if {![runto_main]} {
|
|
return
|
|
}
|
|
|
|
gdb_test_multiple "continue" "" {
|
|
-re -wrap "\\\[Inferior 1 \\(.*\\) exited with code 01\\\]" {
|
|
pass $gdb_test_name
|
|
}
|
|
|
|
-re -wrap "\\\[Inferior 1 \\(.*\\) exited with code $::decimal\\\]" {
|
|
set lkv [linux_kernel_version]
|
|
|
|
if { [llength $lkv] != 0 } {
|
|
if { [version_compare {6 1 0} <= $lkv] } {
|
|
xfail "$gdb_test_name (PR 29965)"
|
|
return
|
|
}
|
|
}
|
|
|
|
fail $gdb_test_name
|
|
}
|
|
}
|
|
}
|
|
}
|