forked from Imagelibrary/binutils-gdb
3bab069c29
get_stab_string_offset currently creates the stabstr section if not already present, in the process keeping a reference to the malloc'd section name string. Really, the name belongs in bfd_alloc'd memory or some obstack so that it doesn't show as a memory leak on exit. s_stab_generic at least does allocate the name for the stab section on an obstack, but doesn't tidy that as well as it could. Return paths after issuing a warning don't release the memory, nor the memory for the "string" copy. This patch fixes these problems. s_stab_generic is rearranged so that creation of the sections occurs earlier, before any potential uses of the note obstack during expression parsing. That makes it possible to always free the section name strings unless used to create new sections. I've also avoided get_absolute_expression_and_terminator as I see that function might skip over end-of-line, and lack of a --input_line_pointer might have caused the following source line to be ignored. (Other uses of this function in gas are OK.) * config/obj-coff.c (obj_coff_init_stab_section): Add stabstr param. Pass to get_stab_string_offset rather than name of section. * config/obj-som.c (obj_som_init_stab_section): Likewise. * config/obj-elf.c (obj_elf_init_stab_section): Likewise. (elf_init_stab_section): Adjust. * config/obj-coff.h (INIT_STAB_SECTION): Update. (obj_coff_init_stab_section): Update prototype. * config/obj-som.h: Similarly. * config/obj-elf.h: Similarly. * config/obj-multi.h (INIT_STAB_SECTION): Update. * obj.h (struct format_ops <init_stab_section>): Update. * read.h (get_stab_string_offset): Update prototype. * stabs.c (cached_sec): Delete. (stabs_begin): Adjust to suit. (get_stab_string_offset): Add stabstr param, delete stabstr_name and free_stabstr_secname params. Don't make stabstr section here. (eat_comma): New function. (s_stab_generic): Replace stab_secname_obstack_end param with bool freenames. Move creation of stab and stabstr sections earlier, so the names can be freed earlier before possible use of notes obstack during expression parsing. Tidy error paths ensuring "string" is freed. Use get_absolute_expression in place of get_absolute_expression_and_terminator. (s_stab): Adjust. (s_xstab): Use notes_concat to make stabstr section name.
70 lines
2.5 KiB
C
70 lines
2.5 KiB
C
/* SOM object file format.
|
|
Copyright (C) 1993-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of GAS, the GNU Assembler.
|
|
|
|
GAS is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3, or (at your option)
|
|
any later version.
|
|
|
|
GAS is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with GAS; see the file COPYING. If not, write to the Free
|
|
Software Foundation, 51 Franklin Street - Fifth Floor, Boston, MA
|
|
02110-1301, USA.
|
|
|
|
Written by the Center for Software Science at the University of Utah
|
|
and by Cygnus Support. */
|
|
|
|
#ifndef _OBJ_SOM_H
|
|
#define _OBJ_SOM_H
|
|
|
|
#define OBJ_SOM 1
|
|
|
|
#include "bfd/som.h"
|
|
#include "som/reloc.h"
|
|
#include "targ-cpu.h"
|
|
|
|
/* should be conditional on address size! */
|
|
#define som_symbol(asymbol) ((som_symbol_type *) (&(asymbol)->the_bfd))
|
|
|
|
extern void som_file_symbol (char *);
|
|
extern void som_frob_file (void);
|
|
extern void obj_som_version (int);
|
|
extern void obj_som_init_stab_section (segT, segT);
|
|
extern void obj_som_copyright (int);
|
|
extern void obj_som_compiler (int);
|
|
|
|
#define obj_symbol_new_hook(s) {;}
|
|
|
|
/* SOM has several attributes for spaces/subspaces which can not
|
|
be easily expressed in BFD. We use these macros to trigger calls
|
|
into the SOM BFD backend to set these attributes. */
|
|
#define obj_set_section_attributes bfd_som_set_section_attributes
|
|
#define obj_set_subsection_attributes bfd_som_set_subsection_attributes
|
|
|
|
/* Likewise for symbol types. */
|
|
#define obj_set_symbol_type bfd_som_set_symbol_type
|
|
|
|
/* Stabs go in a separate sections. GDB expects to find them in sections
|
|
with the names $GDB_SYMBOLS$ and $GDB_STRINGS$ rather than .stab and
|
|
.stabstr. */
|
|
#define SEPARATE_STAB_SECTIONS 1
|
|
#define STAB_SECTION_NAME "$GDB_SYMBOLS$"
|
|
#define STAB_STRING_SECTION_NAME "$GDB_STRINGS$"
|
|
|
|
/* We use INIT_STAB_SECTION to record the space/subspace relationships
|
|
for the various debugging sections. */
|
|
#define INIT_STAB_SECTION(stab, str) obj_som_init_stab_section (stab, str)
|
|
|
|
/* We'll be updating the magic 1st stab entry once the entire assembly
|
|
fail has been processed. */
|
|
#define obj_frob_file() som_frob_file()
|
|
|
|
#endif /* _OBJ_SOM_H */
|