forked from Imagelibrary/binutils-gdb
bcfe6157ca
The DWARF reader has had some odd code since the "physname" patches landed. In particular, these patches caused PR symtab/12707; namely, they made it so "set print demangle off" no longer works. This patch attempts to fix the problem. It arranges to store the linkage name on the symbol if it exists, and it changes the DWARF reader so that the demangled name is no longer (usually) stored in the symbol's "linkage name" field. c-linkage-name.exp needed a tweak, because it started working correctly. This conforms to what I think ought to happen, so this seems like an improvement here. compile-object-load.c needed a small change to use symbol_matches_search_name rather than directly examining the linkage name. Looking directly at the name does the wrong thing for C++. There is still some name-related confusion in the DWARF reader: * "physname" often refers to the logical name and not what I would consider to be the "physical" name; * dwarf2_full_name, dwarf2_name, and dwarf2_physname all exist and return different strings -- but this seems like at least one name too many. For example, Fortran requires dwarf2_full_name, but other languages do not. * To my surprise, dwarf2_physname prefers the form emitted by the demangler over the one that it computes. This seems backward to me, given that the partial symbol reader prefers the opposite, and it seems to me that this choice may perform better as well. I didn't attempt to clean up these things. It would be good to do, but whenever I contemplate it I get caught up in dreams of truly rewriting the DWARF reader instead. gdb/ChangeLog 2020-04-24 Tom Tromey <tom@tromey.com> PR symtab/12707: * dwarf2/read.c (add_partial_symbol): Use the linkage name if it exists. (new_symbol): Likewise. * compile/compile-object-load.c (get_out_value_type): Use symbol_matches_search_name. gdb/testsuite/ChangeLog 2020-04-24 Tom Tromey <tom@tromey.com> PR symtab/12707: * gdb.python/py-symbol.exp: Update expected results for linkage_name test. * gdb.cp/print-demangle.exp: New file. * gdb.base/c-linkage-name.exp: Fix test. * gdb.guile/scm-symbol.exp: Update expected results for linkage_name test.
75 lines
2.4 KiB
Plaintext
75 lines
2.4 KiB
Plaintext
# Copyright 2018-2020 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file is part of the gdb testsuite. It is intended to test that
|
|
# gdb can correctly print an ada symbol with linkage name before and after
|
|
# symtab expansion.
|
|
|
|
standard_testfile c-linkage-name.c c-linkage-name-2.c
|
|
|
|
set sources "${srcdir}/${subdir}/${srcfile} ${srcdir}/${subdir}/${srcfile2}"
|
|
if { [gdb_compile "${sources}" "${binfile}" executable {debug}] != "" } {
|
|
untested "failed to compile"
|
|
return -1
|
|
}
|
|
|
|
clean_restart
|
|
gdb_test_no_output "set language c"
|
|
gdb_load ${binfile}
|
|
set readnow [readnow]
|
|
|
|
set test "verify no symtab expansion"
|
|
if { $readnow } {
|
|
unsupported $test
|
|
} else {
|
|
# Verify that symtab expansion has not taken place.
|
|
|
|
gdb_test_no_output "maint info symtabs" $test
|
|
}
|
|
|
|
set test "print symada__cS before partial symtab expansion"
|
|
if { $readnow } {
|
|
unsupported $test
|
|
} else {
|
|
# Try to print MUNDANE, but using its linkage name.
|
|
|
|
gdb_test "print symada__cS" \
|
|
" = {a = 100829103}" \
|
|
"print symada__cS before partial symtab expansion"
|
|
}
|
|
|
|
# Force the symbols to be expanded for the unit that contains
|
|
# our symada__cS symbol by, e.g. inserting a breakpoint on one
|
|
# of the founction also provided by the same using.
|
|
|
|
gdb_test "break do_something_other_cu" \
|
|
"Breakpoint $decimal at $hex: file .*$srcfile2, line $decimal\\."
|
|
|
|
# Verify that partial symtab expansion has taken place for
|
|
# c-linkage-name-2.c.
|
|
|
|
gdb_test "maint info symtabs" "\{ symtab \[^\r\n\]*c-linkage-name-2.c.*"
|
|
|
|
# Flush the symbol cache to prevent the lookup to return the same as before.
|
|
|
|
gdb_test "maint flush-symbol-cache"
|
|
|
|
# Try to print MUNDANE using its linkage name again, after partial
|
|
# symtab expansion.
|
|
|
|
gdb_test "print symada__cS" \
|
|
" = {a = 100829103}" \
|
|
"print symada__cS after partial symtab expansion"
|