Files
binutils-gdb/gdb/dwarf2/tag.h
Tom Tromey 974b36c2ae Use the new symbol domains
This patch changes the DWARF reader to use the new symbol domains.  It
also adjusts many bits of associated code to adapt to this change.

The non-DWARF readers are updated on a best-effort basis.  This is
somewhat simpler since most of them only support C and C++.  I have no
way to test a few of these.

I went back and forth a few times on how to handle the "tag"
situation.  The basic problem is that C has a special namespace for
tags, which is separate from the type namespace.  Other languages
don't do this.  So, the question is, should a DW_TAG_structure_type
end up in the tag domain, or the type domain, or should it be
language-dependent?

I settled on making it language-dependent using a thought experiment.
Suppose there was a Rust compiler that only emitted nameless
DW_TAG_structure_type objects, and specified all structure type names
using DW_TAG_typedef.  This DWARF would be correct, in that it
faithfully represents the source language -- but would not work with a
purely struct-domain implementation in gdb.  Therefore gdb would be
wrong.

Now, this approach is a little tricky for C++, which uses tags but
also enters a typedef for them.  I notice that some other readers --
like stabsread -- actually emit a typedef symbol as well.  And, I
think this is a reasonable approach.  It uses more memory, but it
makes the internals simpler.  However, DWARF never did this for
whatever reason, and so in the interest of keeping the series slightly
shorter, I've left some C++-specific hacks in place here.

Note that this patch includes language_minimal as a language that uses
tags.  I did this to avoid regressing gdb.dwarf2/debug-names-tu.exp,
which doesn't specify the language for a type unit.  Arguably this
test case is wrong.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30164
2024-01-28 10:58:16 -07:00

147 lines
3.8 KiB
C

/* Tag attributes
Copyright (C) 2022-2024 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifndef GDB_DWARF2_TAG_H
#define GDB_DWARF2_TAG_H
#include "dwarf2.h"
#include "symtab.h"
/* Return true if TAG represents a type, false otherwise. */
static inline bool
tag_is_type (dwarf_tag tag)
{
switch (tag)
{
case DW_TAG_padding:
case DW_TAG_array_type:
case DW_TAG_class_type:
case DW_TAG_enumeration_type:
case DW_TAG_pointer_type:
case DW_TAG_reference_type:
case DW_TAG_string_type:
case DW_TAG_structure_type:
case DW_TAG_subroutine_type:
case DW_TAG_typedef:
case DW_TAG_union_type:
case DW_TAG_ptr_to_member_type:
case DW_TAG_set_type:
case DW_TAG_subrange_type:
case DW_TAG_base_type:
case DW_TAG_const_type:
case DW_TAG_packed_type:
case DW_TAG_template_type_param:
case DW_TAG_volatile_type:
case DW_TAG_restrict_type:
case DW_TAG_interface_type:
case DW_TAG_namespace:
case DW_TAG_unspecified_type:
case DW_TAG_shared_type:
case DW_TAG_rvalue_reference_type:
case DW_TAG_coarray_type:
case DW_TAG_dynamic_type:
case DW_TAG_atomic_type:
case DW_TAG_immutable_type:
return true;
default:
return false;
}
}
/* Return true if the given DWARF tag matches the specified search
domain flags. LANG may affect the result, due to the "C++ tag
hack". */
static inline bool
tag_matches_domain (dwarf_tag tag, domain_search_flags search, language lang)
{
domain_search_flags flags = 0;
switch (tag)
{
case DW_TAG_variable:
case DW_TAG_enumerator:
case DW_TAG_constant:
flags = SEARCH_VAR_DOMAIN;
break;
case DW_TAG_subprogram:
case DW_TAG_entry_point:
flags = SEARCH_FUNCTION_DOMAIN;
break;
case DW_TAG_structure_type:
case DW_TAG_class_type:
case DW_TAG_union_type:
case DW_TAG_enumeration_type:
{
if (lang == language_c
|| lang == language_objc
|| lang == language_opencl
|| lang == language_minimal)
flags = SEARCH_STRUCT_DOMAIN;
else if (lang == language_cplus)
flags = SEARCH_STRUCT_DOMAIN | SEARCH_TYPE_DOMAIN;
else
flags = SEARCH_TYPE_DOMAIN;
}
break;
case DW_TAG_padding:
case DW_TAG_array_type:
case DW_TAG_pointer_type:
case DW_TAG_reference_type:
case DW_TAG_string_type:
case DW_TAG_subroutine_type:
case DW_TAG_ptr_to_member_type:
case DW_TAG_set_type:
case DW_TAG_subrange_type:
case DW_TAG_base_type:
case DW_TAG_const_type:
case DW_TAG_packed_type:
case DW_TAG_template_type_param:
case DW_TAG_volatile_type:
case DW_TAG_restrict_type:
case DW_TAG_interface_type:
case DW_TAG_namespace:
case DW_TAG_unspecified_type:
case DW_TAG_shared_type:
case DW_TAG_rvalue_reference_type:
case DW_TAG_coarray_type:
case DW_TAG_dynamic_type:
case DW_TAG_atomic_type:
case DW_TAG_immutable_type:
case DW_TAG_typedef:
flags = SEARCH_TYPE_DOMAIN;
break;
case DW_TAG_label:
flags = SEARCH_LABEL_DOMAIN;
break;
case DW_TAG_module:
flags = SEARCH_MODULE_DOMAIN;
break;
}
return (flags & search) != 0;
}
#endif /* GDB_DWARF2_TAG_H */