forked from Imagelibrary/binutils-gdb
8480a37e14
We currently pass frames to function by value, as `frame_info_ptr`.
This is somewhat expensive:
- the size of `frame_info_ptr` is 64 bytes, which is a bit big to pass
by value
- the constructors and destructor link/unlink the object in the global
`frame_info_ptr::frame_list` list. This is an `intrusive_list`, so
it's not so bad: it's just assigning a few points, there's no memory
allocation as if it was `std::list`, but still it's useless to do
that over and over.
As suggested by Tom Tromey, change many function signatures to accept
`const frame_info_ptr &` instead of `frame_info_ptr`.
Some functions reassign their `frame_info_ptr` parameter, like:
void
the_func (frame_info_ptr frame)
{
for (; frame != nullptr; frame = get_prev_frame (frame))
{
...
}
}
I wondered what to do about them, do I leave them as-is or change them
(and need to introduce a separate local variable that can be
re-assigned). I opted for the later for consistency. It might not be
clear why some functions take `const frame_info_ptr &` while others take
`frame_info_ptr`. Also, if a function took a `frame_info_ptr` because
it did re-assign its parameter, I doubt that we would think to change it
to `const frame_info_ptr &` should the implementation change such that
it doesn't need to take `frame_info_ptr` anymore. It seems better to
have a simple rule and apply it everywhere.
Change-Id: I59d10addef687d157f82ccf4d54f5dde9a963fd0
Approved-By: Andrew Burgess <aburgess@redhat.com>
111 lines
3.0 KiB
C
111 lines
3.0 KiB
C
/* Target-dependent code for AMD64 Solaris.
|
||
|
||
Copyright (C) 2001-2024 Free Software Foundation, Inc.
|
||
|
||
Contributed by Joseph Myers, CodeSourcery, LLC.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "frame.h"
|
||
#include "gdbcore.h"
|
||
#include "regcache.h"
|
||
#include "osabi.h"
|
||
#include "symtab.h"
|
||
|
||
#include "sol2-tdep.h"
|
||
#include "amd64-tdep.h"
|
||
#include "gdbsupport/x86-xstate.h"
|
||
#include "solib-svr4.h"
|
||
|
||
/* Mapping between the general-purpose registers in gregset_t format
|
||
and GDB's register cache layout. */
|
||
|
||
/* From <sys/regset.h>. */
|
||
static int amd64_sol2_gregset_reg_offset[] = {
|
||
14 * 8, /* %rax */
|
||
11 * 8, /* %rbx */
|
||
13 * 8, /* %rcx */
|
||
12 * 8, /* %rdx */
|
||
9 * 8, /* %rsi */
|
||
8 * 8, /* %rdi */
|
||
10 * 8, /* %rbp */
|
||
20 * 8, /* %rsp */
|
||
7 * 8, /* %r8 ... */
|
||
6 * 8,
|
||
5 * 8,
|
||
4 * 8,
|
||
3 * 8,
|
||
2 * 8,
|
||
1 * 8,
|
||
0 * 8, /* ... %r15 */
|
||
17 * 8, /* %rip */
|
||
19 * 8, /* %eflags */
|
||
18 * 8, /* %cs */
|
||
21 * 8, /* %ss */
|
||
25 * 8, /* %ds */
|
||
24 * 8, /* %es */
|
||
22 * 8, /* %fs */
|
||
23 * 8 /* %gs */
|
||
};
|
||
|
||
|
||
/* Solaris doesn't have a 'struct sigcontext', but it does have a
|
||
'mcontext_t' that contains the saved set of machine registers. */
|
||
|
||
static CORE_ADDR
|
||
amd64_sol2_mcontext_addr (const frame_info_ptr &this_frame)
|
||
{
|
||
CORE_ADDR sp, ucontext_addr;
|
||
|
||
sp = get_frame_register_unsigned (this_frame, AMD64_RSP_REGNUM);
|
||
ucontext_addr = get_frame_memory_unsigned (this_frame, sp + 8, 8);
|
||
|
||
return ucontext_addr + 72;
|
||
}
|
||
|
||
static void
|
||
amd64_sol2_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
||
{
|
||
i386_gdbarch_tdep *tdep = gdbarch_tdep<i386_gdbarch_tdep> (gdbarch);
|
||
|
||
tdep->gregset_reg_offset = amd64_sol2_gregset_reg_offset;
|
||
tdep->gregset_num_regs = ARRAY_SIZE (amd64_sol2_gregset_reg_offset);
|
||
tdep->sizeof_gregset = 28 * 8;
|
||
|
||
amd64_init_abi (info, gdbarch,
|
||
amd64_target_description (X86_XSTATE_SSE_MASK, true));
|
||
|
||
sol2_init_abi (info, gdbarch);
|
||
|
||
tdep->sigtramp_p = sol2_sigtramp_p;
|
||
tdep->sigcontext_addr = amd64_sol2_mcontext_addr;
|
||
tdep->sc_reg_offset = tdep->gregset_reg_offset;
|
||
tdep->sc_num_regs = tdep->gregset_num_regs;
|
||
|
||
/* Solaris uses SVR4-style shared libraries. */
|
||
set_solib_svr4_fetch_link_map_offsets
|
||
(gdbarch, svr4_lp64_fetch_link_map_offsets);
|
||
}
|
||
|
||
void _initialize_amd64_sol2_tdep ();
|
||
void
|
||
_initialize_amd64_sol2_tdep ()
|
||
{
|
||
gdbarch_register_osabi (bfd_arch_i386, bfd_mach_x86_64,
|
||
GDB_OSABI_SOLARIS, amd64_sol2_init_abi);
|
||
}
|