forked from Imagelibrary/binutils-gdb
1f960ced9a
A test recently added to gdb.opt/inline-cmds.exp fails for
arm-none-eabi targets because -O2 leads to instructions to be
reordered widely.
I guess it might have made sense years ago to enable optimization in
these tests, but I fail to see the need for that nowadays.
Using -O0 while relying on __attribute__((always_inline)), which is
already used in the tests [1] [2], avoids this sort of trouble, while
still exercising the inlining-related use cases that are the focus of
these tests.
I think that nowadays we can safely assume that all compilers we care
about support __attribute__((always_inline)) or similar.
[1] - Except one spot that missed it.
[2] - Note that the .exp files make sure the frames that should have
been inlined are indeed inlined, with "info frame".
gdb/testsuite/ChangeLog:
2016-07-19 Pedro Alves <palves@redhat.com>
* gdb.opt/inline-break.exp: Remove optimize=-O2.
* gdb.opt/inline-bt.exp: Likewise.
* gdb.opt/inline-cmds.exp: Remove optimize=-O2 and add
additional_flags=-Winline.
* gdb.opt/inline-locals.exp: Likewise.
* gdb.opt/inline-markers.c (ATTR): Define.
(inlined_fn): Use it.
69 lines
2.7 KiB
Plaintext
69 lines
2.7 KiB
Plaintext
# Copyright 2008-2016 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
standard_testfile .c inline-markers.c
|
|
|
|
if {[prepare_for_testing $testfile.exp $testfile \
|
|
[list $srcfile $srcfile2] \
|
|
{debug additional_flags=-Winline}]} {
|
|
return -1
|
|
}
|
|
|
|
runto_main
|
|
|
|
get_compiler_info
|
|
get_debug_format
|
|
if { [skip_inline_frame_tests] } {
|
|
untested inline-bt.exp
|
|
return
|
|
}
|
|
|
|
set line1 [gdb_get_line_number "set breakpoint 1 here" ${srcfile2}]
|
|
gdb_breakpoint $srcfile2:$line1
|
|
|
|
gdb_test "continue" ".*set breakpoint 1 here.*" "continue to bar (1)"
|
|
gdb_test "backtrace" "#0 bar.*#1 .*main.*" "backtrace from bar (1)"
|
|
gdb_test "info frame" ".*called by frame.*" "bar not inlined"
|
|
|
|
gdb_test "continue" ".*set breakpoint 1 here.*" "continue to bar (2)"
|
|
gdb_test "backtrace" "#0 bar.*#1 .*func1.*#2 .*main.*" \
|
|
"backtrace from bar (2)"
|
|
gdb_test "up" "#1 .*func1.*" "up from bar (2)"
|
|
gdb_test "info frame" ".*inlined into frame.*" "func1 inlined (2)"
|
|
|
|
gdb_test "continue" ".*set breakpoint 1 here.*" "continue to bar (3)"
|
|
gdb_test "backtrace" "#0 bar.*#1 .*func1.*#2 .*func2.*#3 .*main.*" \
|
|
"backtrace from bar (3)"
|
|
gdb_test "up" "#1 .*func1.*" "up from bar (3)"
|
|
gdb_test "info frame" ".*inlined into frame.*" "func1 inlined (3)"
|
|
gdb_test "up" "#2 .*func2.*" "up from func1 (3)"
|
|
gdb_test "info frame" ".*inlined into frame.*" "func2 inlined (3)"
|
|
|
|
# A regression test for having a backtrace limit that forces unwinding
|
|
# to stop after an inline frame. GDB needs to compute the frame_id of
|
|
# the inline frame, which requires unwinding past all the inline
|
|
# frames to the real stack frame, even if that means bypassing the
|
|
# user visible backtrace limit. See PR backtrace/15558.
|
|
#
|
|
# Set a backtrace limit that forces an unwind stop after an inline
|
|
# function.
|
|
gdb_test_no_output "set backtrace limit 2"
|
|
# Force flushing the frame cache.
|
|
gdb_test "flushregs" "Register cache flushed."
|
|
gdb_test "up" "#1 .*func1.*" "up from bar (4)"
|
|
gdb_test "info frame" ".*in func1.*" "info frame still works"
|
|
# Verify the user visible limit works as expected.
|
|
gdb_test "up" "Initial frame selected; you cannot go up." "up hits limit"
|