forked from Imagelibrary/binutils-gdb
Changes in v3: - Adjusted some testcases where the message "failed to compile" was not unique. Changes in v2: - Addressed comments from reviewers. - Fixed spurious whitespaces. - Changed compilation failure messages that included source/binary paths to ones that are short and deterministic. --- Another bit of cleanup to the testsuite. We have a number of tests that are not honoring the rule of not outputting their own name as a test name. I fixed up all the offenders i could find with the following regular expression: "(xfail|kfail|kpass|fail|pass|unsupported|untested) ([A-Za-z0-9]+|\\\$(.)*testfile(.)*)\.exp$" gdb/testsuite/ChangeLog: 2016-12-01 Luis Machado <lgustavo@codesourcery.com> Fix test names and standardize compilation error messages throughout the following files: * gdb.ada/start.exp * gdb.arch/alpha-step.exp * gdb.arch/e500-prologue.exp * gdb.arch/ftrace-insn-reloc.exp * gdb.arch/gdb1291.exp * gdb.arch/gdb1431.exp * gdb.arch/gdb1558.exp * gdb.arch/i386-dr3-watch.exp * gdb.arch/i386-sse-stack-align.exp * gdb.arch/ia64-breakpoint-shadow.exp * gdb.arch/pa-nullify.exp * gdb.arch/powerpc-aix-prologue.exp * gdb.arch/thumb-bx-pc.exp * gdb.base/annota1.exp * gdb.base/annota3.exp * gdb.base/arrayidx.exp * gdb.base/assign.exp * gdb.base/attach.exp * gdb.base/auxv.exp * gdb.base/bang.exp * gdb.base/bfp-test.exp * gdb.base/bigcore.exp * gdb.base/bitfields2.exp * gdb.base/break-fun-addr.exp * gdb.base/break-probes.exp * gdb.base/call-rt-st.exp * gdb.base/callexit.exp * gdb.base/catch-fork-kill.exp * gdb.base/charset.exp * gdb.base/checkpoint.exp * gdb.base/comprdebug.exp * gdb.base/constvars.exp * gdb.base/coredump-filter.exp * gdb.base/cursal.exp * gdb.base/cvexpr.exp * gdb.base/detach.exp * gdb.base/display.exp * gdb.base/dmsym.exp * gdb.base/dprintf-pending.exp * gdb.base/dso2dso.exp * gdb.base/dtrace-probe.exp * gdb.base/dump.exp * gdb.base/enum_cond.exp * gdb.base/exe-lock.exp * gdb.base/exec-invalid-sysroot.exp * gdb.base/execl-update-breakpoints.exp * gdb.base/exprs.exp * gdb.base/fileio.exp * gdb.base/find.exp * gdb.base/finish.exp * gdb.base/fixsection.exp * gdb.base/foll-vfork.exp * gdb.base/frame-args.exp * gdb.base/gcore.exp * gdb.base/gdb1250.exp * gdb.base/global-var-nested-by-dso.exp * gdb.base/gnu-ifunc.exp * gdb.base/hashline1.exp * gdb.base/hashline2.exp * gdb.base/hashline3.exp * gdb.base/hbreak-in-shr-unsupported.exp * gdb.base/huge.exp * gdb.base/infcall-input.exp * gdb.base/info-fun.exp * gdb.base/info-shared.exp * gdb.base/jit-simple.exp * gdb.base/jit-so.exp * gdb.base/jit.exp * gdb.base/jump.exp * gdb.base/label.exp * gdb.base/lineinc.exp * gdb.base/logical.exp * gdb.base/longjmp.exp * gdb.base/macscp.exp * gdb.base/miscexprs.exp * gdb.base/new-ui-echo.exp * gdb.base/new-ui-pending-input.exp * gdb.base/new-ui.exp * gdb.base/nodebug.exp * gdb.base/nofield.exp * gdb.base/offsets.exp * gdb.base/overlays.exp * gdb.base/pending.exp * gdb.base/pointers.exp * gdb.base/pr11022.exp * gdb.base/printcmds.exp * gdb.base/prologue.exp * gdb.base/ptr-typedef.exp * gdb.base/realname-expand.exp * gdb.base/relativedebug.exp * gdb.base/relocate.exp * gdb.base/remote.exp * gdb.base/reread.exp * gdb.base/return2.exp * gdb.base/savedregs.exp * gdb.base/sep.exp * gdb.base/sepdebug.exp * gdb.base/sepsymtab.exp * gdb.base/set-inferior-tty.exp * gdb.base/setshow.exp * gdb.base/shlib-call.exp * gdb.base/sigaltstack.exp * gdb.base/siginfo-addr.exp * gdb.base/signals.exp * gdb.base/signull.exp * gdb.base/sigrepeat.exp * gdb.base/so-impl-ld.exp * gdb.base/solib-display.exp * gdb.base/solib-overlap.exp * gdb.base/solib-search.exp * gdb.base/solib-symbol.exp * gdb.base/structs.exp * gdb.base/structs2.exp * gdb.base/symtab-search-order.exp * gdb.base/twice.exp * gdb.base/unload.exp * gdb.base/varargs.exp * gdb.base/watchpoint-solib.exp * gdb.base/watchpoint.exp * gdb.base/whatis.exp * gdb.base/wrong_frame_bt_full.exp * gdb.btrace/dlopen.exp * gdb.cell/ea-standalone.exp * gdb.cell/ea-test.exp * gdb.cp/dispcxx.exp * gdb.cp/gdb2384.exp * gdb.cp/method2.exp * gdb.cp/nextoverthrow.exp * gdb.cp/pr10728.exp * gdb.disasm/am33.exp * gdb.disasm/h8300s.exp * gdb.disasm/mn10300.exp * gdb.disasm/sh3.exp * gdb.dwarf2/dw2-dir-file-name.exp * gdb.fortran/complex.exp * gdb.fortran/library-module.exp * gdb.guile/scm-pretty-print.exp * gdb.guile/scm-symbol.exp * gdb.guile/scm-type.exp * gdb.guile/scm-value.exp * gdb.linespec/linespec.exp * gdb.mi/gdb701.exp * gdb.mi/gdb792.exp * gdb.mi/mi-breakpoint-changed.exp * gdb.mi/mi-dprintf-pending.exp * gdb.mi/mi-dprintf.exp * gdb.mi/mi-exit-code.exp * gdb.mi/mi-pending.exp * gdb.mi/mi-solib.exp * gdb.mi/new-ui-mi-sync.exp * gdb.mi/pr11022.exp * gdb.mi/user-selected-context-sync.exp * gdb.opt/solib-intra-step.exp * gdb.python/py-events.exp * gdb.python/py-finish-breakpoint.exp * gdb.python/py-mi.exp * gdb.python/py-prettyprint.exp * gdb.python/py-shared.exp * gdb.python/py-symbol.exp * gdb.python/py-template.exp * gdb.python/py-type.exp * gdb.python/py-value.exp * gdb.reverse/solib-precsave.exp * gdb.reverse/solib-reverse.exp * gdb.server/solib-list.exp * gdb.stabs/weird.exp * gdb.threads/reconnect-signal.exp * gdb.threads/stepi-random-signal.exp * gdb.trace/actions.exp * gdb.trace/ax.exp * gdb.trace/backtrace.exp * gdb.trace/change-loc.exp * gdb.trace/deltrace.exp * gdb.trace/ftrace-lock.exp * gdb.trace/ftrace.exp * gdb.trace/infotrace.exp * gdb.trace/mi-tracepoint-changed.exp * gdb.trace/packetlen.exp * gdb.trace/passcount.exp * gdb.trace/pending.exp * gdb.trace/range-stepping.exp * gdb.trace/report.exp * gdb.trace/stap-trace.exp * gdb.trace/tfind.exp * gdb.trace/trace-break.exp * gdb.trace/trace-condition.exp * gdb.trace/trace-enable-disable.exp * gdb.trace/trace-mt.exp * gdb.trace/tracecmd.exp * gdb.trace/tspeed.exp * gdb.trace/tsv.exp * lib/perftest.exp
190 lines
5.9 KiB
Plaintext
190 lines
5.9 KiB
Plaintext
# Copyright 2013-2016 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test solib-search-path, and in the case of solib-svr4.c whether l_addr_p
|
|
# is properly reset when the path is changed.
|
|
|
|
if {[is_remote target] || [skip_shlib_tests]} {
|
|
untested solib-search.exp
|
|
return -1
|
|
}
|
|
|
|
# This is required by gdb_compile_shlib.
|
|
if {[get_compiler_info]} {
|
|
warning "Could not get compiler info"
|
|
untested solib-search.exp
|
|
return 1
|
|
}
|
|
|
|
# Build "wrong" and "right" versions of the libraries in separate directories.
|
|
set wrong_lib_subdir "solib-search-wrong"
|
|
set right_lib_subdir "solib-search-right"
|
|
|
|
# First library file.
|
|
set libname1 "solib-search-lib1"
|
|
set srcfile1_lib ${srcdir}/${subdir}/${libname1}.c
|
|
set wrong_binfile1_lib \
|
|
[standard_output_file ${wrong_lib_subdir}/${libname1}.so]
|
|
set right_binfile1_lib \
|
|
[standard_output_file ${right_lib_subdir}/${libname1}.so]
|
|
# Second library file.
|
|
set libname2 "solib-search-lib2"
|
|
set srcfile2_lib ${srcdir}/${subdir}/${libname2}.c
|
|
set wrong_binfile2_lib \
|
|
[standard_output_file ${wrong_lib_subdir}/${libname2}.so]
|
|
set right_binfile2_lib \
|
|
[standard_output_file ${right_lib_subdir}/${libname2}.so]
|
|
# Link with the library that lives here.
|
|
# This is so that we can replace what gdb sees with the wrong copy,
|
|
# and then tell gdb to use the right copy that lives someplace else.
|
|
set binfile1_lib [standard_output_file ${libname1}.so]
|
|
set binfile2_lib [standard_output_file ${libname2}.so]
|
|
|
|
set lib_flags [list debug ldflags=-Wl,-Bsymbolic]
|
|
set wrong_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=1"
|
|
set right_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=8192 -DRIGHT"
|
|
|
|
# Binary file.
|
|
standard_testfile .c
|
|
set bin_flags [list debug shlib=${binfile1_lib} shlib=${binfile2_lib}]
|
|
|
|
remote_exec build "rm -rf [standard_output_file ${wrong_lib_subdir}]"
|
|
remote_exec build "rm -rf [standard_output_file ${right_lib_subdir}]"
|
|
remote_exec build "mkdir [standard_output_file ${wrong_lib_subdir}]"
|
|
remote_exec build "mkdir [standard_output_file ${right_lib_subdir}]"
|
|
|
|
if { [gdb_compile_shlib ${srcfile1_lib} ${wrong_binfile1_lib} $wrong_lib_flags] != ""
|
|
|| [gdb_compile_shlib ${srcfile2_lib} ${wrong_binfile2_lib} $wrong_lib_flags] != ""
|
|
|| [gdb_compile_shlib ${srcfile1_lib} ${right_binfile1_lib} $right_lib_flags] != ""
|
|
|| [gdb_compile_shlib ${srcfile2_lib} ${right_binfile2_lib} $right_lib_flags] != "" } {
|
|
untested "failed to compile shared library"
|
|
return -1
|
|
}
|
|
|
|
# Build the test binary using the right copies of the libraries.
|
|
remote_exec build "ln -sf ${right_lib_subdir}/${libname1}.so ${binfile1_lib}"
|
|
remote_exec build "ln -sf ${right_lib_subdir}/${libname2}.so ${binfile2_lib}"
|
|
if { [gdb_compile $srcdir/$subdir/${srcfile} ${binfile} \
|
|
executable $bin_flags] != "" } {
|
|
untested "failed to compile"
|
|
return -1
|
|
}
|
|
|
|
clean_restart $testfile
|
|
|
|
if { ![runto_main] } {
|
|
fail "can't run to main"
|
|
return
|
|
}
|
|
|
|
gdb_breakpoint "break_here"
|
|
gdb_continue "break_here"
|
|
|
|
set corefile [standard_output_file solib-search.core]
|
|
set core_supported [gdb_gcore_cmd "$corefile" "save a corefile"]
|
|
|
|
if {!$core_supported} {
|
|
return -1
|
|
}
|
|
|
|
# Before we restart gdb, replace the libs with the "wrong" ones.
|
|
remote_exec build "ln -sf ${wrong_lib_subdir}/${libname1}.so ${binfile1_lib}"
|
|
remote_exec build "ln -sf ${wrong_lib_subdir}/${libname2}.so ${binfile2_lib}"
|
|
|
|
clean_restart $testfile
|
|
|
|
set core_loaded [gdb_core_cmd $corefile "re-load generated corefile"]
|
|
if { $core_loaded == -1 } {
|
|
# No use proceeding from here.
|
|
return
|
|
}
|
|
|
|
proc test_backtrace { expect_fail } {
|
|
global gdb_prompt
|
|
|
|
set count 0
|
|
set total_expected 5
|
|
|
|
if { $expect_fail } {
|
|
set testname "backtrace (with wrong libs)"
|
|
} else {
|
|
set testname "backtrace (with right libs)"
|
|
}
|
|
# N.B. The order of the tests here is important.
|
|
# We need to count each function in the backtrace, and expect matches
|
|
# the first one it finds.
|
|
gdb_test_multiple "backtrace" $testname {
|
|
-re "\[^\r\n\]* in lib2_func4 \[^\r\n\]*" {
|
|
incr count
|
|
exp_continue
|
|
}
|
|
-re "\[^\r\n\]* in lib1_func3 \[^\r\n\]*" {
|
|
incr count
|
|
exp_continue
|
|
}
|
|
-re "\[^\r\n\]* in lib2_func2 \[^\r\n\]*" {
|
|
incr count
|
|
exp_continue
|
|
}
|
|
-re "\[^\r\n\]* in lib1_func1 \[^\r\n\]*" {
|
|
incr count
|
|
exp_continue
|
|
}
|
|
-re "\[^\r\n\]* in main \[^\r\n\]*" {
|
|
incr count
|
|
exp_continue
|
|
}
|
|
-re "\[\r\n\]$gdb_prompt $" {
|
|
pass "$testname (data collection)"
|
|
}
|
|
}
|
|
|
|
set fail 0
|
|
if { $expect_fail } {
|
|
# If the backtrace output is correct the test isn't sufficiently
|
|
# testing what it should.
|
|
if { $count == $total_expected } {
|
|
set fail 1
|
|
}
|
|
} else {
|
|
if { $count != $total_expected } {
|
|
set fail 1
|
|
}
|
|
}
|
|
if { $fail } {
|
|
fail $testname
|
|
} else {
|
|
pass $testname
|
|
}
|
|
}
|
|
|
|
# Verify the backtrace is messed up.
|
|
test_backtrace 1
|
|
|
|
# Remove the copies gdb currently sees: the absolute path is encoded in
|
|
# the core file and we want gdb to find the right copies elsewhere.
|
|
remote_exec build "rm -f ${binfile1_lib}"
|
|
remote_exec build "rm -f ${binfile2_lib}"
|
|
# Set solib-search-path to use the correct copies of libraries.
|
|
gdb_test "set solib-search-path [standard_output_file ${right_lib_subdir}]" \
|
|
"" \
|
|
"set solib-search-path"
|
|
|
|
# Verify gdb has properly updated the location of the libraries.
|
|
test_backtrace 0
|
|
gdb_test "p lib1_size" " = 8192"
|
|
gdb_test "p lib2_size" " = 8192"
|
|
|