forked from Imagelibrary/binutils-gdb
7492eb9f54
I noticed that the gdb.base/clear_non_user_bp.exp test would sometimes
fail when run from a particular directory.
The test tries to find the number of the first internal breakpoint
using this proc:
proc get_first_maint_bp_num { } {
gdb_test_multiple "maint info break" "find first internal bp num" {
-re -wrap "(-\[0-9\]).*" {
return $expect_out(1,string)
}
}
return ""
}
The problem is, at the time we issue 'maint info break' there are both
internal breakpoint and non-internal (user created) breakpoints in
place. The user created breakpoints include the path to the source
file.
Sometimes, I'll be working from a directory that includes a number,
like '/tmp/blah-1/gdb/etc', in which case the pattern above actually
matches the '-1' from 'blah-1'. In this case there's no significant
problem as it turns out that -1 is the number of the first internal
breakpoint.
Sometimes my directory name might be '/tmp/blah-4/gdb/etc', in which
case the above pattern patches '-4' from 'blah-4'. It turns out this
is also not a problem -- the test doesn't actually need the first
internal breakpoint number, it just needs the number of any internal
breakpoint.
But sometimes my directory name might be '/tmp/blah-0/gdb/etc', in
which case the pattern above matches '-0' from 'blah-0', and in this
case the test fails - there is no internal breakpoint '-0'.
Fix this by spotting that the internal breakpoint numbers always
occurs after a '\r\n', and that they never start with a 0. Our
pattern becomes:
-re -wrap "\r\n(-\[1-9\]\[0-9\]*).*" {
return $expect_out(1,string)
}
After this I'm no longer seeing any failures.
Reviewed-By: Tom Tromey <tom@tromey.com>
72 lines
2.0 KiB
Plaintext
72 lines
2.0 KiB
Plaintext
# Copyright 2022-2023 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Regression test for PR gdb/7161. Test that GDB cannot delete non-user
|
|
# breakpoints with clear command.
|
|
|
|
# get_first_maint_bp_num
|
|
#
|
|
# Purpose:
|
|
# Get the first number of all internal breakpoints when using command
|
|
# "maint info breakpoints".
|
|
#
|
|
# Parameter:
|
|
# None.
|
|
#
|
|
# Return:
|
|
# Internal breakpoint number, which is negative.
|
|
#
|
|
proc get_first_maint_bp_num { } {
|
|
gdb_test_multiple "maint info break" "find first internal bp num" {
|
|
-re -wrap "\r\n(-\[1-9\]\[0-9\]*).*" {
|
|
return $expect_out(1,string)
|
|
}
|
|
}
|
|
return ""
|
|
}
|
|
|
|
standard_testfile .c
|
|
|
|
# This testcase just needs a "Hello world" source file, reuse
|
|
# gdb.base/main.c instead of adding a new one.
|
|
if { [gdb_compile "${srcdir}/${subdir}/main.c" "${binfile}" executable {debug}] != "" } {
|
|
untested "failed to compile"
|
|
return -1
|
|
}
|
|
|
|
# Start with a fresh gdb.
|
|
clean_restart ${binfile}
|
|
|
|
if {![runto_main]} {
|
|
return 0
|
|
}
|
|
|
|
set bp_num [get_first_maint_bp_num]
|
|
set bp_addr [gdb_get_bp_addr $bp_num]
|
|
|
|
gdb_test "maint info break $bp_num" \
|
|
"$bp_num.*$bp_addr.*" \
|
|
"maint info breakpoint \$bp_num"
|
|
|
|
gdb_test "clear *$bp_addr" \
|
|
"No breakpoint at \\*$bp_addr." \
|
|
"clear internal breakpoint"
|
|
|
|
# Check again, make sure that GDB really didn't delete the internal breakpoint.
|
|
gdb_test "maint info break $bp_num" \
|
|
"$bp_num.*$bp_addr.*" \
|
|
"maint info breakpoint \$bp_num after clear"
|
|
|