Files
binutils-gdb/gdb/dwarf2/cu.c
Tom de Vries 1d45d90934 [gdb/symtab] Work around PR gas/29517
When using glibc debuginfo generated with gas 2.39, we run into PR gas/29517:
...
$ gdb -q -batch a.out -ex start -ex "p (char *)strstr (\"haha\", \"ah\")"
Temporary breakpoint 1 at 0x40051b: file hello.c, line 6.

Temporary breakpoint 1, main () at hello.c:6
6	  printf ("hello\n");
Invalid cast.
...
while without glibc debuginfo installed we get the expected result:
...
$n = 0x7ffff7daa1b1 "aha"
...
and likewise with glibc debuginfo generated with gas 2.40.

The strstr ifunc resolves to __strstr_sse2_unaligned.  The problem is that gas
generates dwarf that states that the return type is void:
...
<1><3e1e58>: Abbrev Number: 2 (DW_TAG_subprogram)
    <3e1e59>   DW_AT_name        : __strstr_sse2_unaligned
    <3e1e5d>   DW_AT_external    : 1
    <3e1e5e>   DW_AT_low_pc      : 0xbbd2e
    <3e1e66>   DW_AT_high_pc     : 0xbc1c3
...
while the return type should be a DW_TAG_unspecified_type, as is the case
with gas 2.40.

We can still use the workaround of casting to another function type for both
__strstr_sse2_unaligned:
...
(gdb) p ((char * (*) (const char *, const char *))__strstr_sse2_unaligned) \
  ("haha", "ah")
$n = 0x7ffff7daa211 "aha"
...
and strstr (which requires using *strstr to dereference the ifunc before we
cast):
...
gdb) p ((char * (*) (const char *, const char *))*strstr) ("haha", "ah")
$n = 0x7ffff7daa251 "aha"
...
but that's a bit cumbersome to use.

Work around this in the dwarf reader, such that we have instead:
...
(gdb) p (char *)strstr ("haha", "ah")
$n = 0x7ffff7daa1b1 "aha"
...

This also requires fixing producer_is_gcc to stop returning true for
producer "GNU AS 2.39.0".

Tested on x86_64-linux.

Approved-By: Andrew Burgess <aburgess@redhat.com>

PR symtab/30911
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30911
2023-10-16 16:32:28 +02:00

186 lines
5.2 KiB
C

/* DWARF CU data structure
Copyright (C) 2021-2023 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "dwarf2/cu.h"
#include "dwarf2/read.h"
#include "objfiles.h"
#include "filenames.h"
#include "gdbsupport/pathstuff.h"
/* Initialize dwarf2_cu to read PER_CU, in the context of PER_OBJFILE. */
dwarf2_cu::dwarf2_cu (dwarf2_per_cu_data *per_cu,
dwarf2_per_objfile *per_objfile)
: per_cu (per_cu),
per_objfile (per_objfile),
m_mark (false),
has_loclist (false),
checked_producer (false),
producer_is_gxx_lt_4_6 (false),
producer_is_gcc_lt_4_3 (false),
producer_is_gcc_11 (false),
producer_is_icc (false),
producer_is_icc_lt_14 (false),
producer_is_codewarrior (false),
producer_is_clang (false),
producer_is_gas_2_39 (false),
processing_has_namespace_info (false),
load_all_dies (false)
{
}
/* See cu.h. */
struct type *
dwarf2_cu::addr_sized_int_type (bool unsigned_p) const
{
int addr_size = this->per_cu->addr_size ();
return objfile_int_type (this->per_objfile->objfile, addr_size, unsigned_p);
}
/* Start a symtab for DWARF. NAME, COMP_DIR, LOW_PC are passed to the
buildsym_compunit constructor. */
struct compunit_symtab *
dwarf2_cu::start_compunit_symtab (const char *name, const char *comp_dir,
CORE_ADDR low_pc)
{
gdb_assert (m_builder == nullptr);
std::string name_for_id_holder;
const char *name_for_id = name;
/* Prepend the compilation directory to the filename if needed (if not
absolute already) to get the "name for id" for our main symtab. The name
for the main file coming from the line table header will be generated using
the same logic, so will hopefully match what we pass here. */
if (!IS_ABSOLUTE_PATH (name) && comp_dir != nullptr)
{
name_for_id_holder = path_join (comp_dir, name);
name_for_id = name_for_id_holder.c_str ();
}
m_builder.reset (new struct buildsym_compunit
(this->per_objfile->objfile,
name, comp_dir, name_for_id, lang (), low_pc));
list_in_scope = get_builder ()->get_file_symbols ();
/* DWARF versions are restricted to [2, 5], thanks to the check in
read_comp_unit_head. */
gdb_assert (this->header.version >= 2 && this->header.version <= 5);
static const char *debugformat_strings[] = {
"DWARF 2",
"DWARF 3",
"DWARF 4",
"DWARF 5",
};
const char *debugformat = debugformat_strings[this->header.version - 2];
get_builder ()->record_debugformat (debugformat);
get_builder ()->record_producer (producer);
processing_has_namespace_info = false;
return get_builder ()->get_compunit_symtab ();
}
/* See read.h. */
struct type *
dwarf2_cu::addr_type () const
{
struct objfile *objfile = this->per_objfile->objfile;
struct type *void_type = builtin_type (objfile)->builtin_void;
struct type *addr_type = lookup_pointer_type (void_type);
int addr_size = this->per_cu->addr_size ();
if (addr_type->length () == addr_size)
return addr_type;
addr_type = addr_sized_int_type (addr_type->is_unsigned ());
return addr_type;
}
/* A hashtab traversal function that marks the dependent CUs. */
static int
dwarf2_mark_helper (void **slot, void *data)
{
dwarf2_per_cu_data *per_cu = (dwarf2_per_cu_data *) *slot;
dwarf2_per_objfile *per_objfile = (dwarf2_per_objfile *) data;
dwarf2_cu *cu = per_objfile->get_cu (per_cu);
/* cu->m_dependencies references may not yet have been ever read if
QUIT aborts reading of the chain. As such dependencies remain
valid it is not much useful to track and undo them during QUIT
cleanups. */
if (cu != nullptr)
cu->mark ();
return 1;
}
/* See dwarf2/cu.h. */
void
dwarf2_cu::mark ()
{
if (!m_mark)
{
m_mark = true;
if (m_dependencies != nullptr)
htab_traverse (m_dependencies, dwarf2_mark_helper, per_objfile);
}
}
/* See dwarf2/cu.h. */
void
dwarf2_cu::add_dependence (struct dwarf2_per_cu_data *ref_per_cu)
{
void **slot;
if (m_dependencies == nullptr)
m_dependencies
= htab_create_alloc_ex (5, htab_hash_pointer, htab_eq_pointer,
NULL, &comp_unit_obstack,
hashtab_obstack_allocate,
dummy_obstack_deallocate);
slot = htab_find_slot (m_dependencies, ref_per_cu, INSERT);
if (*slot == nullptr)
*slot = ref_per_cu;
}
/* See dwarf2/cu.h. */
buildsym_compunit *
dwarf2_cu::get_builder ()
{
/* If this CU has a builder associated with it, use that. */
if (m_builder != nullptr)
return m_builder.get ();
if (per_objfile->sym_cu != nullptr)
return per_objfile->sym_cu->m_builder.get ();
gdb_assert_not_reached ("");
}