Files
binutils-gdb/gdb/testsuite/gdb.server/server-kill-python.exp
Tom de Vries ed32754a8c [gdb/testsuite] Fix gdb.server/multi-ui-errors.exp for remote target
Test-case gdb.server/multi-ui-errors.exp fails for target board
remote-gdbserver-on-localhost with REMOTE_TARGET_USERNAME=remote-target:
...
(gdb) PASS: gdb.server/multi-ui-errors.exp: interact with GDB's main UI
Executing on target: kill -9 6447    (timeout = 300)
builtin_spawn [open ...]^M
XYZ1ZYX
sh: line 0: kill: (6447) - Operation not permitted
...

The problem is that the kill command:
...
remote_exec target "kill -9 $gdbserver_pid"
...
intended to kill gdbserver instead tries to kill the ssh client session in
which the gdbserver runs, and fails because it's trying as the remote target
user (remote-target on localhost) to kill a pid owned by the the build user
($USER on localhost).

Fix this by getting the gdbserver pid using the ppid trick from
server-kill.exp.

Likewise in gdb.server/server-kill-python.exp.

Tested on x86_64-linux.
2023-03-09 10:45:03 +01:00

108 lines
2.9 KiB
Plaintext

# This testcase is part of GDB, the GNU debugger.
#
# Copyright 2019-2023 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# This test script exposes a bug where, if gdbserver dies while GDB is
# sourcing a python command like 'gdb.execute ("continue")', then GDB
# will deadlock.
load_lib gdbserver-support.exp
standard_testfile multi-ui-errors.c
require allow_gdbserver_tests allow_python_tests
if {[build_executable "failed to prepare" ${testfile} \
${srcfile}] == -1} {
return -1
}
set target_binfile [gdb_remote_download target $binfile]
# Start gdbserver.
set res [gdbserver_spawn "${target_binfile}"]
set gdbserver_protocol [lindex $res 0]
set gdbserver_gdbport [lindex $res 1]
set gdbserver_pid [exp_pid -i $server_spawn_id]
set break_linenr [gdb_get_line_number "@@XX@@ Inferior Starting @@XX@@"]
# Generate a python script we will later source.
set file1 [standard_output_file file1.py]
set fd [open "$file1" w]
puts $fd \
"import gdb
def do_gdb_stuff ():
gdb.execute ('target $gdbserver_protocol $gdbserver_gdbport')
gdb.execute ('break $srcfile:$break_linenr')
gdb.execute ('continue')
gdb.execute ('p server_pid')
gdb.execute ('continue')
do_gdb_stuff()"
close $fd
# Now start GDB, sourcing the python command file we generated above.
# Set the height and width so we don't end up at a paging prompt.
if {[gdb_spawn_with_cmdline_opts \
"-quiet -iex \"set height 0\" -iex \"set width 0\" -ex \"source $file1\""] != 0} {
fail "spawn"
return
}
# Get the gdbserver PID.
set gdbserver_pid 0
# Wait for the inferior to start up.
with_spawn_id $server_spawn_id {
gdb_test_multiple "" "get gdbserver PID" {
-re " = ($decimal)\r\n" {
set gdbserver_pid $expect_out(1,string)
pass $gdb_test_name
}
}
if { $gdbserver_pid == 0 } {
return
}
gdb_test_multiple "" "ensure inferior is running" {
-re "@@XX@@ Inferior Starting @@XX@@" {
pass $gdb_test_name
}
timeout {
fail $gdb_test_name
}
}
}
# Now kill the gdbserver.
remote_exec target "kill -9 $gdbserver_pid"
# Wait for GDB to return to a prompt.
gdb_test_multiple "" "landed at prompt after gdbserver dies" {
-re "$gdb_prompt $" {
pass $gdb_test_name
}
timeout {
fail "$gdb_test_name (timeout)"
}
}
# Run a simple command to ensure we can interact with GDB.
gdb_test "echo hello\\n" "hello" "can we interact with gdb"