forked from Imagelibrary/binutils-gdb
75d277b1f5
The commit ed32754a8c ("[gdb/testsuite] Fix gdb.server/multi-ui-errors.exp for
remote target") intended to addresss the problem that this command:
...
set gdbserver_pid [exp_pid -i $server_spawn_id]
...
does not return the pid of the gdbserver for remote target, but rather the one
of the ssh client session.
To fix this, it added another way of getting the gdbserver_pid.
For the trivial case of non-remote target, the PID found by either method
should be identical, but if we compare those by adding
"puts [exec ps -p $gdbserver_pid]" we get:
...
PID TTY TIME CMD
31711 pts/8 00:00:00 gdbserver
PID TTY TIME CMD
31718 pts/8 00:00:00 server-kill-pyt
...
The problem is that while the gdbserver PID is supposed to be read from the
result of "gdb.execute ('p server_pid')" in the python script, instead it's
taken from:
...
Process server-kill-python created; pid = 31718^M
...
Fix this by moving the printing of the gdbserver PID out of the python script.
Also double-check the two methods against each other, in the cases that they
should match.
Tested on x86_64-linux.
PR testsuite/31633
https://sourceware.org/bugzilla/show_bug.cgi?id=31633
119 lines
3.1 KiB
Plaintext
119 lines
3.1 KiB
Plaintext
# This testcase is part of GDB, the GNU debugger.
|
|
#
|
|
# Copyright 2019-2024 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This test script exposes a bug where, if gdbserver dies while GDB is
|
|
# sourcing a python command like 'gdb.execute ("continue")', then GDB
|
|
# will deadlock.
|
|
|
|
load_lib gdbserver-support.exp
|
|
|
|
standard_testfile multi-ui-errors.c
|
|
|
|
require allow_gdbserver_tests allow_python_tests
|
|
|
|
if {[build_executable "failed to prepare" ${testfile} \
|
|
${srcfile}] == -1} {
|
|
return -1
|
|
}
|
|
|
|
set target_binfile [gdb_remote_download target $binfile]
|
|
set host_binfile [gdb_remote_download host $binfile]
|
|
|
|
# Start gdbserver.
|
|
set res [gdbserver_spawn "${target_binfile}"]
|
|
set gdbserver_protocol [lindex $res 0]
|
|
set gdbserver_gdbport [lindex $res 1]
|
|
set gdbserver_pid_check [exp_pid -i $server_spawn_id]
|
|
|
|
set break_linenr [gdb_get_line_number "@@XX@@ Inferior Starting @@XX@@"]
|
|
|
|
# Generate a python script we will later source.
|
|
set file1 [standard_output_file file1.py]
|
|
set fd [open "$file1" w]
|
|
puts $fd \
|
|
"import gdb
|
|
|
|
def do_gdb_stuff ():
|
|
gdb.execute ('continue')
|
|
|
|
do_gdb_stuff()"
|
|
close $fd
|
|
|
|
set host_file1 [gdb_remote_download host $file1]
|
|
|
|
# Now start GDB, sourcing the python command file we generated above.
|
|
# Set the height and width so we don't end up at a paging prompt.
|
|
if {[gdb_spawn_with_cmdline_opts \
|
|
"-quiet -iex \"set height 0\" -iex \"set width 0\""] != 0} {
|
|
fail "spawn"
|
|
return
|
|
}
|
|
|
|
gdb_load $binfile
|
|
gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
|
|
|
|
gdb_test "break $srcfile:$break_linenr"
|
|
|
|
# Get the gdbserver PID.
|
|
set gdbserver_pid 0
|
|
gdb_test "continue"
|
|
gdb_test_multiple "print server_pid" "get gdbserver PID" {
|
|
-re -wrap " = ($decimal)" {
|
|
set gdbserver_pid $expect_out(1,string)
|
|
pass $gdb_test_name
|
|
}
|
|
}
|
|
|
|
if { $gdbserver_pid == 0 } {
|
|
return
|
|
}
|
|
|
|
if { ![is_remote target] && $gdbserver_pid != $gdbserver_pid_check } {
|
|
error "Failed to get correct gdbserver pid"
|
|
}
|
|
|
|
send_gdb "source $host_file1\n"
|
|
|
|
|
|
# Wait for the inferior to start up.
|
|
with_spawn_id $server_spawn_id {
|
|
gdb_test_multiple "" "ensure inferior is running" {
|
|
-re "@@XX@@ Inferior Starting @@XX@@" {
|
|
pass $gdb_test_name
|
|
}
|
|
timeout {
|
|
fail $gdb_test_name
|
|
}
|
|
}
|
|
}
|
|
|
|
# Now kill the gdbserver.
|
|
remote_exec target "kill -9 $gdbserver_pid"
|
|
|
|
# Wait for GDB to return to a prompt.
|
|
gdb_test_multiple "" "landed at prompt after gdbserver dies" {
|
|
-re "$gdb_prompt $" {
|
|
pass $gdb_test_name
|
|
}
|
|
timeout {
|
|
fail "$gdb_test_name (timeout)"
|
|
}
|
|
}
|
|
|
|
# Run a simple command to ensure we can interact with GDB.
|
|
gdb_test "echo hello\\n" "hello" "can we interact with gdb"
|