Files
binutils-gdb/gdb/testsuite/gdb.python/py-color-leak.py
Andrew Burgess 5d4187339f gdb/python: fix memory leak of gdb.Color objects
I noticed that this commit:

  commit 6447969d0a
  Date:   Sat Oct 5 22:27:44 2024 +0300

      Add an option with a color type.

has an unnecessary `Py_INCREF (self);` in gdb.Color.__init__.  This
means that the reference count on all gdb.Color objects (that pass
through __init__) will be +1 from where they should normally be, and
this will stop the gdb.Color objects from being deallocated.

Fix by removing the Py_INCREF call.

Add a test which exposes the memory leak.

Approved-By: Tom Tromey <tom@tromey.com>
2025-04-22 17:21:59 +01:00

32 lines
1010 B
Python

# Copyright (C) 2025 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
import gdb_leak_detector
class color_leak_detector(gdb_leak_detector.gdb_leak_detector):
def __init__(self):
super().__init__(__file__)
self.color = None
def allocate(self):
self.color = gdb.Color("red")
def deallocate(self):
self.color = None
color_leak_detector().run()