Files
binutils-gdb/gdb/testsuite/gdb.server/server-kill.exp
Christina Schimpe ff52c0736a gdb: Make global feature array a per-remote target array
This patch applies the appropriate FIXME notes described in commit 5b6d1e4
"Multi-target support".

"You'll notice that remote.c includes some FIXME notes.  These refer to
the fact that the global arrays that hold data for the remote packets
supported are still globals.  For example, if we connect to two
different servers/stubs, then each might support different remote
protocol features.  They might even be different architectures, like
e.g., one ARM baremetal stub, and a x86 gdbserver, to debug a
host/controller scenario as a single program.  That isn't going to
work correctly today, because of said globals.  I'm leaving fixing
that for another pass, since it does not appear to be trivial, and I'd
rather land the base work first.  It's already useful to be able to
debug multiple instances of the same server (e.g., a distributed
cluster, where you have full control over the servers installed), so I
think as is it's already reasonable incremental progress."

Using this patch it is possible to configure per-remote targets'
feature packets.

Given the following setup for two gdbservers:

~~~~
gdbserver --multi :1234
gdbserver --disable-packet=vCont --multi :2345
~~~~

Before this patch configuring of range-stepping was not possible for one
of two connected remote targets with different support for the vCont
packet.  As one of the targets supports vCont, it should be possible to
configure "set range-stepping".  However, the output of GDB looks like:

(gdb) target extended-remote :1234
Remote debugging using :1234
(gdb) add-inferior -no-connection
[New inferior 2]
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) target extended-remote :2345
Remote debugging using :2345
(gdb) set range-stepping on
warning: Range stepping is not supported by the current target
(gdb) inferior 1
[Switching to inferior 1 [<null>] (<noexec>)]
(gdb) set range-stepping on
warning: Range stepping is not supported by the current target
~~~~

Two warnings are shown.  The warning for inferior 1 should not appear
as it is connected to a target supporting the vCont package.

~~~~
(gdb) target extended-remote :1234
Remote debugging using :1234
(gdb) add-inferior -no-connection
[New inferior 2]
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) target extended-remote :2345
Remote debugging using :2345
(gdb) set range-stepping on
warning: Range stepping is not supported by the current target
(gdb) inferior 1
[Switching to inferior 1 [<null>] (<noexec>)]
(gdb) set range-stepping on
(gdb)
~~~~

Now only one warning is shown for inferior 2, which is connected to
a target not supporting vCont.

The per-remote target feature array is realized by a new class
remote_features, which stores the per-remote target array and
provides functions to determine supported features of the target.
A remote_target object now has a new member of that class.

Each time a new remote_target object is initialized, a new per-remote
target array is constructed based on the global remote_protocol_packets
array.  The global array is initialized in the function _initialize_remote
and can be configured using the command line.  Before this patch the
command line configuration affected current targets and future remote
targets (due to the global feature array used by all remote
targets).  This behavior is different and the configuration applies as
follows:

 - If a target is connected, the command line configuration affects the
   current connection.  All other existing remote targets are not
   affected.

 - If not connected, the command line configuration affects future
   connections.

The show command displays the current remote target's configuration.  If no
remote target is selected the default configuration for future
connections is shown.

If we have for instance the following setup with inferior 2 being
selected:
~~~~
(gdb) info inferiors
  Num  Description       Connection                Executable
  1    <null>             1 (extended-remote :1234)
* 2    <null>             2 (extended-remote :2345)
~~~~

Before this patch, if we run 'set remote multiprocess-feature-packet', the
following configuration was set:
The feature array of all remote targets (in this setup the two connected
targets) and all future remote connections are affected.

After this patch, it will be configured as follows:
The feature array of target with port :2345 which is currently selected
will be configured.  All other existing remote targets are not affected.
The show command 'show remote multiprocess-feature-packet' will display
the configuration of target with port :2345.

Due to this configuration change, it is required to adapt the test
"gdb/testsuite/gdb.multi/multi-target-info-inferiors.exp" to configure the
multiprocess-feature-packet before the connections are created.

To inform the gdb user about the new behaviour of the 'show remote
PACKET-NAME' commands and the new configuration impact for remote
targets using the 'set remote PACKET-NAME' commands the commands'
outputs are adapted.  Due to this change it is required to adapt each
test using the set/show remote 'PACKET-NAME' commands.
2023-01-30 12:45:31 +01:00

177 lines
4.8 KiB
Plaintext

# This testcase is part of GDB, the GNU debugger.
#
# Copyright 2013-2023 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Check that GDB handles GDBserver disconnecting abruptly, in several
# scenarios.
load_lib gdbserver-support.exp
standard_testfile
require allow_gdbserver_tests
if { [build_executable "failed to prepare" ${testfile}] } {
return -1
}
# Global control variable used by the proc prepare. Should be set to
# either 'inferior' or 'server'.
#
# In the proc prepare we start gdbserver and extract a pid, which will
# later be killed by calling the proc kill_server.
#
# When KILL_PID_OF is set to 'inferior' then the pid we kill is that
# of the inferior running under gdbserver, when this process dies
# gdbserver itself will exit.
#
# When KILL_PID_OF is set to 'server' then the pid we kill is that of
# the gdbserver itself, this is a much more aggressive strategy and
# exposes different bugs within GDB.
set kill_pid_of "inferior"
# Spawn GDBserver, run to main, extract GDBserver's PID and save it in
# the SERVER_PID global.
proc prepare {} {
global binfile gdb_prompt srcfile decimal
global server_pid
global GDBFLAGS
save_vars { GDBFLAGS } {
# If GDB and GDBserver are both running locally, set the sysroot to avoid
# reading files via the remote protocol.
if { ![is_remote host] && ![is_remote target] } {
set GDBFLAGS "$GDBFLAGS -ex \"set sysroot\""
}
clean_restart $binfile
}
# Make sure we're disconnected, in case we're testing with an
# extended-remote board, therefore already connected.
gdb_test "disconnect" ".*"
gdbserver_run ""
# Continue past server_pid assignment. We do this for both scenarios,
# to avoid doing a backtrace from _start, which may not trigger remote
# communication.
gdb_breakpoint ${srcfile}:[gdb_get_line_number "i = 0;"]
gdb_continue_to_breakpoint "after server_pid assignment"
if { $::kill_pid_of == "inferior" } {
# Get the pid of GDBServer.
set test "p server_pid"
set server_pid 0
gdb_test_multiple $test $test {
-re " = ($decimal)\r\n$gdb_prompt $" {
set server_pid $expect_out(1,string)
pass $test
}
}
} else {
set server_pid [exp_pid -i $::server_spawn_id]
}
if {$server_pid == 0} {
return 0
}
return 1
}
# Kill GDBserver using the PID saved by prepare.
proc kill_server {} {
global server_pid
remote_exec target "kill -9 $server_pid"
}
# Test issuing "tstatus" right after the connection is dropped.
proc_with_prefix test_tstatus {} {
if ![prepare] {
return
}
kill_server
# Enable trace status packet which is disabled after the
# connection if the remote target doesn't support tracepoint at
# all. Otherwise, no RSP packet is sent out.
gdb_test \
"set remote trace-status-packet on" \
"Support for the 'qTStatus' packet on the current remote target is set to \"on\"."
# Force GDB to talk with GDBserver, so that we can get the
# "connection closed" error.
gdb_test "tstatus" {Remote connection closed|Remote communication error\. Target disconnected\.: Connection reset by peer\.}
}
# Test unwinding with no debug/unwind info, right after the connection
# is dropped.
proc_with_prefix test_unwind_nosyms {} {
if ![prepare] {
return
}
# Remove symbols, so that we try to unwind with one of the
# heuristic unwinders, and read memory from within its sniffer.
gdb_unload
kill_server
gdb_test "bt" "(Target disconnected|Remote connection closed|Remote communication error).*"
}
# Test unwinding with debug/unwind info, right after the connection is
# dropped.
proc_with_prefix test_unwind_syms {} {
if ![prepare] {
return
}
kill_server
gdb_test "bt" "(Target disconnected|Remote connection closed|Remote communication error).*"
}
# Test performing a stepi right after the connection is dropped.
proc_with_prefix test_stepi {} {
if ![prepare] {
return
}
kill_server
gdb_test "stepi" "(Target disconnected|Remote connection closed|Remote communication error).*"
}
# Run each test twice, see the description of KILL_PID_OF earlier in
# this file for more details.
foreach_with_prefix kill_pid_of { "inferior" "server" } {
test_tstatus
test_unwind_nosyms
test_unwind_syms
test_stepi
}