forked from Imagelibrary/binutils-gdb
55144e8727
If scheduler-locking is in effect, like e.g., with "set scheduler-locking on", and you step over a function that spawns a new thread, the new thread is allowed to run free, at least until some event is hit, at which point, whether the new thread is re-resumed depends on a number of seemingly random factors. E.g., if the target is all-stop, and the parent thread hits a breakpoint, and gdb decides the breakpoint isn't interesting to report to the user, then the parent thread is resumed, but the new thread is left stopped. I think that letting the new threads run with scheduler-locking enabled is a defect. This commit fixes that, making use of the new clone events on Linux, and of target_thread_events() on targets where new threads have no connection to the thread that spawned them. Testcase and documentation changes included. Approved-By: Eli Zaretskii <eliz@gnu.org> Change-Id: Ie12140138b37534b7fc1d904da34f0f174aa11ce
68 lines
1.9 KiB
Plaintext
68 lines
1.9 KiB
Plaintext
# Copyright 2021-2022 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test continuing over a thread spawn with scheduler-locking on.
|
|
|
|
standard_testfile .c
|
|
|
|
foreach_with_prefix schedlock {off on} {
|
|
set sl [expr $schedlock == "on" ? 1 : 0]
|
|
if { [build_executable "failed to prepare" $testfile-$sl \
|
|
$srcfile \
|
|
[list debug pthreads additional_flags=-DSCHEDLOCK=$sl]] \
|
|
== -1 } {
|
|
return
|
|
}
|
|
}
|
|
|
|
proc test {non-stop schedlock} {
|
|
save_vars ::GDBFLAGS {
|
|
append ::GDBFLAGS " -ex \"set non-stop ${non-stop}\""
|
|
set sl [expr $schedlock == "on" ? 1 : 0]
|
|
clean_restart $::binfile-$sl
|
|
}
|
|
|
|
set linenum1 [gdb_get_line_number "set break 1 here"]
|
|
|
|
if { ![runto $::srcfile:$linenum1] } {
|
|
return
|
|
}
|
|
|
|
delete_breakpoints
|
|
|
|
set linenum2 [gdb_get_line_number "set break 2 here"]
|
|
gdb_breakpoint $linenum2
|
|
|
|
gdb_breakpoint "thread_func"
|
|
|
|
gdb_test_no_output "set scheduler-locking $schedlock"
|
|
|
|
if {$schedlock} {
|
|
gdb_test "continue" \
|
|
"return 0.*set break 2 here .*" \
|
|
"continue does not stop in new thread"
|
|
} else {
|
|
gdb_test "continue" \
|
|
"thread_func .*" \
|
|
"continue stops in new thread"
|
|
}
|
|
}
|
|
|
|
foreach_with_prefix non-stop {off on} {
|
|
foreach_with_prefix schedlock {off on} {
|
|
test ${non-stop} ${schedlock}
|
|
}
|
|
}
|