forked from Imagelibrary/binutils-gdb
8cb6e17571
Looking at the ARM disassembler output, every comment seems to start
with a ';' character, so I assumed this was the correct character to
start an assembler comment.
I then spotted a couple of places where there was no ';', but instead,
just a '@' character. I thought that this was a case of a missing
';', and proposed a patch to add the missing ';' characters.
Turns out I was wrong, '@' is actually the ARM assembler comment
character, while ';' is the statement separator. Thus this:
nop ;@ comment
is two statements, the first is the 'nop' instruction, while the
second contains no instructions, just the '@ comment' comment text.
This:
nop @ comment
is a single 'nop' instruction followed by a comment. And finally,
this:
nop ; comment
is two statements, the first contains the 'nop' instruction, while the
second contains the instruction 'comment', which obviously isn't
actually an instruction at all.
Why this matters is that, in the next commit, I would like to add
libopcodes syntax styling support for ARM.
The question then is how should the disassembler style the three cases
above?
As '@' is the actual comment start character then clearly the '@' and
anything after it can be styled as a comment. But what about ';' in
the second example? Style as text? Style as a comment?
And the third example is even harder, what about the 'comment' text?
Style as an instruction mnemonic? Style as text? Style as a comment?
I think the only sensible answer is to move the disassembler to use
'@' consistently as its comment character, and remove all the uses of
';'.
Then, in the next commit, it's obvious what to do.
There's obviously a *lot* of tests that get updated by this commit,
the only actual code changes are in opcodes/arm-dis.c.
36 lines
854 B
Makefile
36 lines
854 B
Makefile
|
|
tmpdir/fdpic-shared.so: file format elf32-(little|big)arm
|
|
architecture: arm.*, flags 0x00000150:
|
|
HAS_SYMS, DYNAMIC, D_PAGED
|
|
start address 0x.*
|
|
|
|
Disassembly of section .plt:
|
|
|
|
.* <.plt>:
|
|
.*: e59fc008 ldr ip, \[pc, #8\] @ .* <.plt\+0x10>
|
|
.*: e08cc009 add ip, ip, r9
|
|
.*: e59c9004 ldr r9, \[ip, #4\]
|
|
.*: e59cf000 ldr pc, \[ip\]
|
|
.*: 0000000c .word 0x0000000c
|
|
.*: 00000000 .word 0x00000000
|
|
.*: e51fc00c ldr ip, \[pc, #-12\] @ .* <.plt\+0x14>
|
|
.*: e92d1000 stmfd sp!, {ip}
|
|
.*: e599c004 ldr ip, \[r9, #4\]
|
|
.*: e599f000 ldr pc, \[r9\]
|
|
|
|
Disassembly of section .text:
|
|
|
|
.* <my_shared_func1>:
|
|
.*: e12fff1e bx lr
|
|
|
|
.* <my_shared_func3>:
|
|
.*: e3a00000 mov r0, #0
|
|
.*: e12fff1e bx lr
|
|
|
|
.* <my_shared_func2>:
|
|
.*: e92d4010 push {r4, lr}
|
|
.*: e1a04009 mov r4, r9
|
|
.*: ebffffef bl .* <.plt>
|
|
.*: e1a09004 mov r9, r4
|
|
.*: e8bd8010 pop {r4, pc}
|