forked from Imagelibrary/binutils-gdb
28daddd33a
bfd_check_format currently does not take much notice of the target
set in its abfd arg, merely checking that target first if
target_defaulted is false. As the comment says this was due to
complications with archive handling which I think was fixed in
commit f832531609. It should now be possible to just check the
given target, except for linker input files. This will speed checking
the target of the first file in archives, which is done in the process
of matching archive targets.
This will no doubt expose some misuse of target options, as found in
the binutils "efi app" tests.
The stricter checking also exposed some errors. Cris targets gave
"FAIL: objcopy decompress debug sections in archive (reason: unexpected output)"
"FAIL: objcopy decompress debug sections in archive with zlib-gabi (reason: unexpected output)"
without the bfd_generic_archive_p fix. cris has a default target of
cris-aout which doesn't match objects for any of the cris-elf or
cris-linux targets. The problem here was that checking the first
object file in archives didn't match but a logic error there meant
bfd_error_wrong_object_format wasn't returned as it should be. There
was also a possibility of bfd_error_wrong_object_format persisting
from one target check to the next.
bfd/
* archive.c (bfd_generic_archive_p): Correct object in archive
target test.
* format.c (bfd_check_format_matches_lto): Try to match given
target first even when target_defaulted is set. Don't try
other targets if !target_defaulted except for linker input.
Clear bfd_error before attempted target matches.
* targets.c (bfd_find_target): Set target_defaulted for
plugin target.
binutils/
* bucomm.h (set_plugin_target): Set target_defaulted.
* testsuite/binutils-all/aarch64/pei-aarch64-little.d: Don't
wrongly specify both input and output target, just specify
output.
* testsuite/binutils-all/loongarch64/pei-loongarch64.d: Likewise.
* testsuite/binutils-all/riscv/pei-riscv64.d: Likewise.
103 lines
3.0 KiB
C
103 lines
3.0 KiB
C
/* bucomm.h -- binutils common include file.
|
||
Copyright (C) 1991-2025 Free Software Foundation, Inc.
|
||
|
||
This file is part of GNU Binutils.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program; if not, write to the Free Software
|
||
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
||
MA 02110-1301, USA. */
|
||
|
||
#ifndef _BUCOMM_H
|
||
#define _BUCOMM_H
|
||
|
||
/* In bucomm.c. */
|
||
|
||
/* Return the filename in a static buffer. */
|
||
const char *bfd_get_archive_filename (const bfd *);
|
||
|
||
void bfd_nonfatal (const char *);
|
||
|
||
void bfd_nonfatal_message (const char *, const bfd *, const asection *,
|
||
const char *, ...);
|
||
|
||
void bfd_fatal (const char *) ATTRIBUTE_NORETURN;
|
||
|
||
void report (const char *, va_list) ATTRIBUTE_PRINTF(1,0);
|
||
|
||
void fatal (const char *, ...) ATTRIBUTE_PRINTF_1 ATTRIBUTE_NORETURN;
|
||
|
||
void non_fatal (const char *, ...) ATTRIBUTE_PRINTF_1;
|
||
|
||
void *bfd_xalloc (bfd *, size_t);
|
||
|
||
void set_default_bfd_target (void);
|
||
|
||
void list_matching_formats (char **);
|
||
|
||
void list_supported_targets (const char *, FILE *);
|
||
|
||
void list_supported_architectures (const char *, FILE *);
|
||
|
||
int display_info (void);
|
||
|
||
void print_arelt_descr (FILE *, bfd *, bool, bool);
|
||
|
||
char *make_tempname (const char *, int *);
|
||
char *make_tempdir (const char *);
|
||
|
||
bfd_vma parse_vma (const char *, const char *);
|
||
|
||
off_t get_file_size (const char *);
|
||
|
||
bool is_valid_archive_path (char const *);
|
||
|
||
extern char *program_name;
|
||
|
||
/* In filemode.c. */
|
||
void mode_string (unsigned long, char *);
|
||
|
||
/* In version.c. */
|
||
extern void print_version (const char *);
|
||
|
||
/* In rename.c. */
|
||
extern void set_times (const char *, const struct stat *);
|
||
|
||
extern int smart_rename (const char *, const char *, int,
|
||
struct stat *, bool);
|
||
|
||
#if __GNUC__ >= 7
|
||
#define _mul_overflow(a, b, res) __builtin_mul_overflow (a, b, res)
|
||
#else
|
||
/* Assumes unsigned values. Careful! Args evaluated multiple times. */
|
||
#define _mul_overflow(a, b, res) \
|
||
((*res) = (a), (*res) *= (b), (b) != 0 && (*res) / (b) != (a))
|
||
#endif
|
||
|
||
/* Change ABFD target vector to TARG. ABFD is an archive element.
|
||
TARG is plugin_vec, or NULL if plugins are not supported. */
|
||
static inline void
|
||
set_plugin_target (bfd *abfd, const struct bfd_target *targ)
|
||
{
|
||
/* Don't change the target for archives like pdb that handle
|
||
elements specially, as detected by my_archive being NULL. */
|
||
if (abfd->my_archive && targ)
|
||
{
|
||
abfd->xvec = targ;
|
||
/* Don't fail if the element isn't recognised by the plugin. */
|
||
abfd->target_defaulted = true;
|
||
}
|
||
}
|
||
|
||
#endif /* _BUCOMM_H */
|