forked from Imagelibrary/binutils-gdb
At the beginning of a session, gdb may attempt to download debuginfo for all shared libraries associated with the process or core file being debugged. This can be a waste of time and storage space when much of the debuginfo ends up not being used during the session. To reduce the gdb's startup latency and to download only the debuginfo that is really needed, this patch adds on-demand, a.k.a lazy, downloading. When 'set debuginfo enabled lazy' is on, gdb will attempt to download a .gdb_index for each shared library instead of its full debuginfo. Each debuginfo download will be deferred until gdb needs to expand symtabs associated with the debuginfo's index. Additionally, all separate debug objfiles are placed in objfiles_list after their parent, instead of before. This ensures that any deferred debuginfo downloaded during iteration over objfiles_list aren't skipped by the loop. I also modified objfiles_safe so that it returns a safe reverse iterator. Reverse iteration prevents iterator invalidation by ensuring that separate debug objfiles are deleted before their parent objfile.
128 lines
3.7 KiB
C++
128 lines
3.7 KiB
C++
/* Caching of GDB/DWARF index files.
|
|
|
|
Copyright (C) 2018-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef DWARF_INDEX_CACHE_H
|
|
#define DWARF_INDEX_CACHE_H
|
|
|
|
#include "dwarf2/index-common.h"
|
|
#include "gdbsupport/array-view.h"
|
|
#include "symfile.h"
|
|
|
|
class dwarf2_per_bfd;
|
|
|
|
/* Base of the classes used to hold the resources of the indices loaded from
|
|
the cache (e.g. mmapped files). */
|
|
|
|
struct index_cache_resource
|
|
{
|
|
virtual ~index_cache_resource () = 0;
|
|
};
|
|
|
|
/* Class to manage the access to the DWARF index cache. */
|
|
|
|
class index_cache
|
|
{
|
|
public:
|
|
/* Change the directory used to save/load index files. */
|
|
void set_directory (std::string dir);
|
|
|
|
/* Return true if the usage of the cache is enabled. */
|
|
bool enabled () const
|
|
{
|
|
return m_enabled;
|
|
}
|
|
|
|
/* Enable the cache. */
|
|
void enable ();
|
|
|
|
/* Disable the cache. */
|
|
void disable ();
|
|
|
|
/* Store an index for the specified object file in the cache. */
|
|
void store (dwarf2_per_bfd *per_bfd);
|
|
|
|
/* Look for an index file matching BUILD_ID. If found, return the contents
|
|
as an array_view and store the underlying resources (allocated memory,
|
|
mapped file, etc) in RESOURCE. The returned array_view is valid as long
|
|
as RESOURCE is not destroyed.
|
|
|
|
If no matching index file is found, return an empty array view. */
|
|
gdb::array_view<const gdb_byte>
|
|
lookup_gdb_index (const bfd_build_id *build_id,
|
|
std::unique_ptr<index_cache_resource> *resource);
|
|
|
|
/* Look for an index file located at INDEX_PATH in the debuginfod cache.
|
|
Unlike lookup_gdb_index, this function does not exit early if the
|
|
index cache has not been enabled.
|
|
|
|
If found, return the contents as an array_view and store the underlying
|
|
resources (allocated memory, mapped file, etc) in RESOURCE. The returned
|
|
array_view is valid as long as RESOURCE is not destroyed.
|
|
|
|
If no matching index file is found, return an empty array view. */
|
|
gdb::array_view<const gdb_byte>
|
|
lookup_gdb_index_debuginfod (const char *index_path,
|
|
std::unique_ptr<index_cache_resource> *resource);
|
|
|
|
/* Return the number of cache hits. */
|
|
unsigned int n_hits () const
|
|
{ return m_n_hits; }
|
|
|
|
/* Record a cache hit. */
|
|
void hit ()
|
|
{
|
|
if (enabled ())
|
|
m_n_hits++;
|
|
}
|
|
|
|
/* Return the number of cache misses. */
|
|
unsigned int n_misses () const
|
|
{ return m_n_misses; }
|
|
|
|
/* Record a cache miss. */
|
|
void miss ()
|
|
{
|
|
if (enabled ())
|
|
m_n_misses++;
|
|
}
|
|
|
|
private:
|
|
|
|
/* Compute the absolute filename where the index of the objfile with build
|
|
id BUILD_ID will be stored. SUFFIX is appended at the end of the
|
|
filename. */
|
|
std::string make_index_filename (const bfd_build_id *build_id,
|
|
const char *suffix) const;
|
|
|
|
/* The base directory where we are storing and looking up index files. */
|
|
std::string m_dir;
|
|
|
|
/* Whether the cache is enabled. */
|
|
bool m_enabled = false;
|
|
|
|
/* Number of cache hits and misses during this GDB session. */
|
|
unsigned int m_n_hits = 0;
|
|
unsigned int m_n_misses = 0;
|
|
};
|
|
|
|
/* The global instance of the index cache. */
|
|
extern index_cache global_index_cache;
|
|
|
|
#endif /* DWARF_INDEX_CACHE_H */
|