Files
binutils-gdb/gdb/testsuite/gdb.ada/arrayparam.exp
Tom Tromey 1dd09e7f70 Fix Ada 'ptype' of access to array
ptype is a bit funny, in that it accepts both expressions and type
names.  It also evaluates the resulting expression using
EVAL_AVOID_SIDE_EFFECTS -- which both seems sensible (as a user would
you expect ptype to possibly cause inferior execution?), but is also a
historical artifact of how expressions are implemented (there's no
EVAL_FOR_TYPE).

In Ada, calling a function with an array will sometimes result in a
"thick pointer" array descriptor being made.  This is essentially a
structure holding a pointer and bounds information.

Currently, in such a callee, printing the type of the array will yield
funny results:

    (gdb) print str.all
    $1 = "Hello World"
    (gdb) ptype str
    type = array (<>) of character
    (gdb) ptype str.all
    type = array (1 .. 0) of character

That "1 .. 0" is the result of an EVAL_AVOID_SIDE_EFFECTS branch
trying to do "something" with an array descriptor, without doing too
much.

I tried briefly to make this code really dereference the array
descriptor and get the correct runtime type.  However, that proved to
be tricky; it certainly can't be done for all access types, because
that will cause dynamic type resolution and end up printing just the
runtime type -- which with variants may be pretty far from what the
user may expect.

Instead, this patch arranges to just leave such types alone in this
situation.  I don't think this should have an extra effects, because
things like array subscripting still work on thick pointers.

This patch also touches arrayptr.exp, because in that case the access
type is a "thin pointer", and this ensures that the output does not
change in that scenario.
2024-03-18 08:22:37 -06:00

69 lines
2.3 KiB
Plaintext

# Copyright 2008-2024 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
load_lib "ada.exp"
require allow_ada_tests
standard_ada_testfile foo
# Note we don't test the "none" (no -fgnat-encodings option) scenario
# here, because "all" and "minimal" cover the cases, and this way we
# don't have to update the test when gnat changes its default.
foreach_with_prefix scenario {all minimal} {
set flags [list debug additional_flags=-fgnat-encodings=$scenario]
if {[gdb_compile_ada "${srcfile}" "${binfile}-${scenario}" executable $flags] != ""} {
return -1
}
clean_restart ${testfile}-${scenario}
set bp_location [gdb_get_line_number "STOP" ${testdir}/foo.adb]
runto "foo.adb:$bp_location"
# Verify that a call to a function that takes an array as a parameter
# works without problem.
gdb_test "print call_me(\"bonjour\")" \
"= void"
# Verify that the array was passed properly by checking the global
# variables that Call_Me sets as side-effects. Use the package name to avoid
# name clash with debug info of system libraries.
gdb_test "print pck.first" \
"= 98 'b'" \
"print first after function call"
gdb_test "print pck.last" \
"= 114 'r'" \
"print last after function call"
gdb_test "print pck.length" \
"= 7" \
"print length after function call"
gdb_breakpoint "pck.call_me"
gdb_continue_to_breakpoint call_me
gdb_test "print str" " = \"Hello World\""
gdb_test "ptype str" "type = array \\(<>\\) of character"
gdb_test "ptype str.all" "type = array \\(<>\\) of character"
# This surrounds the type in <> -- I don't know why but it's not
# really relevant to the test.
gdb_test "ptype str.all(0)" "type = <character>"
}