forked from Imagelibrary/binutils-gdb
Most allocation functions (if not all) return a void* pointing to the allocated memory. In C++, we need to add an explicit cast when assigning the result to a pointer to another type (which is the case more often than not). The content of this patch is taken from Pedro's branch, from commit "(mostly) auto-generated patch to insert casts needed for C++". I validated that the changes make sense and manually reflowed the code to make it respect the coding style. I also found multiple places where I could use XNEW/XNEWVEC/XRESIZEVEC/etc. Thanks a lot to whoever did that automated script to insert casts, doing it completely by hand would have taken a ridiculous amount of time. Only files built on x86 with --enable-targets=all are modified. This means that all other -nat.c files are untouched and will have to be dealt with later by using appropiate compilers. Or maybe we can try to build them with a regular g++ just to know where to add casts, I don't know. I built-tested this with --enable-targets=all and reg-tested. Here's the changelog entry, which was not too bad to make despite the size, thanks to David Malcom's script. I fixed some bits by hand, but there might be some wrong parts left (hopefully not). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_stap_parse_special_token): Add cast to allocation result assignment. * ada-exp.y (write_object_renaming): Likewise. (write_ambiguous_var): Likewise. (ada_nget_field_index): Likewise. (write_var_or_type): Likewise. * ada-lang.c (ada_decode_symbol): Likewise. (ada_value_assign): Likewise. (value_pointer): Likewise. (cache_symbol): Likewise. (add_nonlocal_symbols): Likewise. (ada_name_for_lookup): Likewise. (symbol_completion_add): Likewise. (ada_to_fixed_type_1): Likewise. (ada_get_next_arg): Likewise. (defns_collected): Likewise. * ada-lex.l (processId): Likewise. (processString): Likewise. * ada-tasks.c (read_known_tasks_array): Likewise. (read_known_tasks_list): Likewise. * ada-typeprint.c (decoded_type_name): Likewise. * addrmap.c (addrmap_mutable_create_fixed): Likewise. * amd64-tdep.c (amd64_push_arguments): Likewise. (amd64_displaced_step_copy_insn): Likewise. (amd64_classify_insn_at): Likewise. (amd64_relocate_instruction): Likewise. * amd64obsd-tdep.c (amd64obsd_sigtramp_p): Likewise. * arch-utils.c (simple_displaced_step_copy_insn): Likewise. (initialize_current_architecture): Likewise. * arm-linux-tdep.c (arm_stap_parse_special_token): Likewise. * arm-symbian-tdep.c (arm_symbian_osabi_sniffer): Likewise. * arm-tdep.c (arm_exidx_new_objfile): Likewise. (arm_push_dummy_call): Likewise. (extend_buffer_earlier): Likewise. (arm_adjust_breakpoint_address): Likewise. (arm_skip_stub): Likewise. * auto-load.c (filename_is_in_pattern): Likewise. (maybe_add_script_file): Likewise. (maybe_add_script_text): Likewise. (auto_load_objfile_script_1): Likewise. * auxv.c (ld_so_xfer_auxv): Likewise. * ax-general.c (new_agent_expr): Likewise. (grow_expr): Likewise. (ax_reg_mask): Likewise. * bcache.c (bcache_full): Likewise. * breakpoint.c (program_breakpoint_here_p): Likewise. * btrace.c (parse_xml_raw): Likewise. * build-id.c (build_id_to_debug_bfd): Likewise. * buildsym.c (end_symtab_with_blockvector): Likewise. * c-exp.y (string_exp): Likewise. (qualified_name): Likewise. (write_destructor_name): Likewise. (operator_stoken): Likewise. (parse_number): Likewise. (scan_macro_expansion): Likewise. (yylex): Likewise. (c_print_token): Likewise. * c-lang.c (c_get_string): Likewise. (emit_numeric_character): Likewise. * charset.c (wchar_iterate): Likewise. * cli/cli-cmds.c (complete_command): Likewise. (make_command): Likewise. * cli/cli-dump.c (restore_section_callback): Likewise. (restore_binary_file): Likewise. * cli/cli-interp.c (cli_interpreter_exec): Likewise. * cli/cli-script.c (execute_control_command): Likewise. * cli/cli-setshow.c (do_set_command): Likewise. * coff-pe-read.c (add_pe_forwarded_sym): Likewise. (read_pe_exported_syms): Likewise. * coffread.c (coff_read_struct_type): Likewise. (coff_read_enum_type): Likewise. * common/btrace-common.c (btrace_data_append): Likewise. * common/buffer.c (buffer_grow): Likewise. * common/filestuff.c (gdb_fopen_cloexec): Likewise. * common/format.c (parse_format_string): Likewise. * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): Likewise. * common/xml-utils.c (xml_escape_text): Likewise. * compile/compile-object-load.c (copy_sections): Likewise. (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * completer.c (filename_completer): Likewise. * corefile.c (read_memory_typed_address): Likewise. (write_memory_unsigned_integer): Likewise. (write_memory_signed_integer): Likewise. (complete_set_gnutarget): Likewise. * corelow.c (get_core_register_section): Likewise. * cp-name-parser.y (d_grab): Likewise. (allocate_info): Likewise. (cp_new_demangle_parse_info): Likewise. * cp-namespace.c (cp_scan_for_anonymous_namespaces): Likewise. (cp_lookup_symbol_in_namespace): Likewise. (lookup_namespace_scope): Likewise. (find_symbol_in_baseclass): Likewise. (cp_lookup_nested_symbol): Likewise. (cp_lookup_transparent_type_loop): Likewise. * cp-support.c (copy_string_to_obstack): Likewise. (make_symbol_overload_list): Likewise. (make_symbol_overload_list_namespace): Likewise. (make_symbol_overload_list_adl_namespace): Likewise. (first_component_command): Likewise. * cp-valprint.c (cp_print_value): Likewise. * ctf.c (ctf_xfer_partial): Likewise. * d-exp.y (StringExp): Likewise. * d-namespace.c (d_lookup_symbol_in_module): Likewise. (lookup_module_scope): Likewise. (find_symbol_in_baseclass): Likewise. (d_lookup_nested_symbol): Likewise. * dbxread.c (find_stab_function_addr): Likewise. (read_dbx_symtab): Likewise. (dbx_end_psymtab): Likewise. (cp_set_block_scope): Likewise. * dcache.c (dcache_alloc): Likewise. * demangle.c (_initialize_demangler): Likewise. * dicos-tdep.c (dicos_load_module_p): Likewise. * dictionary.c (dict_create_hashed_expandable): Likewise. (dict_create_linear_expandable): Likewise. (expand_hashtable): Likewise. (add_symbol_linear_expandable): Likewise. * dwarf2-frame.c (add_cie): Likewise. (add_fde): Likewise. (dwarf2_build_frame_info): Likewise. * dwarf2expr.c (dwarf_expr_grow_stack): Likewise. (dwarf_expr_fetch_address): Likewise. (add_piece): Likewise. (execute_stack_op): Likewise. * dwarf2loc.c (chain_candidate): Likewise. (dwarf_entry_parameter_to_value): Likewise. (read_pieced_value): Likewise. (write_pieced_value): Likewise. * dwarf2read.c (dwarf2_read_section): Likewise. (add_type_unit): Likewise. (read_comp_units_from_section): Likewise. (fixup_go_packaging): Likewise. (dwarf2_compute_name): Likewise. (dwarf2_physname): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (read_func_scope): Likewise. (read_call_site_scope): Likewise. (dwarf2_attach_fields_to_type): Likewise. (process_structure_scope): Likewise. (mark_common_block_symbol_computed): Likewise. (read_common_block): Likewise. (abbrev_table_read_table): Likewise. (guess_partial_die_structure_name): Likewise. (fixup_partial_die): Likewise. (add_file_name): Likewise. (dwarf2_const_value_data): Likewise. (dwarf2_const_value_attr): Likewise. (build_error_marker_type): Likewise. (guess_full_die_structure_name): Likewise. (anonymous_struct_prefix): Likewise. (typename_concat): Likewise. (dwarf2_canonicalize_name): Likewise. (dwarf2_name): Likewise. (write_constant_as_bytes): Likewise. (dwarf2_fetch_constant_bytes): Likewise. (copy_string): Likewise. (parse_macro_definition): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_rel_plt_read): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_gnu_ifunc_resolve_by_got): Likewise. (elf_read_minimal_symbols): Likewise. (elf_gnu_ifunc_record_cache): Likewise. * event-top.c (top_level_prompt): Likewise. (command_line_handler): Likewise. * exec.c (resize_section_table): Likewise. * expprint.c (print_subexp_standard): Likewise. * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise. * findcmd.c (parse_find_args): Likewise. * findvar.c (address_from_register): Likewise. * frame.c (get_prev_frame_always): Likewise. * gdb_bfd.c (gdb_bfd_ref): Likewise. (get_section_descriptor): Likewise. * gdb_obstack.c (obconcat): Likewise. (obstack_strdup): Likewise. * gdbtypes.c (lookup_function_type_with_arguments): Likewise. (create_set_type): Likewise. (lookup_unsigned_typename): Likewise. (lookup_signed_typename): Likewise. (resolve_dynamic_union): Likewise. (resolve_dynamic_struct): Likewise. (add_dyn_prop): Likewise. (copy_dynamic_prop_list): Likewise. (arch_flags_type): Likewise. (append_composite_type_field_raw): Likewise. * gdbtypes.h (INIT_FUNC_SPECIFIC): Likewise. * gnu-v3-abi.c (gnuv3_rtti_type): Likewise. * go-exp.y (string_exp): Likewise. * go-lang.c (go_demangle): Likewise. * guile/guile.c (compute_scheme_string): Likewise. * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise. (gdbscm_canonicalize_command_name): Likewise. * guile/scm-ports.c (ioscm_init_stdio_buffers): Likewise. (ioscm_init_memory_port): Likewise. (ioscm_reinit_memory_port): Likewise. * guile/scm-utils.c (gdbscm_gc_xstrdup): Likewise. (gdbscm_gc_dup_argv): Likewise. * h8300-tdep.c (h8300_push_dummy_call): Likewise. * hppa-tdep.c (internalize_unwinds): Likewise. (read_unwind_info): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. (windows_core_xfer_shared_libraries): Likewise. * i386-tdep.c (i386_displaced_step_copy_insn): Likewise. (i386_stap_parse_special_token_triplet): Likewise. (i386_stap_parse_special_token_three_arg_disp): Likewise. * i386obsd-tdep.c (i386obsd_sigtramp_p): Likewise. * inf-child.c (inf_child_fileio_readlink): Likewise. * inf-ptrace.c (inf_ptrace_fetch_register): Likewise. (inf_ptrace_store_register): Likewise. * infrun.c (follow_exec): Likewise. (displaced_step_prepare_throw): Likewise. (save_stop_context): Likewise. (save_infcall_suspend_state): Likewise. * jit.c (jit_read_descriptor): Likewise. (jit_read_code_entry): Likewise. (jit_symtab_line_mapping_add_impl): Likewise. (finalize_symtab): Likewise. (jit_unwind_reg_get_impl): Likewise. * jv-exp.y (QualifiedName): Likewise. * jv-lang.c (get_java_utf8_name): Likewise. (type_from_class): Likewise. (java_demangle_type_signature): Likewise. (java_class_name_from_physname): Likewise. * jv-typeprint.c (java_type_print_base): Likewise. * jv-valprint.c (java_value_print): Likewise. * language.c (add_language): Likewise. * linespec.c (add_sal_to_sals_basic): Likewise. (add_sal_to_sals): Likewise. (decode_objc): Likewise. (find_linespec_symbols): Likewise. * linux-fork.c (fork_save_infrun_state): Likewise. * linux-nat.c (linux_nat_detach): Likewise. (linux_nat_fileio_readlink): Likewise. * linux-record.c (record_linux_sockaddr): Likewise. (record_linux_msghdr): Likewise. (Do): Likewise. * linux-tdep.c (linux_core_info_proc_mappings): Likewise. (linux_collect_regset_section_cb): Likewise. (linux_get_siginfo_data): Likewise. * linux-thread-db.c (try_thread_db_load_from_pdir_1): Likewise. (try_thread_db_load_from_dir): Likewise. (thread_db_load_search): Likewise. (info_auto_load_libthread_db): Likewise. * m32c-tdep.c (m32c_m16c_address_to_pointer): Likewise. (m32c_m16c_pointer_to_address): Likewise. * m68hc11-tdep.c (m68hc11_pseudo_register_write): Likewise. * m68k-tdep.c (m68k_get_longjmp_target): Likewise. * machoread.c (macho_check_dsym): Likewise. * macroexp.c (resize_buffer): Likewise. (gather_arguments): Likewise. (maybe_expand): Likewise. * macrotab.c (new_macro_key): Likewise. (new_source_file): Likewise. (new_macro_definition): Likewise. * mdebugread.c (parse_symbol): Likewise. (parse_type): Likewise. (parse_partial_symbols): Likewise. (psymtab_to_symtab_1): Likewise. * mem-break.c (default_memory_insert_breakpoint): Likewise. * mi/mi-cmd-break.c (mi_argv_to_format): Likewise. * mi/mi-main.c (mi_cmd_data_read_memory): Likewise. (mi_cmd_data_read_memory_bytes): Likewise. (mi_cmd_data_write_memory_bytes): Likewise. (mi_cmd_trace_frame_collected): Likewise. * mi/mi-parse.c (mi_parse_argv): Likewise. (mi_parse): Likewise. * minidebug.c (lzma_open): Likewise. (lzma_pread): Likewise. * mips-tdep.c (mips_read_fp_register_single): Likewise. (mips_print_fp_register): Likewise. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Likewise. * mipsread.c (read_alphacoff_dynamic_symtab): Likewise. * mt-tdep.c (mt_register_name): Likewise. (mt_registers_info): Likewise. (mt_push_dummy_call): Likewise. * namespace.c (add_using_directive): Likewise. * nat/linux-btrace.c (perf_event_read): Likewise. (linux_enable_bts): Likewise. * nat/linux-osdata.c (linux_common_core_of_thread): Likewise. * nat/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Likewise. * nto-tdep.c (nto_find_and_open_solib): Likewise. (nto_parse_redirection): Likewise. * objc-lang.c (objc_demangle): Likewise. (find_methods): Likewise. * objfiles.c (get_objfile_bfd_data): Likewise. (set_objfile_main_name): Likewise. (allocate_objfile): Likewise. (objfile_relocate): Likewise. (update_section_map): Likewise. * osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Likewise. * p-exp.y (exp): Likewise. (yylex): Likewise. * p-valprint.c (pascal_object_print_value): Likewise. * parse.c (initialize_expout): Likewise. (mark_completion_tag): Likewise. (copy_name): Likewise. (parse_float): Likewise. (type_stack_reserve): Likewise. * ppc-linux-tdep.c (ppc_stap_parse_special_token): Likewise. (ppu2spu_prev_register): Likewise. * ppc-ravenscar-thread.c (supply_register_at_address): Likewise. * printcmd.c (printf_wide_c_string): Likewise. (printf_pointer): Likewise. * probe.c (parse_probes): Likewise. * python/py-cmd.c (gdbpy_parse_command_name): Likewise. (cmdpy_init): Likewise. * python/py-gdb-readline.c (gdbpy_readline_wrapper): Likewise. * python/py-symtab.c (set_sal): Likewise. * python/py-unwind.c (pyuw_sniffer): Likewise. * python/python.c (python_interactive_command): Likewise. (compute_python_string): Likewise. * ravenscar-thread.c (get_running_thread_id): Likewise. * record-full.c (record_full_exec_insn): Likewise. (record_full_core_open_1): Likewise. * regcache.c (regcache_raw_read_signed): Likewise. (regcache_raw_read_unsigned): Likewise. (regcache_cooked_read_signed): Likewise. (regcache_cooked_read_unsigned): Likewise. * remote-fileio.c (remote_fileio_func_open): Likewise. (remote_fileio_func_rename): Likewise. (remote_fileio_func_unlink): Likewise. (remote_fileio_func_stat): Likewise. (remote_fileio_func_system): Likewise. * remote-mips.c (mips_xfer_memory): Likewise. (mips_load_srec): Likewise. (pmon_end_download): Likewise. * remote.c (new_remote_state): Likewise. (map_regcache_remote_table): Likewise. (remote_register_number_and_offset): Likewise. (init_remote_state): Likewise. (get_memory_packet_size): Likewise. (remote_pass_signals): Likewise. (remote_program_signals): Likewise. (remote_start_remote): Likewise. (remote_check_symbols): Likewise. (remote_query_supported): Likewise. (extended_remote_attach): Likewise. (process_g_packet): Likewise. (store_registers_using_G): Likewise. (putpkt_binary): Likewise. (read_frame): Likewise. (compare_sections_command): Likewise. (remote_hostio_pread): Likewise. (remote_hostio_readlink): Likewise. (remote_file_put): Likewise. (remote_file_get): Likewise. (remote_pid_to_exec_file): Likewise. (_initialize_remote): Likewise. * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise. (rs6000_aix_core_xfer_shared_libraries_aix): Likewise. * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise. (bfd_uses_spe_extensions): Likewise. * s390-linux-tdep.c (s390_displaced_step_copy_insn): Likewise. * score-tdep.c (score7_malloc_and_get_memblock): Likewise. * solib-dsbt.c (decode_loadmap): Likewise. (fetch_loadmap): Likewise. (scan_dyntag): Likewise. (enable_break): Likewise. (dsbt_relocate_main_executable): Likewise. * solib-frv.c (fetch_loadmap): Likewise. (enable_break2): Likewise. (frv_relocate_main_executable): Likewise. * solib-spu.c (spu_relocate_main_executable): Likewise. (spu_bfd_open): Likewise. * solib-svr4.c (lm_info_read): Likewise. (read_program_header): Likewise. (find_program_interpreter): Likewise. (scan_dyntag): Likewise. (elf_locate_base): Likewise. (open_symbol_file_object): Likewise. (read_program_headers_from_bfd): Likewise. (svr4_relocate_main_executable): Likewise. * solib-target.c (solib_target_relocate_section_addresses): Likewise. * solib.c (solib_find_1): Likewise. (exec_file_find): Likewise. (solib_find): Likewise. * source.c (openp): Likewise. (print_source_lines_base): Likewise. (forward_search_command): Likewise. * sparc-ravenscar-thread.c (supply_register_at_address): Likewise. * spu-tdep.c (spu2ppu_prev_register): Likewise. (spu_get_overlay_table): Likewise. * stabsread.c (patch_block_stabs): Likewise. (define_symbol): Likewise. (again:): Likewise. (read_member_functions): Likewise. (read_one_struct_field): Likewise. (read_enum_type): Likewise. (common_block_start): Likewise. * stack.c (read_frame_arg): Likewise. (backtrace_command): Likewise. * stap-probe.c (stap_parse_register_operand): Likewise. * symfile.c (syms_from_objfile_1): Likewise. (find_separate_debug_file): Likewise. (load_command): Likewise. (load_progress): Likewise. (load_section_callback): Likewise. (reread_symbols): Likewise. (add_filename_language): Likewise. (allocate_compunit_symtab): Likewise. (read_target_long_array): Likewise. (simple_read_overlay_table): Likewise. * symtab.c (symbol_set_names): Likewise. (resize_symbol_cache): Likewise. (rbreak_command): Likewise. (completion_list_add_name): Likewise. (completion_list_objc_symbol): Likewise. (add_filename_to_list): Likewise. * target-descriptions.c (maint_print_c_tdesc_cmd): Likewise. * target-memory.c (target_write_memory_blocks): Likewise. * target.c (target_read_string): Likewise. (read_whatever_is_readable): Likewise. (target_read_alloc_1): Likewise. (simple_search_memory): Likewise. (target_fileio_read_alloc_1): Likewise. * tilegx-tdep.c (tilegx_push_dummy_call): Likewise. * top.c (command_line_input): Likewise. * tracefile-tfile.c (tfile_fetch_registers): Likewise. * tracefile.c (tracefile_fetch_registers): Likewise. * tracepoint.c (add_memrange): Likewise. (init_collection_list): Likewise. (add_aexpr): Likewise. (trace_dump_actions): Likewise. (parse_trace_status): Likewise. (parse_tracepoint_definition): Likewise. (parse_tsv_definition): Likewise. (parse_static_tracepoint_marker_definition): Likewise. * tui/tui-file.c (tui_sfileopen): Likewise. (tui_file_adjust_strbuf): Likewise. * tui/tui-io.c (tui_expand_tabs): Likewise. * tui/tui-source.c (tui_set_source_content): Likewise. * typeprint.c (find_global_typedef): Likewise. * ui-file.c (do_ui_file_xstrdup): Likewise. (ui_file_obsavestring): Likewise. (mem_file_write): Likewise. * utils.c (make_hex_string): Likewise. (get_regcomp_error): Likewise. (puts_filtered_tabular): Likewise. (gdb_realpath_keepfile): Likewise. (ldirname): Likewise. (gdb_bfd_errmsg): Likewise. (substitute_path_component): Likewise. * valops.c (search_struct_method): Likewise. (find_oload_champ_namespace_loop): Likewise. * valprint.c (print_decimal_chars): Likewise. (read_string): Likewise. (generic_emit_char): Likewise. * varobj.c (varobj_delete): Likewise. (varobj_value_get_print_value): Likewise. * vaxobsd-tdep.c (vaxobsd_sigtramp_sniffer): Likewise. * windows-tdep.c (display_one_tib): Likewise. * xcoffread.c (read_xcoff_symtab): Likewise. (process_xcoff_symbol): Likewise. (swap_sym): Likewise. (scan_xcoff_symtab): Likewise. (xcoff_initial_scan): Likewise. * xml-support.c (gdb_xml_end_element): Likewise. (xml_process_xincludes): Likewise. (xml_fetch_content_from_file): Likewise. * xml-syscall.c (xml_list_of_syscalls): Likewise. * xstormy16-tdep.c (xstormy16_push_dummy_call): Likewise. gdb/gdbserver/ChangeLog: * ax.c (gdb_parse_agent_expr): Add cast to allocation result assignment. (gdb_unparse_agent_expr): Likewise. * hostio.c (require_data): Likewise. (handle_pread): Likewise. * linux-low.c (disable_regset): Likewise. (fetch_register): Likewise. (store_register): Likewise. (get_dynamic): Likewise. (linux_qxfer_libraries_svr4): Likewise. * mem-break.c (delete_fast_tracepoint_jump): Likewise. (set_fast_tracepoint_jump): Likewise. (uninsert_fast_tracepoint_jumps_at): Likewise. (reinsert_fast_tracepoint_jumps_at): Likewise. (validate_inserted_breakpoint): Likewise. (clone_agent_expr): Likewise. * regcache.c (init_register_cache): Likewise. * remote-utils.c (putpkt_binary_1): Likewise. (decode_M_packet): Likewise. (decode_X_packet): Likewise. (look_up_one_symbol): Likewise. (relocate_instruction): Likewise. (monitor_output): Likewise. * server.c (handle_search_memory): Likewise. (handle_qxfer_exec_file): Likewise. (handle_qxfer_libraries): Likewise. (handle_qxfer): Likewise. (handle_query): Likewise. (handle_v_cont): Likewise. (handle_v_run): Likewise. (captured_main): Likewise. * target.c (write_inferior_memory): Likewise. * thread-db.c (try_thread_db_load_from_dir): Likewise. * tracepoint.c (init_trace_buffer): Likewise. (add_tracepoint_action): Likewise. (add_traceframe): Likewise. (add_traceframe_block): Likewise. (cmd_qtdpsrc): Likewise. (cmd_qtdv): Likewise. (cmd_qtstatus): Likewise. (response_source): Likewise. (response_tsv): Likewise. (cmd_qtnotes): Likewise. (gdb_collect): Likewise. (initialize_tracepoint): Likewise.
523 lines
15 KiB
C
523 lines
15 KiB
C
/* Target-dependent code for OpenBSD/i386.
|
||
|
||
Copyright (C) 1988-2015 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "arch-utils.h"
|
||
#include "frame.h"
|
||
#include "frame-unwind.h"
|
||
#include "gdbcore.h"
|
||
#include "regcache.h"
|
||
#include "regset.h"
|
||
#include "symtab.h"
|
||
#include "objfiles.h"
|
||
#include "osabi.h"
|
||
#include "target.h"
|
||
#include "trad-frame.h"
|
||
|
||
#include "obsd-tdep.h"
|
||
#include "i386-tdep.h"
|
||
#include "i387-tdep.h"
|
||
#include "solib-svr4.h"
|
||
#include "bsd-uthread.h"
|
||
|
||
/* Support for signal handlers. */
|
||
|
||
/* Since OpenBSD 3.2, the sigtramp routine is mapped at a random page
|
||
in virtual memory. The randomness makes it somewhat tricky to
|
||
detect it, but fortunately we can rely on the fact that the start
|
||
of the sigtramp routine is page-aligned. We recognize the
|
||
trampoline by looking for the code that invokes the sigreturn
|
||
system call. The offset where we can find that code varies from
|
||
release to release.
|
||
|
||
By the way, the mapping mentioned above is read-only, so you cannot
|
||
place a breakpoint in the signal trampoline. */
|
||
|
||
/* Default page size. */
|
||
static const int i386obsd_page_size = 4096;
|
||
|
||
/* Offset for sigreturn(2). */
|
||
static const int i386obsd_sigreturn_offset[] = {
|
||
0x0a, /* OpenBSD 3.2 */
|
||
0x14, /* OpenBSD 3.6 */
|
||
0x3a, /* OpenBSD 3.8 */
|
||
-1
|
||
};
|
||
|
||
/* Return whether THIS_FRAME corresponds to an OpenBSD sigtramp
|
||
routine. */
|
||
|
||
static int
|
||
i386obsd_sigtramp_p (struct frame_info *this_frame)
|
||
{
|
||
CORE_ADDR pc = get_frame_pc (this_frame);
|
||
CORE_ADDR start_pc = (pc & ~(i386obsd_page_size - 1));
|
||
/* The call sequence invoking sigreturn(2). */
|
||
const gdb_byte sigreturn[] =
|
||
{
|
||
0xb8,
|
||
0x67, 0x00, 0x00, 0x00, /* movl $SYS_sigreturn, %eax */
|
||
0xcd, 0x80 /* int $0x80 */
|
||
};
|
||
size_t buflen = sizeof sigreturn;
|
||
const int *offset;
|
||
gdb_byte *buf;
|
||
const char *name;
|
||
|
||
/* If the function has a valid symbol name, it isn't a
|
||
trampoline. */
|
||
find_pc_partial_function (pc, &name, NULL, NULL);
|
||
if (name != NULL)
|
||
return 0;
|
||
|
||
/* If the function lives in a valid section (even without a starting
|
||
point) it isn't a trampoline. */
|
||
if (find_pc_section (pc) != NULL)
|
||
return 0;
|
||
|
||
/* Allocate buffer. */
|
||
buf = (gdb_byte *) alloca (buflen);
|
||
|
||
/* Loop over all offsets. */
|
||
for (offset = i386obsd_sigreturn_offset; *offset != -1; offset++)
|
||
{
|
||
/* If we can't read the instructions, return zero. */
|
||
if (!safe_frame_unwind_memory (this_frame, start_pc + *offset,
|
||
buf, buflen))
|
||
return 0;
|
||
|
||
/* Check for sigreturn(2). */
|
||
if (memcmp (buf, sigreturn, buflen) == 0)
|
||
return 1;
|
||
}
|
||
|
||
return 0;
|
||
}
|
||
|
||
/* Mapping between the general-purpose registers in `struct reg'
|
||
format and GDB's register cache layout. */
|
||
|
||
/* From <machine/reg.h>. */
|
||
static int i386obsd_r_reg_offset[] =
|
||
{
|
||
0 * 4, /* %eax */
|
||
1 * 4, /* %ecx */
|
||
2 * 4, /* %edx */
|
||
3 * 4, /* %ebx */
|
||
4 * 4, /* %esp */
|
||
5 * 4, /* %ebp */
|
||
6 * 4, /* %esi */
|
||
7 * 4, /* %edi */
|
||
8 * 4, /* %eip */
|
||
9 * 4, /* %eflags */
|
||
10 * 4, /* %cs */
|
||
11 * 4, /* %ss */
|
||
12 * 4, /* %ds */
|
||
13 * 4, /* %es */
|
||
14 * 4, /* %fs */
|
||
15 * 4 /* %gs */
|
||
};
|
||
|
||
static void
|
||
i386obsd_aout_supply_regset (const struct regset *regset,
|
||
struct regcache *regcache, int regnum,
|
||
const void *regs, size_t len)
|
||
{
|
||
struct gdbarch *gdbarch = get_regcache_arch (regcache);
|
||
const struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
|
||
const gdb_byte *gregs = regs;
|
||
|
||
gdb_assert (len >= tdep->sizeof_gregset + I387_SIZEOF_FSAVE);
|
||
|
||
i386_supply_gregset (regset, regcache, regnum, regs, tdep->sizeof_gregset);
|
||
i387_supply_fsave (regcache, regnum, gregs + tdep->sizeof_gregset);
|
||
}
|
||
|
||
static const struct regset i386obsd_aout_gregset =
|
||
{
|
||
NULL, i386obsd_aout_supply_regset, NULL
|
||
};
|
||
|
||
static void
|
||
i386obsd_aout_iterate_over_regset_sections (struct gdbarch *gdbarch,
|
||
iterate_over_regset_sections_cb *cb,
|
||
void *cb_data,
|
||
const struct regcache *regcache)
|
||
{
|
||
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
|
||
|
||
/* OpenBSD a.out core dumps don't use seperate register sets for the
|
||
general-purpose and floating-point registers. */
|
||
|
||
cb (".reg", tdep->sizeof_gregset + I387_SIZEOF_FSAVE,
|
||
&i386obsd_aout_gregset, NULL, cb_data);
|
||
}
|
||
|
||
|
||
/* Sigtramp routine location for OpenBSD 3.1 and earlier releases. */
|
||
CORE_ADDR i386obsd_sigtramp_start_addr = 0xbfbfdf20;
|
||
CORE_ADDR i386obsd_sigtramp_end_addr = 0xbfbfdff0;
|
||
|
||
/* From <machine/signal.h>. */
|
||
int i386obsd_sc_reg_offset[I386_NUM_GREGS] =
|
||
{
|
||
10 * 4, /* %eax */
|
||
9 * 4, /* %ecx */
|
||
8 * 4, /* %edx */
|
||
7 * 4, /* %ebx */
|
||
14 * 4, /* %esp */
|
||
6 * 4, /* %ebp */
|
||
5 * 4, /* %esi */
|
||
4 * 4, /* %edi */
|
||
11 * 4, /* %eip */
|
||
13 * 4, /* %eflags */
|
||
12 * 4, /* %cs */
|
||
15 * 4, /* %ss */
|
||
3 * 4, /* %ds */
|
||
2 * 4, /* %es */
|
||
1 * 4, /* %fs */
|
||
0 * 4 /* %gs */
|
||
};
|
||
|
||
/* From /usr/src/lib/libpthread/arch/i386/uthread_machdep.c. */
|
||
static int i386obsd_uthread_reg_offset[] =
|
||
{
|
||
11 * 4, /* %eax */
|
||
10 * 4, /* %ecx */
|
||
9 * 4, /* %edx */
|
||
8 * 4, /* %ebx */
|
||
-1, /* %esp */
|
||
6 * 4, /* %ebp */
|
||
5 * 4, /* %esi */
|
||
4 * 4, /* %edi */
|
||
12 * 4, /* %eip */
|
||
-1, /* %eflags */
|
||
13 * 4, /* %cs */
|
||
-1, /* %ss */
|
||
3 * 4, /* %ds */
|
||
2 * 4, /* %es */
|
||
1 * 4, /* %fs */
|
||
0 * 4 /* %gs */
|
||
};
|
||
|
||
/* Offset within the thread structure where we can find the saved
|
||
stack pointer (%esp). */
|
||
#define I386OBSD_UTHREAD_ESP_OFFSET 176
|
||
|
||
static void
|
||
i386obsd_supply_uthread (struct regcache *regcache,
|
||
int regnum, CORE_ADDR addr)
|
||
{
|
||
struct gdbarch *gdbarch = get_regcache_arch (regcache);
|
||
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
||
CORE_ADDR sp_addr = addr + I386OBSD_UTHREAD_ESP_OFFSET;
|
||
CORE_ADDR sp = 0;
|
||
gdb_byte buf[4];
|
||
int i;
|
||
|
||
gdb_assert (regnum >= -1);
|
||
|
||
if (regnum == -1 || regnum == I386_ESP_REGNUM)
|
||
{
|
||
int offset;
|
||
|
||
/* Fetch stack pointer from thread structure. */
|
||
sp = read_memory_unsigned_integer (sp_addr, 4, byte_order);
|
||
|
||
/* Adjust the stack pointer such that it looks as if we just
|
||
returned from _thread_machdep_switch. */
|
||
offset = i386obsd_uthread_reg_offset[I386_EIP_REGNUM] + 4;
|
||
store_unsigned_integer (buf, 4, byte_order, sp + offset);
|
||
regcache_raw_supply (regcache, I386_ESP_REGNUM, buf);
|
||
}
|
||
|
||
for (i = 0; i < ARRAY_SIZE (i386obsd_uthread_reg_offset); i++)
|
||
{
|
||
if (i386obsd_uthread_reg_offset[i] != -1
|
||
&& (regnum == -1 || regnum == i))
|
||
{
|
||
/* Fetch stack pointer from thread structure (if we didn't
|
||
do so already). */
|
||
if (sp == 0)
|
||
sp = read_memory_unsigned_integer (sp_addr, 4, byte_order);
|
||
|
||
/* Read the saved register from the stack frame. */
|
||
read_memory (sp + i386obsd_uthread_reg_offset[i], buf, 4);
|
||
regcache_raw_supply (regcache, i, buf);
|
||
}
|
||
}
|
||
}
|
||
|
||
static void
|
||
i386obsd_collect_uthread (const struct regcache *regcache,
|
||
int regnum, CORE_ADDR addr)
|
||
{
|
||
struct gdbarch *gdbarch = get_regcache_arch (regcache);
|
||
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
||
CORE_ADDR sp_addr = addr + I386OBSD_UTHREAD_ESP_OFFSET;
|
||
CORE_ADDR sp = 0;
|
||
gdb_byte buf[4];
|
||
int i;
|
||
|
||
gdb_assert (regnum >= -1);
|
||
|
||
if (regnum == -1 || regnum == I386_ESP_REGNUM)
|
||
{
|
||
int offset;
|
||
|
||
/* Calculate the stack pointer (frame pointer) that will be
|
||
stored into the thread structure. */
|
||
offset = i386obsd_uthread_reg_offset[I386_EIP_REGNUM] + 4;
|
||
regcache_raw_collect (regcache, I386_ESP_REGNUM, buf);
|
||
sp = extract_unsigned_integer (buf, 4, byte_order) - offset;
|
||
|
||
/* Store the stack pointer. */
|
||
write_memory_unsigned_integer (sp_addr, 4, byte_order, sp);
|
||
|
||
/* The stack pointer was (potentially) modified. Make sure we
|
||
build a proper stack frame. */
|
||
regnum = -1;
|
||
}
|
||
|
||
for (i = 0; i < ARRAY_SIZE (i386obsd_uthread_reg_offset); i++)
|
||
{
|
||
if (i386obsd_uthread_reg_offset[i] != -1
|
||
&& (regnum == -1 || regnum == i))
|
||
{
|
||
/* Fetch stack pointer from thread structure (if we didn't
|
||
calculate it already). */
|
||
if (sp == 0)
|
||
sp = read_memory_unsigned_integer (sp_addr, 4, byte_order);
|
||
|
||
/* Write the register into the stack frame. */
|
||
regcache_raw_collect (regcache, i, buf);
|
||
write_memory (sp + i386obsd_uthread_reg_offset[i], buf, 4);
|
||
}
|
||
}
|
||
}
|
||
|
||
/* Kernel debugging support. */
|
||
|
||
/* From <machine/frame.h>. Note that %esp and %ess are only saved in
|
||
a trap frame when entering the kernel from user space. */
|
||
static int i386obsd_tf_reg_offset[] =
|
||
{
|
||
10 * 4, /* %eax */
|
||
9 * 4, /* %ecx */
|
||
8 * 4, /* %edx */
|
||
7 * 4, /* %ebx */
|
||
-1, /* %esp */
|
||
6 * 4, /* %ebp */
|
||
5 * 4, /* %esi */
|
||
4 * 4, /* %edi */
|
||
13 * 4, /* %eip */
|
||
15 * 4, /* %eflags */
|
||
14 * 4, /* %cs */
|
||
-1, /* %ss */
|
||
3 * 4, /* %ds */
|
||
2 * 4, /* %es */
|
||
0 * 4, /* %fs */
|
||
1 * 4 /* %gs */
|
||
};
|
||
|
||
static struct trad_frame_cache *
|
||
i386obsd_trapframe_cache (struct frame_info *this_frame, void **this_cache)
|
||
{
|
||
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
||
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
||
struct trad_frame_cache *cache;
|
||
CORE_ADDR func, sp, addr;
|
||
ULONGEST cs;
|
||
const char *name;
|
||
int i;
|
||
|
||
if (*this_cache)
|
||
return *this_cache;
|
||
|
||
cache = trad_frame_cache_zalloc (this_frame);
|
||
*this_cache = cache;
|
||
|
||
func = get_frame_func (this_frame);
|
||
sp = get_frame_register_unsigned (this_frame, I386_ESP_REGNUM);
|
||
|
||
find_pc_partial_function (func, &name, NULL, NULL);
|
||
if (name && startswith (name, "Xintr"))
|
||
addr = sp + 8; /* It's an interrupt frame. */
|
||
else
|
||
addr = sp;
|
||
|
||
for (i = 0; i < ARRAY_SIZE (i386obsd_tf_reg_offset); i++)
|
||
if (i386obsd_tf_reg_offset[i] != -1)
|
||
trad_frame_set_reg_addr (cache, i, addr + i386obsd_tf_reg_offset[i]);
|
||
|
||
/* Read %cs from trap frame. */
|
||
addr += i386obsd_tf_reg_offset[I386_CS_REGNUM];
|
||
cs = read_memory_unsigned_integer (addr, 4, byte_order);
|
||
if ((cs & I386_SEL_RPL) == I386_SEL_UPL)
|
||
{
|
||
/* Trap from user space; terminate backtrace. */
|
||
trad_frame_set_id (cache, outer_frame_id);
|
||
}
|
||
else
|
||
{
|
||
/* Construct the frame ID using the function start. */
|
||
trad_frame_set_id (cache, frame_id_build (sp + 8, func));
|
||
}
|
||
|
||
return cache;
|
||
}
|
||
|
||
static void
|
||
i386obsd_trapframe_this_id (struct frame_info *this_frame,
|
||
void **this_cache, struct frame_id *this_id)
|
||
{
|
||
struct trad_frame_cache *cache =
|
||
i386obsd_trapframe_cache (this_frame, this_cache);
|
||
|
||
trad_frame_get_id (cache, this_id);
|
||
}
|
||
|
||
static struct value *
|
||
i386obsd_trapframe_prev_register (struct frame_info *this_frame,
|
||
void **this_cache, int regnum)
|
||
{
|
||
struct trad_frame_cache *cache =
|
||
i386obsd_trapframe_cache (this_frame, this_cache);
|
||
|
||
return trad_frame_get_register (cache, this_frame, regnum);
|
||
}
|
||
|
||
static int
|
||
i386obsd_trapframe_sniffer (const struct frame_unwind *self,
|
||
struct frame_info *this_frame,
|
||
void **this_prologue_cache)
|
||
{
|
||
ULONGEST cs;
|
||
const char *name;
|
||
|
||
/* Check Current Privilege Level and bail out if we're not executing
|
||
in kernel space. */
|
||
cs = get_frame_register_unsigned (this_frame, I386_CS_REGNUM);
|
||
if ((cs & I386_SEL_RPL) == I386_SEL_UPL)
|
||
return 0;
|
||
|
||
find_pc_partial_function (get_frame_pc (this_frame), &name, NULL, NULL);
|
||
return (name && (strcmp (name, "calltrap") == 0
|
||
|| strcmp (name, "syscall1") == 0
|
||
|| startswith (name, "Xintr")
|
||
|| startswith (name, "Xsoft")));
|
||
}
|
||
|
||
static const struct frame_unwind i386obsd_trapframe_unwind = {
|
||
/* FIXME: kettenis/20051219: This really is more like an interrupt
|
||
frame, but SIGTRAMP_FRAME would print <signal handler called>,
|
||
which really is not what we want here. */
|
||
NORMAL_FRAME,
|
||
default_frame_unwind_stop_reason,
|
||
i386obsd_trapframe_this_id,
|
||
i386obsd_trapframe_prev_register,
|
||
NULL,
|
||
i386obsd_trapframe_sniffer
|
||
};
|
||
|
||
|
||
static void
|
||
i386obsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
||
{
|
||
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
|
||
|
||
/* Obviously OpenBSD is BSD-based. */
|
||
i386bsd_init_abi (info, gdbarch);
|
||
obsd_init_abi (info, gdbarch);
|
||
|
||
/* OpenBSD has a different `struct reg'. */
|
||
tdep->gregset_reg_offset = i386obsd_r_reg_offset;
|
||
tdep->gregset_num_regs = ARRAY_SIZE (i386obsd_r_reg_offset);
|
||
tdep->sizeof_gregset = 16 * 4;
|
||
|
||
/* OpenBSD uses -freg-struct-return by default. */
|
||
tdep->struct_return = reg_struct_return;
|
||
|
||
/* OpenBSD uses a different memory layout. */
|
||
tdep->sigtramp_start = i386obsd_sigtramp_start_addr;
|
||
tdep->sigtramp_end = i386obsd_sigtramp_end_addr;
|
||
tdep->sigtramp_p = i386obsd_sigtramp_p;
|
||
|
||
/* OpenBSD has a `struct sigcontext' that's different from the
|
||
original 4.3 BSD. */
|
||
tdep->sc_reg_offset = i386obsd_sc_reg_offset;
|
||
tdep->sc_num_regs = ARRAY_SIZE (i386obsd_sc_reg_offset);
|
||
|
||
/* OpenBSD provides a user-level threads implementation. */
|
||
bsd_uthread_set_supply_uthread (gdbarch, i386obsd_supply_uthread);
|
||
bsd_uthread_set_collect_uthread (gdbarch, i386obsd_collect_uthread);
|
||
|
||
/* Unwind kernel trap frames correctly. */
|
||
frame_unwind_prepend_unwinder (gdbarch, &i386obsd_trapframe_unwind);
|
||
}
|
||
|
||
/* OpenBSD a.out. */
|
||
|
||
static void
|
||
i386obsd_aout_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
||
{
|
||
i386obsd_init_abi (info, gdbarch);
|
||
|
||
/* OpenBSD a.out has a single register set. */
|
||
set_gdbarch_iterate_over_regset_sections
|
||
(gdbarch, i386obsd_aout_iterate_over_regset_sections);
|
||
}
|
||
|
||
/* OpenBSD ELF. */
|
||
|
||
static void
|
||
i386obsd_elf_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
||
{
|
||
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
|
||
|
||
/* It's still OpenBSD. */
|
||
i386obsd_init_abi (info, gdbarch);
|
||
|
||
/* But ELF-based. */
|
||
i386_elf_init_abi (info, gdbarch);
|
||
|
||
/* OpenBSD ELF uses SVR4-style shared libraries. */
|
||
set_solib_svr4_fetch_link_map_offsets
|
||
(gdbarch, svr4_ilp32_fetch_link_map_offsets);
|
||
}
|
||
|
||
|
||
/* Provide a prototype to silence -Wmissing-prototypes. */
|
||
void _initialize_i386obsd_tdep (void);
|
||
|
||
void
|
||
_initialize_i386obsd_tdep (void)
|
||
{
|
||
/* FIXME: kettenis/20021020: Since OpenBSD/i386 binaries are
|
||
indistingushable from NetBSD/i386 a.out binaries, building a GDB
|
||
that should support both these targets will probably not work as
|
||
expected. */
|
||
#define GDB_OSABI_OPENBSD_AOUT GDB_OSABI_NETBSD_AOUT
|
||
|
||
gdbarch_register_osabi (bfd_arch_i386, 0, GDB_OSABI_OPENBSD_AOUT,
|
||
i386obsd_aout_init_abi);
|
||
gdbarch_register_osabi (bfd_arch_i386, 0, GDB_OSABI_OPENBSD_ELF,
|
||
i386obsd_elf_init_abi);
|
||
}
|