forked from Imagelibrary/binutils-gdb
This commit adds a new option to "info breakpoints", "-hide-locations". It's purpose is to tell GDB to skip printing breakpoint locations, printing only the breakpoint header rows. And then, since only code breakpoint locations print anything in the "Address" column, "-hide-breakpoints" also disables the "Address" column. For example, when debugging GDB, you can use the new options to get this: (top-gdb) i b -h Num Type Disp Enb What 1 breakpoint keep y internal_error 2 breakpoint keep y info_command silent return 3 breakpoint keep y main breakpoint already hit 1 time 4 breakpoint keep y error (top-gdb) instead of: (top-gdb) i b Num Type Disp Enb Address What 1 breakpoint keep y internal_error 1.1 y 0x0000555555f81d12 in internal_error(char const*, int, char const*, ...) at /home/pedro/gdb/binutils-gdb/src/gdbsupport/errors.cc:51 2 breakpoint keep y info_command silent return 2.1 y 0x00005555557b3097 in info_command(char const*, int) at /home/pedro/gdb/binutils-gdb/src/gdb/cli/cli-cmds.c:217 3 breakpoint keep y main breakpoint already hit 1 time 3.1 y 0x000055555564106c in main(int, char**) at /home/pedro/gdb/binutils-gdb/src/gdb/gdb.c:25 3.2 y 0x0000555555dba524 in selftests::string_view::capacity_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/capacity/1.cc:167 3.3 y 0x0000555555dba943 in selftests::string_view::cons_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/cons/char/1.cc:62 3.4 y 0x0000555555dbaa34 in selftests::string_view::cons_2::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/cons/char/2.cc:41 3.5 y 0x0000555555dbaa9a in selftests::string_view::cons_3::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/cons/char/3.cc:34 3.6 y 0x0000555555dbac6b in selftests::string_view::element_access_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/element_access/char/1.cc:66 3.7 y 0x0000555555dbac83 in selftests::string_view::element_access_empty::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/element_access/char/empty.cc:25 3.8 y 0x0000555555dbae91 in selftests::string_view::element_access_front_back::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/element_access/char/front_back.cc:38 3.9 y 0x0000555555dbb2bd in selftests::string_view::inserters_2::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/inserters/char/2.cc:84 3.10 y 0x0000555555dbb429 in selftests::string_view::modifiers_remove_prefix::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:58 3.11 y 0x0000555555dbb575 in selftests::string_view::modifiers_remove_suffix::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:58 3.12 y 0x0000555555dbbd38 in selftests::string_view::operations_compare_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/compare/char/1.cc:127 3.13 y 0x0000555555dbbe7b in selftests::string_view::operations_compare_13650::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/compare/char/13650.cc:45 3.14 y 0x0000555555dbbf6a in selftests::string_view::operations_copy_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/copy/char/1.cc:41 3.15 y 0x0000555555dbc03b in selftests::string_view::operations_data_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/data/char/1.cc:39 3.16 y 0x0000555555dbc5fe in selftests::string_view::operations_find_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/find/char/1.cc:160 3.17 y 0x0000555555dbcb60 in selftests::string_view::operations_find_2::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/find/char/2.cc:158 3.18 y 0x0000555555dbd1c1 in selftests::string_view::operations_find_3::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/find/char/3.cc:158 3.19 y 0x0000555555dbd26c in selftests::string_view::operations_find_4::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/find/char/4.cc:40 3.20 y 0x0000555555dbd83f in selftests::string_view::operations_rfind_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/rfind/char/1.cc:90 3.21 y 0x0000555555dbda98 in selftests::string_view::operations_rfind_2::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/rfind/char/2.cc:48 3.22 y 0x0000555555dbde4c in selftests::string_view::operations_rfind_3::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/rfind/char/3.cc:63 3.23 y 0x0000555555dbe189 in selftests::string_view::operations_substr_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operations/substr/char/1.cc:74 3.24 y 0x0000555555dbffdb in selftests::string_view::operators_2::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/operators/char/2.cc:366 4 breakpoint keep y error 4.1 y 0x00005555557f5142 in gcc_c_plugin::error(char const*) const at /home/pedro/gdb/binutils-gdb/src/gdb/../include/gcc-c-fe.def:198 4.2 y 0x00005555557fe1f4 in gcc_cp_plugin::error(char const*) const at /home/pedro/gdb/binutils-gdb/src/gdb/../include/gcc-cp-fe.def:983 4.3 y 0x0000555555f81c5e in error(char const*, ...) at /home/pedro/gdb/binutils-gdb/src/gdbsupport/errors.cc:39 4.4 y 0x00007ffff65ee4e0 <icu_66::RBBIRuleScanner::error(UErrorCode)> 4.5 y 0x00007ffff685e070 <icu_66::RegexCompile::error(UErrorCode)> 4.6 y 0x00007ffff6cd4e86 in error at /usr/include/x86_64-linux-gnu/bits/error.h:40 4.7 y 0x00007ffff71c2190 in __error at error.c:274 Documentation change included. No testsuite changes yet until there's agreement on the previous patch. Change-Id: Ic42ad8565e79ca67bfebb22cbb4794ea816fd08b
225 lines
6.1 KiB
C
225 lines
6.1 KiB
C
/* Everything about exec catchpoints, for GDB.
|
|
|
|
Copyright (C) 1986-2022 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
|
|
#include "annotate.h"
|
|
#include "arch-utils.h"
|
|
#include "breakpoint.h"
|
|
#include "cli/cli-decode.h"
|
|
#include "inferior.h"
|
|
#include "mi/mi-common.h"
|
|
#include "target.h"
|
|
#include "valprint.h"
|
|
|
|
/* Exec catchpoints. */
|
|
|
|
/* An instance of this type is used to represent an exec catchpoint.
|
|
A breakpoint is really of this type iff its ops pointer points to
|
|
CATCH_EXEC_BREAKPOINT_OPS. */
|
|
|
|
struct exec_catchpoint : public catchpoint
|
|
{
|
|
exec_catchpoint (struct gdbarch *gdbarch, bool temp, const char *cond_string)
|
|
: catchpoint (gdbarch, temp, cond_string)
|
|
{
|
|
}
|
|
|
|
int insert_location (struct bp_location *) override;
|
|
int remove_location (struct bp_location *,
|
|
enum remove_bp_reason reason) override;
|
|
int breakpoint_hit (const struct bp_location *bl,
|
|
const address_space *aspace,
|
|
CORE_ADDR bp_addr,
|
|
const target_waitstatus &ws) override;
|
|
enum print_stop_action print_it (const bpstat *bs) const override;
|
|
bool print_one (bp_location **, bool) const override;
|
|
void print_mention () const override;
|
|
void print_recreate (struct ui_file *fp) const override;
|
|
|
|
/* Filename of a program whose exec triggered this catchpoint.
|
|
This field is only valid immediately after this catchpoint has
|
|
triggered. */
|
|
gdb::unique_xmalloc_ptr<char> exec_pathname;
|
|
};
|
|
|
|
int
|
|
exec_catchpoint::insert_location (struct bp_location *bl)
|
|
{
|
|
return target_insert_exec_catchpoint (inferior_ptid.pid ());
|
|
}
|
|
|
|
int
|
|
exec_catchpoint::remove_location (struct bp_location *bl,
|
|
enum remove_bp_reason reason)
|
|
{
|
|
return target_remove_exec_catchpoint (inferior_ptid.pid ());
|
|
}
|
|
|
|
int
|
|
exec_catchpoint::breakpoint_hit (const struct bp_location *bl,
|
|
const address_space *aspace,
|
|
CORE_ADDR bp_addr,
|
|
const target_waitstatus &ws)
|
|
{
|
|
if (ws.kind () != TARGET_WAITKIND_EXECD)
|
|
return 0;
|
|
|
|
exec_pathname = make_unique_xstrdup (ws.execd_pathname ());
|
|
return 1;
|
|
}
|
|
|
|
enum print_stop_action
|
|
exec_catchpoint::print_it (const bpstat *bs) const
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
|
|
annotate_catchpoint (number);
|
|
maybe_print_thread_hit_breakpoint (uiout);
|
|
if (disposition == disp_del)
|
|
uiout->text ("Temporary catchpoint ");
|
|
else
|
|
uiout->text ("Catchpoint ");
|
|
if (uiout->is_mi_like_p ())
|
|
{
|
|
uiout->field_string ("reason", async_reason_lookup (EXEC_ASYNC_EXEC));
|
|
uiout->field_string ("disp", bpdisp_text (disposition));
|
|
}
|
|
uiout->field_signed ("bkptno", number);
|
|
uiout->text (" (exec'd ");
|
|
uiout->field_string ("new-exec", exec_pathname.get ());
|
|
uiout->text ("), ");
|
|
|
|
return PRINT_SRC_AND_LOC;
|
|
}
|
|
|
|
bool
|
|
exec_catchpoint::print_one (bp_location **last_loc,
|
|
bool print_address_col) const
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
|
|
/* Field 4, the address, is omitted (which makes the columns
|
|
not line up too nicely with the headers, but the effect
|
|
is relatively readable). */
|
|
if (print_address_col)
|
|
uiout->field_skip ("addr");
|
|
annotate_field (5);
|
|
uiout->text ("exec");
|
|
if (exec_pathname != NULL)
|
|
{
|
|
uiout->text (", program \"");
|
|
uiout->field_string ("what", exec_pathname.get ());
|
|
uiout->text ("\" ");
|
|
}
|
|
|
|
if (uiout->is_mi_like_p ())
|
|
uiout->field_string ("catch-type", "exec");
|
|
|
|
return true;
|
|
}
|
|
|
|
void
|
|
exec_catchpoint::print_mention () const
|
|
{
|
|
gdb_printf (_("Catchpoint %d (exec)"), number);
|
|
}
|
|
|
|
/* Implement the "print_recreate" method for exec catchpoints. */
|
|
|
|
void
|
|
exec_catchpoint::print_recreate (struct ui_file *fp) const
|
|
{
|
|
gdb_printf (fp, "catch exec");
|
|
print_recreate_thread (fp);
|
|
}
|
|
|
|
/* This function attempts to parse an optional "if <cond>" clause
|
|
from the arg string. If one is not found, it returns NULL.
|
|
|
|
Else, it returns a pointer to the condition string. (It does not
|
|
attempt to evaluate the string against a particular block.) And,
|
|
it updates arg to point to the first character following the parsed
|
|
if clause in the arg string. */
|
|
|
|
const char *
|
|
ep_parse_optional_if_clause (const char **arg)
|
|
{
|
|
const char *cond_string;
|
|
|
|
if (((*arg)[0] != 'i') || ((*arg)[1] != 'f') || !isspace ((*arg)[2]))
|
|
return NULL;
|
|
|
|
/* Skip the "if" keyword. */
|
|
(*arg) += 2;
|
|
|
|
/* Skip any extra leading whitespace, and record the start of the
|
|
condition string. */
|
|
*arg = skip_spaces (*arg);
|
|
cond_string = *arg;
|
|
|
|
/* Assume that the condition occupies the remainder of the arg
|
|
string. */
|
|
(*arg) += strlen (cond_string);
|
|
|
|
return cond_string;
|
|
}
|
|
|
|
/* Commands to deal with catching events, such as signals, exceptions,
|
|
process start/exit, etc. */
|
|
|
|
static void
|
|
catch_exec_command_1 (const char *arg, int from_tty,
|
|
struct cmd_list_element *command)
|
|
{
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
const char *cond_string = NULL;
|
|
bool temp = command->context () == CATCH_TEMPORARY;
|
|
|
|
if (!arg)
|
|
arg = "";
|
|
arg = skip_spaces (arg);
|
|
|
|
/* The allowed syntax is:
|
|
catch exec
|
|
catch exec if <cond>
|
|
|
|
First, check if there's an if clause. */
|
|
cond_string = ep_parse_optional_if_clause (&arg);
|
|
|
|
if ((*arg != '\0') && !isspace (*arg))
|
|
error (_("Junk at end of arguments."));
|
|
|
|
std::unique_ptr<exec_catchpoint> c
|
|
(new exec_catchpoint (gdbarch, temp, cond_string));
|
|
|
|
install_breakpoint (0, std::move (c), 1);
|
|
}
|
|
|
|
void _initialize_break_catch_exec ();
|
|
void
|
|
_initialize_break_catch_exec ()
|
|
{
|
|
add_catch_command ("exec", _("Catch calls to exec."),
|
|
catch_exec_command_1,
|
|
NULL,
|
|
CATCH_PERMANENT,
|
|
CATCH_TEMPORARY);
|
|
}
|