forked from Imagelibrary/binutils-gdb
e61c7092f7
Currently, when a user tries to list the current location, there are 2
different error messages that can happen, either:
(gdb) list .
No symbol table is loaded. Use the "file" command.
or
(gdb) list .
No debug information available to print source lines.
The difference here is if gdb can find any symtabs at all or not, which
is not something too important for end-users - and isn't informative at
all. This commit changes it so that the error always says that there
isn't debug information available, with these two variants:
(gdb) list .
Insufficient debug info for showing source lines at current PC (0x55555555511d).
or
(gdb) list .
Insufficient debug info for showing source lines at default location.
The difference now is if the inferior has started already, which is
controlled by the user and may be useful.
Unfortunately, it isn't as easy to differentiate if the symtab found for
other list parameters is correct, so other invocations, such as "list +"
still retain their original error message.
Co-Authored-By: Simon Marchi <simark@simark.ca>
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Approved-By: Andrew Burgess <aburgess@redhat.com>
41 lines
1.4 KiB
Plaintext
41 lines
1.4 KiB
Plaintext
# Copyright 2024 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test that using the command "list" in a file with no debug information
|
|
# will not crash GDB and will give reasonable output.
|
|
|
|
standard_testfile .c -2.c
|
|
|
|
if { [prepare_for_testing_full "failed to prepare" \
|
|
[list \
|
|
$testfile {} \
|
|
$srcfile {nodebug} \
|
|
$srcfile2 {debug}]] } {
|
|
return -1
|
|
}
|
|
|
|
if {![runto_main]} {
|
|
untested "couldn't run to main"
|
|
return
|
|
}
|
|
|
|
# Check that GDB doesn't crash when we use list . on an inferior with
|
|
# no debug information
|
|
gdb_test "list ." "Insufficient debug.*" "first 'list .'"
|
|
# This should be called twice because the first list invocation since
|
|
# printing a frame may take a different codepath, which wouldn't
|
|
# trigger the crash.
|
|
gdb_test "list ." "Insufficient debug.*" "second 'list .'"
|