forked from Imagelibrary/binutils-gdb
03ad29c86c
This commit changes the 'target ...' commands that accept a filename to take a quoted or escaped filename rather than a literal filename. What this means in practice is that if you are specifying a filename that contains no white space or quote characters, then nothing should change, e.g.: target exec /path/to/some/file works both before and after this commit. However, if a user wishes to specify a file containing white space then either the entire filename needs to be quoted, or the special white space needs to be escaped. Before this patch a user could write: target exec /path/to a file/containing spaces But after this commit the user would have to choose one of: target exec "/path/to a file/containing spaces" or target exec /path/to\ a\ file/containing\ spaces Obviously this is a potentially breaking change. The benefit of making this change is consistency. Commands that take multiple arguments (one of which is a filename) or in the future, commands that take filename options, will always need to use quoted/escaped filenames, so converting all unquoted filename commands to use quoting or escaping makes the UI more consistent. Additionally (though this is probably not a common problem), GDB strips trailing white space from commands that the user enters. As such it is not possible to reference any file that ends in white space unless the quoting / escaping style is used. Though I suspect very few users run into this problem! The downside obviously is that this is a UI breaking change. Reviewed-By: Eli Zaretskii <eliz@gnu.org>
97 lines
3.1 KiB
Plaintext
97 lines
3.1 KiB
Plaintext
# Copyright (C) 2018-2024 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Check that "gdb -batch" exits with appropriate status.
|
|
|
|
standard_testfile
|
|
|
|
set good_commands "$srcdir/$subdir/batch-exit-status.good-commands"
|
|
set bad_commands "$srcdir/$subdir/batch-exit-status.bad-commands"
|
|
|
|
proc _test_exit_status {expect_status cmdline_opts {re ""}} {
|
|
global gdb_spawn_id
|
|
|
|
gdb_exit
|
|
if {[gdb_spawn_with_cmdline_opts $cmdline_opts] != 0} {
|
|
fail "spawn"
|
|
return
|
|
}
|
|
|
|
set has_re [expr ![string equal $re ""]]
|
|
if { ! $has_re } {
|
|
set re "\$FOOBAR^"
|
|
}
|
|
set re_matched 0
|
|
gdb_test_multiple "" "run til exit" {
|
|
-re $re {
|
|
set re_matched 1
|
|
exp_continue
|
|
}
|
|
eof {
|
|
set result [wait -i $gdb_spawn_id]
|
|
verbose $result
|
|
|
|
gdb_assert { [lindex $result 2] == 0 }
|
|
gdb_assert { [lindex $result 3] == $expect_status }
|
|
|
|
remote_close host
|
|
clear_gdb_spawn_id
|
|
}
|
|
}
|
|
if { $has_re } {
|
|
gdb_assert { $re_matched } "output matched"
|
|
}
|
|
}
|
|
|
|
proc test_exit_status {expect_status cmdline_opts prefix args} {
|
|
if { $prefix == "" } {
|
|
set prefix $cmdline_opts
|
|
}
|
|
|
|
with_test_prefix $prefix {
|
|
_test_exit_status $expect_status $cmdline_opts {*}$args
|
|
}
|
|
}
|
|
|
|
# gdb -batch with nothing to do should exit 0.
|
|
test_exit_status 0 "-batch" ""
|
|
|
|
# Bad command-line options should cause exit 1.
|
|
test_exit_status 1 "-batch -jslkflsdjlkfjlksdjf" ""
|
|
|
|
# gdb -batch with good commands should exit 0.
|
|
test_exit_status 0 "-batch -ex \"info source\"" ""
|
|
test_exit_status 0 "-batch -x $good_commands" "-batch -x good-commands"
|
|
|
|
# gdb -batch with bad commands should exit 1.
|
|
test_exit_status 1 "-batch -ex \"set not-a-thing 4\"" ""
|
|
test_exit_status 1 "-batch -x $bad_commands" "-batch -x bad-commands"
|
|
|
|
# Success or failure of the last thing determines the exit code.
|
|
test_exit_status 0 "-batch -ex \"set not-a-thing 4\" -x $good_commands" \
|
|
"-batch -ex \"set not-a-thing 4\" -x good-commands"
|
|
test_exit_status 0 "-batch -x $bad_commands -ex \"info source\"" \
|
|
"-batch -x bad-commands -ex \"info source\""
|
|
test_exit_status 1 "-batch -x $good_commands -x $bad_commands" \
|
|
"-batch -x good-commands -x bad-commands"
|
|
test_exit_status 1 "-batch -x $good_commands -ex \"set not-a-thing 4\"" \
|
|
"-batch -x good-commands -ex \"set not-a-thing 4\""
|
|
|
|
set test "No such file or directory"
|
|
set no_such_re ": $test\\."
|
|
test_exit_status 1 "-batch \"\"" "1x: $test" ^[multi_line $no_such_re ""]$
|
|
test_exit_status 1 "-batch \"\" \"\"" "$test and No core file specified" \
|
|
^[multi_line $no_such_re "No core file specified\\." ""]$
|