Tom Tromey 0c8a0b88d1 Re-acquire GIL earlier in gdbpy_parse_and_eval ...

Tom de Vries filed a bug about an intermittent gdb DAP failure -- and
coincidentally, at the same time, Alexandra Hájková sent email about a
somewhat similar failure.

After looking into this for a while (with no results) using ASan and
valgrind, I found that setting PYTHONMALLOC=malloc_debug found the bug
instantly.

The problem is that gdbpy_parse_and_eval releases the GIL while
calling parse_and_eval, but fails to re-acquire it before calling
value_to_value_object.  This is easily fixed by introducing a new
scope.

I wonder whether the test suite should unconditionally set
PYTHONMALLOC=malloc_debug.

Tested-by: Tom de Vries <tdevries@suse.de>
Reviewed-By: Tom de Vries <tdevries@suse.de>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30686

2023-07-28 06:15:30 -06:00

..

lib/gdb

Report supportsBreakpointLocationsRequest

2023-07-27 10:35:00 -06:00

py-all-events.def

gdb/Python: Added ThreadExitedEvent

2023-06-19 16:17:21 +02:00

py-arch.c

gdb: add __repr__() implementation to a few Python types

2023-07-04 12:07:16 +01:00

py-auto-load.c

…

py-block.c

gdb: add __repr__() implementation to a few Python types

2023-07-04 12:07:16 +01:00

py-bpevent.c

…

py-breakpoint.c

gdb: add __repr__() implementation to a few Python types

2023-07-04 12:07:16 +01:00

py-cmd.c

…

py-connection.c

…

py-continueevent.c

…

py-dap.c

…

py-disasm.c

Fix two Python calls that don't check for errors

2023-07-03 11:35:18 -06:00

py-event-types.def

gdb/Python: Added ThreadExitedEvent

2023-06-19 16:17:21 +02:00

py-event.c

…

py-event.h

gdb/Python: Added ThreadExitedEvent

2023-06-19 16:17:21 +02:00

py-events.h

…

py-evtregistry.c

…

py-evts.c

…

py-exitedevent.c

…

py-finishbreakpoint.c

…

py-frame.c

…

py-framefilter.c

…

py-function.c

…

py-gdb-readline.c

…

py-inferior.c

Fix gdb.Inferior.read_memory without execution (PR dap/30644)

2023-07-19 14:10:19 +01:00

py-infevents.c

…

py-infthread.c

…

py-instruction.c

…

py-instruction.h

…

py-lazy-string.c

…

py-linetable.c

…

py-membuf.c

…

py-mi.c

…

py-micmd.c

Use unique_xmalloc_ptr for mi_parse::command

2023-06-20 06:23:30 -06:00

py-newobjfileevent.c

…

py-objfile.c

…

py-param.c

…

py-prettyprint.c

…

py-progspace.c

Add Progspace.objfile_for_address

2023-07-21 12:05:30 -06:00

py-record-btrace.c

…

py-record-btrace.h

…

py-record-full.c

…

py-record-full.h

…

py-record.c

…

py-record.h

…

py-ref.h

…

py-registers.c

…

py-signalevent.c

…

py-stopevent.c

…

py-stopevent.h

…

py-symbol.c

gdb: add __repr__() implementation to a few Python types

2023-07-04 12:07:16 +01:00

py-symtab.c

…

py-threadevent.c

gdb/Python: Added ThreadExitedEvent

2023-06-19 16:17:21 +02:00

py-tui.c

[gdb/tui] Fix assert in ~gdbpy_tui_window_maker

2023-07-26 12:29:28 +02:00

py-type.c

Fix typo in py-type.c docstring

2023-07-21 10:33:07 -06:00

py-unwind.c

…

py-utils.c

…

py-value.c

Add gdb.Value.assign method

2023-06-12 12:09:39 -06:00

py-varobj.c

…

py-xmethods.c

…

python-config.py

…

python-internal.h

…

python.c

Re-acquire GIL earlier in gdbpy_parse_and_eval

2023-07-28 06:15:30 -06:00

python.h

…