forked from Imagelibrary/binutils-gdb
In AIX when a thread exits we were not showing that a thread exit event happened and GDB continued to keep the terminated threads. If we have terminated threads then the UI on info threads command will look like (gdb) info threads Id Target Id Frame * 1 Thread 1 (tid 26607979, running) 0xd0611d70 in _p_nsleep () from /usr/lib/libpthreads.a(_shr_xpg5.o) 2 Thread 258 (tid 30998799, finished) aix-thread: ptrace (52, 30998799) returned -1 (errno = 3 The process does not exist.) If we see the frame is not getting displayed correctly. The reason for the same is that in AIX we were not managing thread states. In particular we do not know when a thread terminates. The reason being in sync_threadlists () the pbuf and gbuf lists remain the same though certain threads exit. This patch is a fix to the same. Also certain UI is changed. On a new thread born and exit the UI in AIX will be similar to Linux with both user and kernel thread information. [New Thread 258 (tid 32178533)] [New Thread 515 (tid 30343651)] [New Thread 772 (tid 33554909)] [New Thread 1029 (tid 24969489)] [New Thread 1286 (tid 18153945)] [New Thread 1543 (tid 30736739)] [Thread 258 (tid 32178533) exited] [Thread 515 (tid 30343651) exited] [Thread 772 (tid 33554909) exited] [Thread 1029 (tid 24969489) exited] [Thread 1286 (tid 18153945) exited] [Thread 1543 (tid 30736739) exited] and info threads will look like (gdb) info threads Id Target Id Frame * 1 Thread 1 (tid 31326579) ([running]) 0xd0611d70 in _p_nsleep () from /usr/lib/libpthread.a(_shr_xpg5.o) Also a small change to testcase gdb.threads/thread_events.exp to make sure this test runs on AIX as well.
143 lines
4.1 KiB
Plaintext
143 lines
4.1 KiB
Plaintext
# Copyright (C) 2007-2024 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file was written by Chris Demetriou (cgd@google.com).
|
|
# It tests printing of thread event (start, exit) information, and
|
|
# disabling of those messages.
|
|
#
|
|
# Note: the format of thread event messages (and also whether or not
|
|
# messages are printed and can be disabled) is dependent on the target
|
|
# thread support code.
|
|
|
|
# This test has been verified with Linux targets and AIX target, and would need
|
|
# to be generalized to support other targets
|
|
require {is_any_target "*-*-linux*" "*-*-aix*"}
|
|
|
|
# When using the RSP, we don't get notifications about new threads.
|
|
# This is expected, so don't test for that.
|
|
if {[target_info gdb_protocol] == "remote"
|
|
|| [target_info gdb_protocol] == "extended-remote"} {
|
|
return
|
|
}
|
|
|
|
|
|
standard_testfile
|
|
|
|
if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable debug] != "" } {
|
|
return -1
|
|
}
|
|
|
|
proc gdb_test_thread_start {messages_enabled command pattern message} {
|
|
global gdb_prompt
|
|
|
|
if { $messages_enabled } {
|
|
set events_expected 1
|
|
} else {
|
|
set events_expected 0
|
|
}
|
|
set events_seen 0
|
|
|
|
return [gdb_test_multiple $command $message {
|
|
-re "\\\[New Thread \[^\]\]*\\\]\r\n" {
|
|
incr events_seen
|
|
exp_continue
|
|
}
|
|
-re "\[\r\n\]*($pattern)\[\r\n\]+$gdb_prompt $" {
|
|
if { $events_seen != $events_expected } {
|
|
fail "$message (saw $events_seen, expected $events_expected)"
|
|
} else {
|
|
pass "$message"
|
|
}
|
|
}
|
|
}]
|
|
}
|
|
|
|
proc gdb_test_thread_exit {messages_enabled command pattern message} {
|
|
global gdb_prompt
|
|
|
|
if { $messages_enabled } {
|
|
set events_expected 1
|
|
} else {
|
|
set events_expected 0
|
|
}
|
|
set events_seen 0
|
|
|
|
return [gdb_test_multiple $command $message {
|
|
-re "\\\[Thread \[^\]\]* exited\\\]\r\n" {
|
|
incr events_seen
|
|
exp_continue
|
|
}
|
|
-re "\[\r\n\]*($pattern)\[\r\n\]+$gdb_prompt $" {
|
|
if { $events_seen != $events_expected } {
|
|
fail "$message (saw $events_seen, expected $events_expected)"
|
|
} else {
|
|
pass "$message"
|
|
}
|
|
}
|
|
}]
|
|
}
|
|
|
|
proc test_thread_messages {enabled} {
|
|
global srcdir subdir binfile srcfile
|
|
|
|
if { $enabled } {
|
|
set enabled_string "with messages enabled"
|
|
} else {
|
|
set enabled_string "with messages disabled"
|
|
}
|
|
|
|
gdb_start
|
|
gdb_reinitialize_dir $srcdir/$subdir
|
|
gdb_load ${binfile}
|
|
|
|
if { $enabled } {
|
|
gdb_test "set print thread-events on"
|
|
} else {
|
|
gdb_test "set print thread-events off"
|
|
}
|
|
|
|
# The initial thread may log a 'New Thread' message, but we don't
|
|
# check for it.
|
|
if {![runto_main]} {
|
|
return 1
|
|
}
|
|
|
|
gdb_test "break threadfunc" \
|
|
"Breakpoint.*at.* file .*$srcfile, line.*" \
|
|
"breakpoint at threadfunc $enabled_string"
|
|
gdb_test "break after_join_func" \
|
|
"Breakpoint.*at.* file .*$srcfile, line.*" \
|
|
"breakpoint at after_join_func $enabled_string"
|
|
|
|
# continue to threadfunc breakpoint. A thread will start.
|
|
# Expect to see a thread start message, if messages are enabled.
|
|
gdb_test_thread_start $enabled "continue" \
|
|
".*Breakpoint .*,.*threadfunc.*at.*$srcfile:.*" \
|
|
"continue to threadfunc $enabled_string"
|
|
|
|
# continue to after_join_func breakpoint. A thread will exit.
|
|
# Expect to see a thread exit message, if messages are enabled.
|
|
gdb_test_thread_exit $enabled "continue" \
|
|
".*Breakpoint .*,.*after_join_func.*at.*$srcfile:.*" \
|
|
"continue to after_join_func $enabled_string"
|
|
|
|
delete_breakpoints
|
|
|
|
gdb_exit
|
|
}
|
|
|
|
test_thread_messages 0
|
|
test_thread_messages 1
|