forked from Imagelibrary/binutils-gdb
49e607f511
The 'list' command prints around the 'main' function if the current
source location is not set. The prologue of 'main' is skipped and the
first real line of 'main' is offset by 'lines_to_print - 1'. This is
incorrect, the location should be defaulted to main's prologue without
applying offsets (similar to 'list main'). Printing around the selected
line is then done in 'list_around_line'.
The patch also fixes an issue if the list command is used before the
program is started. For example, with the following code:
26 static void attribute ((used)) ambiguous_fun (void) {}
27
28 static int attribute ((used)) ambiguous_var;
29
30
31
32
33
34
35
36
37
38 int
39 main (void)
40 {
41 return 0;
42 }
GDB offsets the relevant line by 'lines_to_print - 1' and then by another
'lines_to_print / 2' and prints:
(gdb) list
27
28 static int attribute ((used)) ambiguous_var;
29
30
31
32
33
34
35
36
With this patch, GDB correctly prints:
37
38 int
39 main (void)
40 {
41 return 0;
42 }
Approved-By: Andrew Burgess <aburgess@redhat.com>
66 lines
1.5 KiB
Plaintext
66 lines
1.5 KiB
Plaintext
# Copyright 2004-2024 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
standard_testfile
|
|
|
|
if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != ""} {
|
|
untested "failed to compile"
|
|
return -1
|
|
}
|
|
|
|
clean_restart
|
|
gdb_file_cmd ${binfile}
|
|
gdb_test_no_output "set listsize 1"
|
|
|
|
# initial sal should be main's prologue.
|
|
gdb_test "list" \
|
|
"{ /\\* main prologue \\*/" \
|
|
"list before run"
|
|
|
|
gdb_load ${binfile}
|
|
if {! [runto_main]} {
|
|
return -1
|
|
}
|
|
|
|
gdb_test "list" \
|
|
"v0 = 0;" \
|
|
"list in main"
|
|
|
|
if {! [runto "func2"]} {
|
|
return -1
|
|
}
|
|
|
|
gdb_test "list" \
|
|
"v2 = 2;" \
|
|
"list in func2"
|
|
|
|
# make sure backtrace doesn't change current source location.
|
|
gdb_test "backtrace" \
|
|
".*"
|
|
gdb_test "list -1" \
|
|
"v2 = 2;" \
|
|
"list after backtrace"
|
|
|
|
# check the window
|
|
gdb_test_no_output "set listsize 3"
|
|
|
|
if {! [runto_main]} {
|
|
return -1
|
|
}
|
|
gdb_test "list" \
|
|
"func1 \\(\\);" \
|
|
"list size 3"
|