forked from Imagelibrary/binutils-gdb
89e59ca6dc
bfd_canonicalize_symtab stores the symbols in the BFD, and returns pointers to these. The ELF reader does not reuse these stored symbols, so each call to bfd_canonicalize_symtab causes an allocation. This interacts poorly with code like arm_pikeos_osabi_sniffer, which searches the BFD symbol when called. PR gdb/32758 points out a particularly pathological case: using "maint info sections" on a program with a large number of sections (10000) will cause 10000 calls to arm_pikeos_osabi_sniffer, allocating 20G. I'm not sure BFD always worked this way. And, fixing BFD was an option. However it seemed maybe better for GDB to adapt, since adapting would mean that the fix would apply to all BFD back ends, and not just ELF. To that end, this patch adds a new gdb_bfd_canonicalize_symtab and changes all callers of bfd_canonicalize_symtab to use it instead. This new function caches the result in the per-BFD object. I looked into having this return a view of "const asymbol *". However both the compile module and machoread modify the returned symbols. And while I think this is wrong, I haven't tried to fix this here. Regression tested on x86-64 Fedora 40. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32758
92 lines
2.8 KiB
C
92 lines
2.8 KiB
C
/* Target-dependent, architecture-independent code for DICOS, for GDB.
|
|
|
|
Copyright (C) 2009-2024 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "osabi.h"
|
|
#include "solib.h"
|
|
#include "solib-target.h"
|
|
#include "inferior.h"
|
|
#include "dicos-tdep.h"
|
|
#include "gdbarch.h"
|
|
|
|
void
|
|
dicos_init_abi (struct gdbarch *gdbarch)
|
|
{
|
|
set_gdbarch_so_ops (gdbarch, &solib_target_so_ops);
|
|
|
|
/* Every process, although has its own address space, sees the same
|
|
list of shared libraries. There's no "main executable" in DICOS,
|
|
so this accounts for all code. */
|
|
set_gdbarch_has_global_solist (gdbarch, 1);
|
|
|
|
/* The DICOS breakpoint API takes care of magically making
|
|
breakpoints visible to all inferiors. */
|
|
set_gdbarch_has_global_breakpoints (gdbarch, 1);
|
|
|
|
/* There's no (standard definition of) entry point or a guaranteed
|
|
text location with a symbol where to place the call dummy, so we
|
|
need it on the stack. Rely on i386_gdbarch_init used also for
|
|
amd64 to set up ON_STACK inferior calls. */
|
|
|
|
/* DICOS rewinds the PC itself. */
|
|
set_gdbarch_decr_pc_after_break (gdbarch, 0);
|
|
}
|
|
|
|
/* Return true if ABFD is a dicos load module. HEADER_SIZE is the
|
|
expected size of the "header" section in bytes. */
|
|
|
|
int
|
|
dicos_load_module_p (bfd *abfd, int header_size)
|
|
{
|
|
int ret = 0;
|
|
const char *symname = "Dicos_loadModuleInfo";
|
|
asection *section;
|
|
|
|
/* DICOS files don't have a .note.ABI-tag marker or something
|
|
similar. We do know there's always a "header" section of
|
|
HEADER_SIZE bytes (size depends on architecture), and there's
|
|
always a "Dicos_loadModuleInfo" symbol defined. Look for the
|
|
section first, as that should be cheaper. */
|
|
|
|
section = bfd_get_section_by_name (abfd, "header");
|
|
if (!section)
|
|
return 0;
|
|
|
|
if (bfd_section_size (section) != header_size)
|
|
return 0;
|
|
|
|
/* Dicos LMs always have a "Dicos_loadModuleInfo" symbol
|
|
defined. Look for it. */
|
|
|
|
gdb::array_view<asymbol *> symbol_table
|
|
= gdb_bfd_canonicalize_symtab (abfd, false);
|
|
|
|
for (asymbol *sym : symbol_table)
|
|
{
|
|
if (sym->name != NULL
|
|
&& symname[0] == sym->name[0]
|
|
&& strcmp (symname + 1, sym->name + 1) == 0)
|
|
{
|
|
ret = 1;
|
|
break;
|
|
}
|
|
}
|
|
|
|
return ret;
|
|
}
|