Files
binutils-gdb/gdb/testsuite/gdb.ada/dyn-bit-offset.exp
Tom de Vries bd52f6f48c [gdb/testsuite] Fix gdb.ada/dyn-bit-offset.exp on s390x
On s390x-linux, with test-case gdb.ada/dyn-bit-offset.exp and gcc 7.5.0 I get:
...
(gdb) print spr^M
$1 = (discr => 3, array_field => (-5, -6, -7), field => -6, another_field => -6)^M
(gdb) FAIL: $exp: print spr
print spr.field^M
$2 = -6^M
(gdb) FAIL: $exp: print spr.field
...

On x86_64-linux, with the same compiler version I get:
...
(gdb) print spr^M
$1 = (discr => 3, array_field => (-5, -6, -7), field => -4, another_field => -4)^M
(gdb) XFAIL: $exp: print spr
print spr.field^M
$2 = -4^M
(gdb) PASS: $exp: print spr.field
...

In both cases, we're hitting the same compiler problem, but it manifests
differently on little and big endian.

Make sure the values seen for both little and big endian trigger xfails
for both tests.

Printing spr.field gives the expected value -4 for x86_64, but that's an
accident.  Change the actual spr.field value to -5, to make sure
that we get the same number of xfails on x86_64 and s390x.

Finally, make the xfails conditional on the compiler version.

Tested using gcc 7.5.0 on both x86_64-linux and s390x-linux.

Approved-By: Andrew Burgess <aburgess@redhat.com>

PR testsuite/33042
https://sourceware.org/bugzilla/show_bug.cgi?id=33042
2025-06-07 13:59:52 +02:00

80 lines
2.2 KiB
Plaintext

# Copyright 2025 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
load_lib "ada.exp"
require allow_ada_tests
standard_ada_testfile exam
set flags {debug}
if {[ada_minimal_encodings]} {
lappend flags additional_flags=-fgnat-encodings=minimal
}
if {[gdb_compile_ada "${srcfile}" "${binfile}" executable $flags] != ""} {
return -1
}
# GCC needs to have fixes:
# - 809b46d2ccc ("Partially lift restriction from loc_list_from_tree_1")
# - d7f24e37d4b ("Fix oversight about big-endian targets in latest change")
set have_xfail [gnat_version_compare <= {16 1}]
clean_restart ${testfile}
set bp_location [gdb_get_line_number "STOP" ${testdir}/exam.adb]
runto "exam.adb:$bp_location"
set re_pass \
[string_to_regexp \
" = (discr => 3, array_field => (-5, -6, -7), field => -5, another_field => -6)"]
set re_xfail_le \
[string_to_regexp \
" = (discr => 3, array_field => (-5, -6, -7), field => -4, another_field => -4)"]
set re_xfail_be \
[string_to_regexp \
" = (discr => 3, array_field => (-5, -6, -7), field => -6, another_field => -6)"]
gdb_test_multiple "print spr" "" {
-re -wrap $re_pass {
pass $gdb_test_name
}
-re -wrap $re_xfail_le|$re_xfail_be {
if { $have_xfail } {
xfail $gdb_test_name
} else {
fail $gdb_test_name
}
}
}
set re_pass " = -5"
set re_xfail_le " = -4"
set re_xfail_be " = -6"
gdb_test_multiple "print spr.field" "" {
-re -wrap $re_pass {
pass $gdb_test_name
}
-re -wrap $re_xfail_le|$re_xfail_be {
if { $have_xfail } {
xfail $gdb_test_name
} else {
fail $gdb_test_name
}
}
}