Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

objdump -g on gcc COFF/PE files

Browse Source 
objdump -g can't be used much.  Trying to dump PE files invariably
seems to run into "debug_name_type: no current file" or similar
errors, because parse_coff expects a C_FILE symbol to be the first
symbol.  Dumping -gstabs output works since the N_SO stab is present.
Pre-setting the file name won't hurt stabs dumping.

	* rddbg.c (read_debugging_info): Call debug_set_filename.
This commit is contained in:
Alan Modra
2023-04-06 09:24:01 +09:30
parent 6ff1cef1b4
commit ff93c7b1a2
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
binutils/rddbg.c
View File

@@ -53,15 +53,18 @@ read_debugging_info (bfd *abfd, asymbol **syms, long symcount,
if (dhandle == NULL) if (dhandle == NULL)
return NULL; return NULL;
if (!debug_set_filename (dhandle, bfd_get_filename (abfd)))
return NULL;
if (! read_section_stabs_debugging_info (abfd, syms, symcount, dhandle, if (! read_section_stabs_debugging_info (abfd, syms, symcount, dhandle,
&found)) &found))
goto err_exit; return NULL;
if (bfd_get_flavour (abfd) == bfd_target_aout_flavour) if (bfd_get_flavour (abfd) == bfd_target_aout_flavour)
{ {
if (! read_symbol_stabs_debugging_info (abfd, syms, symcount, dhandle, if (! read_symbol_stabs_debugging_info (abfd, syms, symcount, dhandle,
&found)) &found))
goto err_exit; return NULL;
} }
/* Try reading the COFF symbols if we didn't find any stabs in COFF /* Try reading the COFF symbols if we didn't find any stabs in COFF
@@ -71,7 +74,7 @@ read_debugging_info (bfd *abfd, asymbol **syms, long symcount,
&& symcount > 0) && symcount > 0)
{ {
if (! parse_coff (abfd, syms, symcount, dhandle)) if (! parse_coff (abfd, syms, symcount, dhandle))
goto err_exit; return NULL;
found = true; found = true;
} }
@@ -80,7 +83,6 @@ read_debugging_info (bfd *abfd, asymbol **syms, long symcount,
if (! no_messages) if (! no_messages)
non_fatal (_("%s: no recognized debugging information"), non_fatal (_("%s: no recognized debugging information"),
bfd_get_filename (abfd)); bfd_get_filename (abfd));
err_exit:
return NULL; return NULL;
} }