Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[gdb/testsuite] Fix regexp in list-thread-groups-available.exp

Browse Source 
I ran into a gdb.mi/list-thread-groups-available.exp failure:
...
Running gdb/testsuite/gdb.mi/list-thread-groups-available.exp ...
FAIL: gdb.mi/list-thread-groups-available.exp:
        list available thread groups (unexpected output)
PASS: gdb.mi/list-thread-groups-available.exp:
        list available thread groups with filter
...
When doing an experiment of running it 100 times in a row, the failure
reproduced 3 times.

Analyzing the original failure led to insufficient quoting of square brackets
in a regexp.  This patch fixes the regexp, which resulted in 0 failures in a
100-in-a-row run.

Tested on x86_64-linux.

2018-07-19  Tom de Vries  <tdevries@suse.de>

	* gdb.mi/list-thread-groups-available.exp (cores_re): Fix quoting in
	regular	expression.
This commit is contained in:
Tom de Vries
2018-07-19 16:24:16 +02:00
parent db3410f80f
commit fbb1d502ee
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@@ -1,3 +1,8 @@
2018-07-19 Tom de Vries <tdevries@suse.de>
* gdb.mi/list-thread-groups-available.exp (cores_re): Fix quoting in
regular expression.
2018-07-18 Tom de Vries <tdevries@suse.de> 2018-07-18 Tom de Vries <tdevries@suse.de>
* gdb.base/vla-optimized-out.c: New test. * gdb.base/vla-optimized-out.c: New test.

2
gdb/testsuite/gdb.mi/list-thread-groups-available.exp
View File

@@ -45,7 +45,7 @@ set id_re "id=\"$decimal\""
set type_re "type=\"process\"" set type_re "type=\"process\""
set description_re "description=\"$string_re\"" set description_re "description=\"$string_re\""
set user_re "user=\"$string_re\"" set user_re "user=\"$string_re\""
set cores_re "cores=\[\"$decimal\"(,\"$decimal\")*\]" set cores_re "cores=\\\[\"$decimal\"(,\"$decimal\")*\\\]"
# List all available processes. # List all available processes.
set process_entry_re "{${id_re},${type_re}(,$description_re)?(,$user_re)?(,$cores_re)?}" set process_entry_re "{${id_re},${type_re}(,$description_re)?(,$user_re)?(,$cores_re)?}"