Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Remove VEC from breakpoint

Browse Source 
This removes a use of VEC from breakpoint.h, also removing the
now-unnecessary breakpoint_p typedef.

This patch fixes a latent memory leak in
find_matching_tracepoint_location, which neglected to free the vector
returned by all_tracepoints.

Tested by the buildbot.

gdb/ChangeLog
2018-07-03  Tom Tromey  <tom@tromey.com>

	* tracepoint.c (process_tracepoint_on_disconnect, start_tracing)
	(stop_tracing, tstatus_command)
	(find_matching_tracepoint_location, merge_uploaded_tracepoints)
	(print_one_static_tracepoint_marker): Update.
	* breakpoint.c (static_tracepoints_here, all_tracepoints): Return
	std::vector.
	* breakpoint.h (breakpoint_p): Remove typedef.  Don't declare
	VEC.
	(all_tracepoints, static_tracepoints_here): Return std::vector.
This commit is contained in:
Tom Tromey
2018-06-05 10:22:01 -06:00
parent 9b960ba18c
commit f51e0e20bd
4 changed files with 44 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gdb/breakpoint.c
View File

@@ -1145,11 +1145,11 @@ validate_commands_for_breakpoint (struct breakpoint *b,
/* Return a vector of all the static tracepoints set at ADDR. The
caller is responsible for releasing the vector. */
VEC(breakpoint_p) *
std::vector<breakpoint *>
static_tracepoints_here (CORE_ADDR addr)
{
struct breakpoint *b;
VEC(breakpoint_p) *found = 0;
std::vector<breakpoint *> found;
struct bp_location *loc;
ALL_BREAKPOINTS (b)
@@ -1157,7 +1157,7 @@ static_tracepoints_here (CORE_ADDR addr)
{
for (loc = b->loc; loc; loc = loc->next)
if (loc->address == addr)
VEC_safe_push(breakpoint_p, found, b);
found.push_back (b);
}
return found;
@@ -15166,15 +15166,15 @@ save_tracepoints_command (const char *args, int from_tty)
/* Create a vector of all tracepoints. */
VEC(breakpoint_p) *
std::vector<breakpoint *>
all_tracepoints (void)
{
VEC(breakpoint_p) *tp_vec = 0;
std::vector<breakpoint *> tp_vec;
struct breakpoint *tp;
ALL_TRACEPOINTS (tp)
{
VEC_safe_push (breakpoint_p, tp_vec, tp);
tp_vec.push_back (tp);
}
return tp_vec;