breakpoint: Make is_*point functions return bool

This includes changing the FILTER parameters of two functions
accordingly.  I also tried to normalize the function comments to our
current standards.

gdb/ChangeLog:

	* breakpoint.c (is_hardware_watchpoint): Remove
	forward-declaration.
	(is_masked_watchpoint): Change return type to bool.
	(is_tracepoint): Likewise.
	(is_breakpoint): Likewise.
	(is_hardware_watchpoint): Likewise.
	(is_watchpoint): Likewise.
	(is_no_memory_software_watchpoint): Likewise.
	(is_catchpoint): Likewise.
	(breakpoint_1): Make FILTER parameter's return type bool.
	is_masked_watchpoint): Change return type to bool.
	(save_breakpoints): Make FILTER parameter's return type bool.
	* breakpoint.h (is_breakpoint): Change return type to bool.
	(is_watchpoint): Likewise.
	(is_catchpoint): Likewise.
	(is_tracepoint): Likewise.
This commit is contained in:
Simon Marchi
2019-07-10 21:20:38 -04:00
committed by Simon Marchi
parent 2ee0a9b7bc
commit f2478a7e8b
3 changed files with 47 additions and 30 deletions

View File

@@ -866,11 +866,12 @@ extern struct breakpoint *breakpoint_find_if
/* Return true if BPT is either a software breakpoint or a hardware
breakpoint. */
extern int is_breakpoint (const struct breakpoint *bpt);
extern bool is_breakpoint (const struct breakpoint *bpt);
/* Returns true if BPT is really a watchpoint. */
/* Return true if BPT is of any watchpoint kind, hardware or
software. */
extern int is_watchpoint (const struct breakpoint *bpt);
extern bool is_watchpoint (const struct breakpoint *bpt);
/* Return true if BPT is a C++ exception catchpoint (catch
catch/throw/rethrow). */
@@ -1554,8 +1555,9 @@ extern void remove_solib_event_breakpoints_at_next_stop (void);
extern void disable_breakpoints_in_shlibs (void);
/* This function returns TRUE if ep is a catchpoint. */
extern int is_catchpoint (struct breakpoint *);
/* This function returns true if B is a catchpoint. */
extern bool is_catchpoint (struct breakpoint *b);
/* Shared helper function (MI and CLI) for creating and installing
a shared object event catchpoint. */
@@ -1634,7 +1636,9 @@ extern struct tracepoint *
/* Return a vector of all tracepoints currently defined. */
extern std::vector<breakpoint *> all_tracepoints (void);
extern int is_tracepoint (const struct breakpoint *b);
/* Return true if B is of tracepoint kind. */
extern bool is_tracepoint (const struct breakpoint *b);
/* Return a vector of all static tracepoints defined at ADDR. */
extern std::vector<breakpoint *> static_tracepoints_here (CORE_ADDR addr);