Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

sim: delete duplicate SIGINT handling

Browse Source 
Many of the simulators change the SIGINT handler.
E.g., moxie/interp.c:

  sigsave = signal (SIGINT, interrupt);

However, this is unnecessary.
remote-sim.h already provides an API for asynchronously stopping
a sim; and both gdb and the drivers (run.c and nrun.c at least,
I didn't check the others) install a SIGINT handler which
calls this method.

URL: https://sourceware.org/bugzilla/show_bug.cgi?id=16450
Reported-by: Tom Tromey <tromey@redhat.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
This commit is contained in:
Mike Frysinger
2014-02-17 18:24:10 -05:00
parent c395f86f51
commit ef3e8cf7d1
10 changed files with 31 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
sim/h8300/compile.c
View File

@@ -1859,15 +1859,6 @@ init_pointers (SIM_DESC sd)
}
}
/* Grotty global variable for use by control_c signal handler. */
static SIM_DESC control_c_sim_desc;
static void
control_c (int sig)
{
sim_engine_set_run_state (control_c_sim_desc, sim_stopped, SIGINT);
}
int
sim_stop (SIM_DESC sd)
{
@@ -1901,7 +1892,6 @@ sim_resume (SIM_DESC sd, int step, int siggnal)
int cycles = 0;
int insts = 0;
int tick_start = get_now ();
void (*prev) ();
int poll_count = 0;
int res;
int tmp;
@@ -1917,9 +1907,6 @@ sim_resume (SIM_DESC sd, int step, int siggnal)
init_pointers (sd);
control_c_sim_desc = sd;
prev = signal (SIGINT, control_c);
if (step)
{
sim_engine_set_run_state (sd, sim_stopped, SIGTRAP);
@@ -4604,7 +4591,6 @@ sim_resume (SIM_DESC sd, int step, int siggnal)
h8_set_exr (sd, (trace<<7) | intMask);
h8_set_mask (sd, oldmask);
signal (SIGINT, prev);
}
int