Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[gdb/testsuite] Fix tcl ERROR in gdb_load_no_complaints

Browse Source 
In commit cf2b207529 "[gdb/symtab] Fix element type modification in
read_array_type" I factored out new proc with_complaints out of proc
gdb_load_no_complaints, but when fixing a rebase conflict pre-commit I made a
mistake in gdb_load_no_complaints that is now causing:
...
ERROR: tcl error sourcing dw2-ranges-psym.exp.
ERROR: can't read "save": no such variable
    while executing
"gdb_test_no_output "set complaints $save" """
    (procedure "gdb_load_no_complaints" line 14)
    invoked from within
"gdb_load_no_complaints $binfile"
...

Fix this by removing the offending line.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2021-02-10  Tom de Vries  <tdevries@suse.de>

	* lib/gdb.exp (gdb_load_no_complaints): Remove unnecessary
	"Restore saved setting of complaints".
This commit is contained in:
Tom de Vries
2021-02-10 11:43:46 +01:00
parent 01e8b831f5
commit ee4c3d8801
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@@ -1,3 +1,8 @@
2021-02-10 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (gdb_load_no_complaints): Remove unnecessary
"Restore saved setting of complaints".
2021-02-09 Tom de Vries <tdevries@suse.de>
PR symtab/27341

3
gdb/testsuite/lib/gdb.exp
View File

@@ -5149,9 +5149,6 @@ proc gdb_load_no_complaints { arg } {
# Verify that there were no complaints.
set re "^Reading symbols from \[^\r\n\]*\r\n$gdb_prompt $"
gdb_assert {[regexp $re $gdb_file_cmd_msg]} "No complaints"
# Restore saved setting of complaints.
gdb_test_no_output "set complaints $save" ""
}
# gdb_reload -- load a file into the target. Called before "running",