Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

XCOFF C_STSYM test failure on 32-bit host

Browse Source 
This test was failing here and on another similar symbol:
[  4](sec  1)(fl 0x00)(ty   0)(scl 143) (nx 0) 0x05d1745d11745d21 .bs
where correct output is
[  4](sec  1)(fl 0x00)(ty   0)(scl 143) (nx 0) 0x000000000000000a .bs

The problem is caused by a 32-bit host pointer being sign-extended
when stored into a 64-bit bfd_vma, and then that value not being
trimmed back to 32 bits when used.  The following belt-and-braces
patch fixes both the store and subsequent reads.

	* coffcode.h (coff_slurp_symbol_table): Do not sign extend
	when storing a host pointer to syment.n_value.
	* coffgen.c (coff_get_symbol_info): Cast syment.n_value to a
	bfd_hostptr_t before using in arithmetic.
	(coff_print_symbol): Likewise.
This commit is contained in:
Alan Modra
2021-12-14 21:13:21 +10:30
parent 237f6eac15
commit eda0ddeb26
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
bfd/coffgen.c
View File

@@ -2130,10 +2130,10 @@ coff_get_symbol_info (bfd *abfd, asymbol *symbol, symbol_info *ret)
if (coffsymbol (symbol)->native != NULL
&& coffsymbol (symbol)->native->fix_value
&& coffsymbol (symbol)->native->is_sym)
ret->value =
((coffsymbol (symbol)->native->u.syment.n_value -
(bfd_hostptr_t) obj_raw_syments (abfd))
/ sizeof (combined_entry_type));
ret->value
= (((bfd_hostptr_t) coffsymbol (symbol)->native->u.syment.n_value
- (bfd_hostptr_t) obj_raw_syments (abfd))
/ sizeof (combined_entry_type));
}
/* Print out information about COFF symbol. */
@@ -2181,7 +2181,8 @@ coff_print_symbol (bfd *abfd,
if (! combined->fix_value)
val = (bfd_vma) combined->u.syment.n_value;
else
val = ((combined->u.syment.n_value - (bfd_hostptr_t) root)
val = (((bfd_hostptr_t) combined->u.syment.n_value
- (bfd_hostptr_t) root)
/ sizeof (combined_entry_type));
fprintf (file, "(sec %2d)(fl 0x%02x)(ty %3x)(scl %3d) (nx %d) 0x",