Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

coff-sh.c keep_relocs, keep_contents and keep_syms

Browse Source 
keep_relocs and keep_contents are unused nowadays except by
xcofflink.c, and I can't see a reason why keep_syms needs to be set.
The external syms are read and used by sh_relax_section and used by
sh_relax_delete_bytes.  There doesn't appear to be any way that
freeing them will cause trouble.

	* coff-sh.c (sh_relax_section): Don't set keep_relocs,
	keep_contents or keep_syms.
	(sh_relax_delete_bytes): Don't set keep_contents.
This commit is contained in:
Alan Modra
2023-02-08 23:51:04 +10:30
parent 389903128a
commit ec78da9ce6
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
bfd/coff-sh.c
View File

@@ -905,12 +905,7 @@ sh_relax_section (bfd *abfd,
the linker is run. */ the linker is run. */
coff_section_data (abfd, sec)->relocs = internal_relocs; coff_section_data (abfd, sec)->relocs = internal_relocs;
coff_section_data (abfd, sec)->keep_relocs = true;
coff_section_data (abfd, sec)->contents = contents; coff_section_data (abfd, sec)->contents = contents;
coff_section_data (abfd, sec)->keep_contents = true;
obj_coff_keep_syms (abfd) = true;
/* Replace the jsr with a bsr. */ /* Replace the jsr with a bsr. */
@@ -1027,12 +1022,7 @@ sh_relax_section (bfd *abfd,
if (swapped) if (swapped)
{ {
coff_section_data (abfd, sec)->relocs = internal_relocs; coff_section_data (abfd, sec)->relocs = internal_relocs;
coff_section_data (abfd, sec)->keep_relocs = true;
coff_section_data (abfd, sec)->contents = contents; coff_section_data (abfd, sec)->contents = contents;
coff_section_data (abfd, sec)->keep_contents = true;
obj_coff_keep_syms (abfd) = true;
} }
} }
@@ -1435,8 +1425,6 @@ sh_relax_delete_bytes (bfd *abfd,
if (val > addr && val < toaddr) if (val > addr && val < toaddr)
bfd_put_32 (abfd, val - count, bfd_put_32 (abfd, val - count,
ocontents + irelscan->r_vaddr - o->vma); ocontents + irelscan->r_vaddr - o->vma);
coff_section_data (abfd, o)->keep_contents = true;
} }
} }
} }