Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb: make inferior::args a unique_xmalloc_ptr

Browse Source 
Use unique_xmalloc_ptr to avoid manual memory management.

gdb/ChangeLog:

	* inferior.h (class inferior) <args>: Change type to
	unique_xmalloc_ptr.
	* inferior.c (inferior::~inferior): Don't free args.
	* infcmd.c (get_inferior_args): Adjust.
	(set_inferior_args): Adjust.

Change-Id: I96300e59eb2faf2d80660416a8f5694d243a944e
This commit is contained in:
Simon Marchi
2021-05-06 13:16:26 -04:00
parent 482155e609
commit ec66d6ea54
4 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gdb/infcmd.c
View File

@@ -136,9 +136,9 @@ get_inferior_args (void)
}
if (current_inferior ()->args == NULL)
current_inferior ()->args = xstrdup ("");
current_inferior ()->args = make_unique_xstrdup ("");
return current_inferior ()->args;
return current_inferior ()->args.get ();
}
/* Set the arguments for the current inferior. Ownership of
@@ -147,8 +147,11 @@ get_inferior_args (void)
void
set_inferior_args (const char *newargs)
{
xfree (current_inferior ()->args);
current_inferior ()->args = newargs ? xstrdup (newargs) : NULL;
if (newargs != nullptr)
current_inferior ()->args = make_unique_xstrdup (newargs);
else
current_inferior ()->args.reset ();
current_inferior ()->argc = 0;
current_inferior ()->argv = 0;
}