Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Fix build failure in d10v sim

Browse Source 
While building all targets on Ubuntu 20.04/aarch64, I ran into the following
build error:

In file included from /usr/include/string.h:495,
                 from ../../bfd/bfd.h:48,
                 from ../../../../repos/binutils-gdb/sim/d10v/interp.c:4:
In function memset,
    inlined from sim_create_inferior at ../../../../repos/binutils-gdb/sim/d10v/interp.c:1146:3:
/usr/include/aarch64-linux-gnu/bits/string_fortified.h:71:10: error: __builtin_memset offset [33, 616] from the object at State is out of the bounds of referenced subobject regs with type reg_t[16] {aka short unsigned int[16]} at offset 0 [-Werror=array-bounds]
   71 |   return __builtin___memset_chk (__dest, __ch, __len, __bos0 (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [Makefile:558: interp.o] Error 1

The following patch fixes this.

sim/ChangeLog:

2021-05-12  Luis Machado  <luis.machado@linaro.org>

	* d10v/interp.c (sim_create_inferior): Fix memset call.
This commit is contained in:
Luis Machado
2021-05-10 16:06:50 -03:00
parent 4a1ad5c9e4
commit e7e40cedbb
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sim/ChangeLog
View File

@@ -1,3 +1,7 @@
2021-05-12 Luis Machado <luis.machado@linaro.org>
* d10v/interp.c (sim_create_inferior): Fix memset call.
2021-05-07 Dimitar Dimitrov <dimitar@dinux.eu> 2021-05-07 Dimitar Dimitrov <dimitar@dinux.eu>
* Makefile.in: Rebuild. * Makefile.in: Rebuild.

9
sim/d10v/interp.c
View File

@@ -13,6 +13,7 @@
#include <string.h> #include <string.h>
#include <stdlib.h> #include <stdlib.h>
#include <assert.h>
enum _leftright { LEFT_FIRST, RIGHT_FIRST }; enum _leftright { LEFT_FIRST, RIGHT_FIRST };
@@ -1142,8 +1143,12 @@ sim_create_inferior (SIM_DESC sd, struct bfd *abfd,
{ {
bfd_vma start_address; bfd_vma start_address;
/* reset all state information */ /* Make sure we have the right structure for the following memset. */
memset (&State.regs, 0, (uintptr_t)&State.mem - (uintptr_t)&State.regs); static_assert ((uintptr_t) &State == (uintptr_t) &State.regs,
"&State != &State.regs");
/* Reset state from the regs field until the mem field. */
memset (&State, 0, (uintptr_t) &State.mem - (uintptr_t) &State.regs);
/* There was a hack here to copy the values of argc and argv into r0 /* There was a hack here to copy the values of argc and argv into r0
and r1. The values were also saved into some high memory that and r1. The values were also saved into some high memory that