Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

* bcache.c (deprecated_bcache_added): Initialize obstack.

Browse Source 
(bcache_xmalloc): Don't initialize obstack.
	(bcache_xfree): Conditionally free obstack.
	(bcache_memory_used): Update.
This commit is contained in:
Tom Tromey
2008-08-05 20:43:17 +00:00
parent 11d31d9471
commit e6ad058ac4
2 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
gdb/bcache.c
View File

@@ -217,6 +217,16 @@ bcache_full (const void *addr, int length, struct bcache *bcache, int *added)
if (added)
*added = 0;
/* Lazily initialize the obstack. This can save quite a bit of
memory in some cases. */
if (bcache->total_count == 0)
{
/* We could use obstack_specify_allocation here instead, but
gdb_obstack.h specifies the allocation/deallocation
functions. */
obstack_init (&bcache->cache);
}
/* If our average chain length is too high, expand the hash table. */
if (bcache->unique_count >= bcache->num_buckets * CHAIN_LENGTH_THRESHOLD)
expand_hash_table (bcache);
@@ -271,10 +281,6 @@ bcache_xmalloc (void)
{
/* Allocate the bcache pre-zeroed. */
struct bcache *b = XCALLOC (1, struct bcache);
/* We could use obstack_specify_allocation here instead, but
gdb_obstack.h specifies the allocation/deallocation
functions. */
obstack_init (&b->cache);
return b;
}
@@ -284,7 +290,9 @@ bcache_xfree (struct bcache *bcache)
{
if (bcache == NULL)
return;
obstack_free (&bcache->cache, 0);
/* Only free the obstack if we actually initialized it. */
if (bcache->total_count > 0)
obstack_free (&bcache->cache, 0);
xfree (bcache->bucket);
xfree (bcache);
}
@@ -443,5 +451,7 @@ print_bcache_statistics (struct bcache *c, char *type)
int
bcache_memory_used (struct bcache *bcache)
{
if (bcache->total_count == 0)
return 0;
return obstack_memory_used (&bcache->cache);
}