Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[gdbsupport] Add gdb::array_view::{iterator,const_iterator}

Browse Source 
While trying to substitute some std::vector type A in the code with a
gdb::array_view:
...
- using A = std::vector<T>
+ using A = gdb::array_view<T>
....
I ran into the problem that the code was using A::iterator while
gdb::array_view doesn't define such a type.

Fix this by:
- adding types gdb::array_view::iterator and gdb::array_view::const_iterator,
- using them in gdb::array_view::(c)begin and gdb::array_view::(c)end, as is
  usual, and
- using them explicitly in a unit test.

Tested on aarch64-linux.

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Tom de Vries
2024-10-19 08:10:38 +02:00
parent 6c8052f6b2
commit e686338105
2 changed files with 42 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gdbsupport/array-view.h
View File

@@ -88,6 +88,8 @@ public:
using reference = T &;
using const_reference = const T &;
using size_type = size_t;
using const_iterator = const T *;
using iterator = T *;
/* Default construction creates an empty view. */
constexpr array_view () noexcept
@@ -157,11 +159,11 @@ public:
constexpr T *data () noexcept { return m_array; }
constexpr const T *data () const noexcept { return m_array; }
constexpr T *begin () const noexcept { return m_array; }
constexpr const T *cbegin () const noexcept { return m_array; }
constexpr iterator begin () const noexcept { return m_array; }
constexpr const_iterator cbegin () const noexcept { return m_array; }
constexpr T *end () const noexcept { return m_array + m_size; }
constexpr const T *cend () const noexcept { return m_array + m_size; }
constexpr iterator end () const noexcept { return m_array + m_size; }
constexpr const_iterator cend () const noexcept { return m_array + m_size; }
constexpr reference operator[] (size_t index) noexcept
{