[Ada] Fix unconstrained packed array size

When ada-lang transforms an array descriptor type (an XUP structure)
into an array type, the size of the array type is computed by using
the element size, and multiplying it by the number of elements in
that array. This does not work, however, for packed arrays, where
the *packed* size in bits needs to be used.

This usually does not cause any problem, because we end up reading
more memory than needed.  However, we have observed on LynxOS
a memory error while trying to read the entire array, because
the larger-than-needed read tried to read past the end of the stack
into inaccessible memory.

This patch fixes the problem by correctly computing the array size
in bytes in the case of packed arrays.

gdb/ChangeLog:

        * ada-lang.c (ada_type_of_array): Fix the size of the array
        in the case of an unconstrained packed array.

gdb/testsuite/ChangeLog:

        * gdb.ada/packed_array: Expand testcase to test printing of
        unconstrained packed array.
This commit is contained in:
Joel Brobecker
2011-02-17 06:42:57 +00:00
parent 93084bcabb
commit e67ad678a1
7 changed files with 86 additions and 2 deletions

View File

@@ -14,6 +14,8 @@
-- You should have received a copy of the GNU General Public License
-- along with this program. If not, see <http://www.gnu.org/licenses/>.
with Pck; use Pck;
procedure PA is
type Packed_Array is array (4 .. 8) of Boolean;
@@ -21,9 +23,17 @@ procedure PA is
Var : Packed_Array;
-- Unconstrained packed array (bounds are dynamic).
type Unconstrained_Packed_Array is array (Integer range <>) of Boolean;
U_Var : Unconstrained_Packed_Array (1 .. Ident (6));
begin
Var := (True, False, True, False, True);
U_Var := (True, False, False, True, True, False);
Var (8) := False; -- STOP
U_Var (U_Var'Last) := True;
end PA;