Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb: fix ppc-sysv-tdep.c build on 32-bit platforms

Browse Source 
The previous code triggered the following error on an i386 host:

/git/gdb/gdb/ppc-sysv-tdep.c:1764:34: error: non-constant-expression cannot be narrowed from type 'ULONGEST' (aka 'unsigned long long') to 'size_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
              unscaled.read ({writebuf, TYPE_LENGTH (valtype)},
                                        ^~~~~~~~~~~~~~~~~~~~~
/git/gdb/gdb/gdbtypes.h:2043:31: note: expanded from macro 'TYPE_LENGTH'
                              ^~~~~~~~~~~~~~~~~~
/git/gdb/gdb/ppc-sysv-tdep.c:1764:34: note: insert an explicit cast to silence this issue
              unscaled.read ({writebuf, TYPE_LENGTH (valtype)},
                                        ^~~~~~~~~~~~~~~~~~~~~
                                        static_cast<size_t>( )
/git/gdb/gdb/gdbtypes.h:2043:31: note: expanded from macro 'TYPE_LENGTH'
                              ^~~~~~~~~~~~~~~~~~
1 error generated.

Fix this by using gdb::make_array_view.
This commit is contained in:
John Baldwin
2022-01-28 11:22:02 -08:00
parent 00d7af046f
commit e5783467a3
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gdb/ppc-sysv-tdep.c
View File

@@ -1761,7 +1761,8 @@ ppc64_sysv_abi_return_value_base (struct gdbarch *gdbarch, struct type *valtype,
/* Fixed point type values need to be returned unscaled. */ /* Fixed point type values need to be returned unscaled. */
gdb_mpz unscaled; gdb_mpz unscaled;
unscaled.read ({writebuf, TYPE_LENGTH (valtype)}, unscaled.read (gdb::make_array_view (writebuf,
TYPE_LENGTH (valtype)),
type_byte_order (valtype), type_byte_order (valtype),
valtype->is_unsigned ()); valtype->is_unsigned ());
return_val = unscaled.as_integer<LONGEST> (); return_val = unscaled.as_integer<LONGEST> ();