gdb/fortran: Correct the lval type for array elements of internal vars

Since this commit:

  commit a5c641b57b
  Date:   Thu Oct 8 16:45:59 2020 +0100

      gdb/fortran: Add support for Fortran array slices at the GDB prompt

A bug was introduced into GDB.  Consider this Fortan array:

  integer, dimension (1:10) :: array
  array = 1

Now inside GDB:

  (gdb) set $var = array
  (gdb) set $var(1) = 2
  Left operand of assignment is not an lvalue.

The problem is that the new code for slicing Fortran arrays now does
not set the lval type correctly for arrays that are not in memory.
This is easily fixed by making use of value_from_component.

After this the above example behaves as you'd expect.

gdb/ChangeLog:

	* f-lang.c (fortran_value_subarray): Call value_from_component.

gdb/testsuite/ChangeLog:

	* gdb.fortran/intvar-array.exp: New file.
	* gdb.fortran/intvar-array.f90: New file.
This commit is contained in:
Andrew Burgess
2021-01-07 17:13:21 +00:00
parent f4cfa91741
commit e343681375
5 changed files with 97 additions and 5 deletions

View File

@@ -690,11 +690,7 @@ fortran_value_subarray (struct value *array, struct expression *exp,
+ total_offset));
}
else if (!value_lazy (array))
{
const void *valaddr = value_contents (array) + total_offset;
array = allocate_value (array_slice_type);
memcpy (value_contents_raw (array), valaddr, TYPE_LENGTH (array_slice_type));
}
array = value_from_component (array, array_slice_type, total_offset);
else
error (_("cannot subscript arrays that are not in memory"));
}